Skip to content

actions(concurrency): fix typo#22946

Closed
amithm7 wants to merge 1 commit intogithub:mainfrom
amithm7:patch-1
Closed

actions(concurrency): fix typo#22946
amithm7 wants to merge 1 commit intogithub:mainfrom
amithm7:patch-1

Conversation

@amithm7
Copy link
Copy Markdown

@amithm7 amithm7 commented Jan 2, 2023

Why:

To cancel workflows in same concurrency group, cancel-in-progress: true option is needed.

Currently docs state, "will be cancelled" which implies it as default behavior, although it is not.

What's being changed (if available, include any code snippets, screenshots, or gifs):

"will be cancelled" -> "can be cancelled"

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

"will be cancelled" implies default behaviour, although it is not.
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 2, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jan 2, 2023
@cmwilson21
Copy link
Copy Markdown
Contributor

@amithm7 Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Jan 3, 2023
@skedwards88
Copy link
Copy Markdown
Contributor

Thanks for opening this issue! You are correct that you must specify cancel-in-progress: true in order to cancel any job/workflow that is currently running. However, any pending jobs/workflows should be canceled by default. With that distinction in mind, I'm going to close this PR, but I hope to see more contributions from you in the future! If you feel that I am mistaken or misunderstood you, feel free to open an issue and we can discuss more.

@skedwards88 skedwards88 closed this Feb 2, 2023
@amithm7 amithm7 deleted the patch-1 branch February 7, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants