Skip to content

Replace link to deprecated doc with latest link#22974

Merged
cmwilson21 merged 6 commits intogithub:mainfrom
uhyo:patch-1
Jan 6, 2023
Merged

Replace link to deprecated doc with latest link#22974
cmwilson21 merged 6 commits intogithub:mainfrom
uhyo:patch-1

Conversation

@uhyo
Copy link
Copy Markdown
Contributor

@uhyo uhyo commented Jan 4, 2023

Why:

Hello, I was looking around the docs and found a link to a deprecated explanation about granting Codespaces access to other repositories.

What's being changed (if available, include any code snippets, screenshots, or gifs):

The link is updated to the latest and suggested solution.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 4, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jan 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/codespaces-reference/security-in-github-codespaces.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

@uhyo Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team Codespaces Content relating to GitHub Codespaces waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 4, 2023
@isaacmbrown
Copy link
Copy Markdown
Contributor

Hi @uhyo, thanks for the PR! ✨ Updating the link looks like a good call--however, I think we'll also need to make a few wording changes around the link. I'll add those now and check the wording with someone on the Codespaces team.

- **If you've enabled your codespace to access other repositories**: When a codespace has been granted [access to other repositories](/codespaces/managing-codespaces-for-your-organization/managing-access-and-security-for-your-organizations-codespaces), any codespace created from that repository will have read/write tokens scoped to the source repository. In addition, the tokens will also receive read access to other repositories indicated by the user or organization.
- **If you've enabled your codespace to access other repositories**: When a codespace has been granted [access to other repositories](/codespaces/managing-your-codespaces/managing-repository-access-for-your-codespaces), any codespace created from that repository will have read/write tokens scoped to the source repository. In addition, the tokens will also receive read access to other repositories indicated by the user or organization.

An organization's administrators specify which repositories should be considered trusted. An admin can [choose to trust](/codespaces/managing-codespaces-for-your-organization/managing-access-and-security-for-your-organizations-codespaces) none, all, or some of the organization's repositories. A codespace can't have greater permissions to access resources than the person who created it, even if the organization administrator has granted access to all users and all repositories.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this paragraph, given the feature is deprecated?

Copy link
Copy Markdown

@VincentDondain VincentDondain Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it would make sense to delete this as well based on the deprecation notice.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this paragraph should be removed, thanks @isaacmbrown.

Comment thread content/codespaces/codespaces-reference/security-in-github-codespaces.md Outdated
VincentDondain
VincentDondain previously approved these changes Jan 4, 2023
Copy link
Copy Markdown

@VincentDondain VincentDondain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread content/codespaces/codespaces-reference/security-in-github-codespaces.md Outdated
Comment thread content/codespaces/codespaces-reference/security-in-github-codespaces.md Outdated
Copy link
Copy Markdown
Contributor

@isaacmbrown isaacmbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on staging -- ready to merge

@isaacmbrown isaacmbrown added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 5, 2023
@cmwilson21 cmwilson21 enabled auto-merge January 6, 2023 15:15
@cmwilson21 cmwilson21 merged commit 9f7c563 into github:main Jan 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants