Skip to content

Update working-with-the-npm-registry.md#23117

Merged
vgrl merged 3 commits intogithub:mainfrom
zizyan:main
Jan 20, 2023
Merged

Update working-with-the-npm-registry.md#23117
vgrl merged 3 commits intogithub:mainfrom
zizyan:main

Conversation

@zizyan
Copy link
Copy Markdown
Contributor

@zizyan zizyan commented Jan 10, 2023

Update npm login instruction based on npm version 9 requirement.

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

  1. Added instruction "We also recommend you use --auth-type=legacy flag if your npm is verion 9 or later to avoid web login not supported error."

  2. Updated npm login command from

$ npm login --scope=https://github.com/owner --registry=https://hostname/_registry/npm/

    Username: USERNAME
    Password: TOKEN
    Email: PUBLIC-EMAIL-ADDRESS

to

$ npm login --scope=https://github.com/owner --auth-type=legacy --registry=https://hostname/_registry/npm/

    > Username: USERNAME
    > Password: TOKEN

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Update npm login instruction based on npm version 9 requirement.
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jan 10, 2023
@cmwilson21
Copy link
Copy Markdown
Contributor

👋 Hey @zizyan - I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team content This issue or pull request belongs to the Docs Content team labels Jan 11, 2023
Copy link
Copy Markdown
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zizyan ! I am going to apply a few small changes, then I'll double check on preview and merge if all looks good! ⚡

@github-actions
Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
packages/working-with-a-github-packages-registry/working-with-the-npm-registry.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

Copy link
Copy Markdown
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good on preview.

@vgrl vgrl added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 20, 2023
@vgrl vgrl merged commit 41f5209 into github:main Jan 20, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team packages This issue or pull request should be reviewed by the docs packages team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packages: Working with the npm registry: missing npm login argument for npm v9

4 participants