Skip to content

Grammar: cannot#23559

Merged
sophietheking merged 2 commits intogithub:mainfrom
jsoref:grammar-cannot
Jan 31, 2023
Merged

Grammar: cannot#23559
sophietheking merged 2 commits intogithub:mainfrom
jsoref:grammar-cannot

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Jan 29, 2023

Why:

can not is wrong. https://www.grammarly.com/blog/cannot-or-can-not/

What's being changed (if available, include any code snippets, screenshots, or gifs):

https://docs.github.com/en/actions/learn-github-actions/expressions#object-filters

Before
image

After
image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jan 29, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 29, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/learn-github-actions/expressions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

👋 @jsoref Thanks for catching this! I'll get it reviewed ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 30, 2023
Copy link
Copy Markdown
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoref thanks for fixing this! I'll make sure tests are passing and get this merged for you.

@sophietheking sophietheking added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 31, 2023
@sophietheking sophietheking merged commit 828c9c4 into github:main Jan 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the grammar-cannot branch January 31, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants