Skip to content

Im trying#23593

Closed
ChenJay1290 wants to merge 1 commit intogithub:mainfrom
ChenJay1290:patch-1
Closed

Im trying#23593
ChenJay1290 wants to merge 1 commit intogithub:mainfrom
ChenJay1290:patch-1

Conversation

@ChenJay1290
Copy link
Copy Markdown

@ChenJay1290 ChenJay1290 commented Jan 31, 2023

Thnks

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Thnks
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 31, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jan 31, 2023
@SeanKilleen
Copy link
Copy Markdown
Contributor

Hi @ChenJay1290! Congrats on your first ever pull request. 🎉

I'm not from the GitHub team, but happened to see this as I was browsing through. I thought I might offer some tips and feedback.

  • Your pull request does not appear to have any files changed in it. Typically, a pull request is done to ask a repository to accept some changes that you've authored. Did you mean to ask for a change, or were you just experimenting with pull request features? If you meant to change something, you may want to check out your branch and commit a change. Then, when you push those changes, they'll show up here in a pull request.
  • Your pull request title, "I'm trying", doesn't provide insight into the changes you'd like to make. Typically, a pull request will have a title that summarizes the changes.
  • Your pull request is missing a description, which helps people understand your intent when submitting a contribution. You may want to consider editing this to add a description so that people will understand your changes.
  • If you did not actually have a change to propose, but were just experimenting will pull request functionality in general, you may want to close this pull request and make a pull request against one of your own repositories (you can create a public repository on GitHub for free). This would allow you to experiment & try things without doing so in a highly active public repository.
    • If you'd like a copy of this repository to work with, that's typically called "forking". When you submitted these changes, GitHub actually created a fork for you at https://github.com/ChenJay1290/docs , so you've already got one available.
    • It can be a little confusing, because GitHub assumes that you're trying to make changes to the "upstream project" (GitHub's copy) rather than your project ("the fork"). When you submit a PR, you can choose where you'd like to attempt to merge the changes. To experiment with just your repository, choose chenjay1290/docs instead of the default-selected github/docs.

Hope this helps! OSS is a wonderful world; welcome to it.

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Jan 31, 2023
@cmwilson21
Copy link
Copy Markdown
Contributor

This seems to have been opened accidentally, I am going to close it now 💛

@ChenJay1290 Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions or check out issues with the help wanted label. ✨

@SeanKilleen - Thanks for all the helpful tips and advice! 💖

@cmwilson21 cmwilson21 closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants