Skip to content

https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node/.devcontainer/base.DockerfileUpdate#23623

Closed
etherscanio30012023220200 wants to merge 1 commit intogithub:mainfrom
etherscanio30012023220200:patch-1
Closed

https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node/.devcontainer/base.DockerfileUpdate#23623
etherscanio30012023220200 wants to merge 1 commit intogithub:mainfrom
etherscanio30012023220200:patch-1

Conversation

@etherscanio30012023220200
Copy link
Copy Markdown

See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node/.devcontainer/base.Dockerfile

[Choice] Node.js version

ARG VARIANT="18-buster"
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}

[Optional] Uncomment this section to install additional OS packages. # RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \

&& apt-get -y install --no-install-recommends

[Optional] Uncomment if you want to install an additional version of node using nvm # ARG EXTRA_NODE_VERSION=10

RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"

[Optional] Uncomment if you want to install more global node modules # RUN su node -c "npm install -g "

Install the GitHub CLI see:

https://github.com/microsoft/vscode-dev-containers/blob/3d59f9fe37edb68f78874620f33dac5a62ef2b93/script-library/docs/github.md COPY library-scripts/github-debian.sh /tmp/library-scripts/ RUN apt-get update && bash /tmp/library-scripts/github-debian.sh

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

# See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node/.devcontainer/base.Dockerfile

# [Choice] Node.js version
ARG VARIANT="18-buster"
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}

# [Optional] Uncomment this section to install additional OS packages.
# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
#     && apt-get -y install --no-install-recommends <your-package-list-here>

# [Optional] Uncomment if you want to install an additional version of node using nvm
# ARG EXTRA_NODE_VERSION=10
# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"

# [Optional] Uncomment if you want to install more global node modules
# RUN su node -c "npm install -g <your-package-list-here>"

# Install the GitHub CLI see:
# https://github.com/microsoft/vscode-dev-containers/blob/3d59f9fe37edb68f78874620f33dac5a62ef2b93/script-library/docs/github.md
COPY library-scripts/github-debian.sh /tmp/library-scripts/
RUN apt-get update && bash /tmp/library-scripts/github-debian.sh
@welcome
Copy link
Copy Markdown

welcome Bot commented Feb 1, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2023

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@Belfegoreo

This comment was marked as spam.

@mdrasad394
Copy link
Copy Markdown

mdrasad394 commented Feb 1, 2023 via email

@cmwilson21 cmwilson21 added invalid This issue/PR is invalid and removed triage Do not begin working on this issue until triaged by the team labels Feb 1, 2023
@cmwilson21 cmwilson21 removed the request for review from a team February 1, 2023 20:47
@github-actions github-actions Bot closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This issue/PR is invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants