Skip to content

Update index.md#23648

Closed
skhalife wants to merge 1 commit intogithub:mainfrom
skhalife:patch-1
Closed

Update index.md#23648
skhalife wants to merge 1 commit intogithub:mainfrom
skhalife:patch-1

Conversation

@skhalife
Copy link
Copy Markdown
Contributor

@skhalife skhalife commented Feb 2, 2023

Updated short title from "security harden" to "security hardening"

Why:

Updating a typo

What's being changed (if available, include any code snippets, screenshots, or gifs):

Updating the short title as to fix the typo here:
image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Updated short title from "security harden" to "security hardening"
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2023

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 2, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/security-hardening-your-deployments/index.md fpt
ghec
ghes@ 3.7 3.6 3.5
fpt
ghec
ghes@ 3.7 3.6 3.5

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

👋 @skhalife Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 2, 2023
@lucascosti
Copy link
Copy Markdown
Contributor

Hi @skhalife, thanks for this PR, but that isn't a typo. 🙂

For the short titles, we generally try to use the non-gerund verb to save some space. So 'hardening' becomes 'harden'.

@lucascosti lucascosti closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants