Skip to content

Conversation

@damiencornu
Copy link
Contributor

@damiencornu damiencornu commented Apr 8, 2023

Why:

A misformatted URL existed in the GitHub Apps guide "CI tests with the Checks API" section 1.2. An URL indicates domain/path:port when the expected format is domain:port/path.

What's being changed (if available, include any code snippets, screenshots, or gifs):

A URL displayed as code is corrected to display correct format. http://localhost/event_handler:3000 becomes http://localhost:3000/event_handler.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Apr 8, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/creating-github-apps/guides/creating-ci-tests-with-the-checks-api.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@damiencornu damiencornu marked this pull request as ready for review April 8, 2023 14:10
Copy link
Member

@steveward steveward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @damiencornu! This looks good to me so I'll get it merged.

@steveward steveward added this pull request to the merge queue Apr 12, 2023
Merged via the queue into github:main with commit 3de367f Apr 12, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants