Skip to content

Describe that people receive an email when converted to outside collaborator.#25031

Closed
trusktr wants to merge 1 commit intogithub:mainfrom
trusktr:patch-1
Closed

Describe that people receive an email when converted to outside collaborator.#25031
trusktr wants to merge 1 commit intogithub:mainfrom
trusktr:patch-1

Conversation

@trusktr
Copy link

@trusktr trusktr commented Apr 15, 2023

Why:

So people know the consequences of their actions. I'm not sure if an email is sent or not (please edit), but this should be clear. Some actions do send the target user an email, and we should document this so that people targeting actions on other users know what to expect.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Apr 15, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 15, 2023
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
organizations/managing-user-access-to-your-organizations-repositories/converting-an-organization-member-to-an-outside-collaborator.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@trusktr Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review organizations Content related to organizations and removed triage Do not begin working on this issue until triaged by the team labels Apr 20, 2023
@isaacmbrown
Copy link
Contributor

Hi @trusktr, I just tested and it doesn't look like this action sends an email notification.

To me it feels strange to need to specify when an action won't send an email. I also think, if we were going down that route, we would need to update more places than this one specific example.

Some actions do send the target user an email, and we should document this so that people targeting actions on other users know what to expect.

If you feel strongly about this, can I recommend creating an issue so we can discuss and work from there? I'm going to close this PR, since this specific change isn't one we'll publish.

atifnimran

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team organizations Content related to organizations waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants