Skip to content

Clarified information about codeowners and forks.#25050

Merged
cmwilson21 merged 10 commits intogithub:mainfrom
OlayinkaAtobiloye:codeowners
Aug 9, 2023
Merged

Clarified information about codeowners and forks.#25050
cmwilson21 merged 10 commits intogithub:mainfrom
OlayinkaAtobiloye:codeowners

Conversation

@OlayinkaAtobiloye
Copy link
Contributor

@OlayinkaAtobiloye OlayinkaAtobiloye commented Apr 17, 2023

Why:

Closes: #18353

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 17, 2023
@OlayinkaAtobiloye
Copy link
Contributor Author

OlayinkaAtobiloye commented Apr 17, 2023

Hi, @cmwilson21! I created a PR for a codeowner issue. Please check it out when chanced.✨

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
 fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

cmwilson21 commented Apr 18, 2023

@OlayinkaAtobiloye Thank you! 💖

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code owners Content related to code owners and removed triage Do not begin working on this issue until triaged by the team labels Apr 18, 2023
isaacmbrown
isaacmbrown reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@isaacmbrown isaacmbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlayinkaAtobiloye, thank you for creating this PR, this looks like great information to add! ✨

I left some comments with suggestions that came to my mind and tried to explain my thinking 🙂 Let me know if you have any questions!

@OlayinkaAtobiloye @isaacmbrown
Update content/repositories/managing-your-repositorys-settings-and-fe…
5498f5c 
…atures/customizing-your-repository/about-code-owners.md

Co-authored-by: Isaac Brown <101839405+isaacmbrown@users.noreply.github.com>
@Tylorj1931992

This comment was marked as spam.

Sign in to view
@isaacmbrown
Update content/repositories/managing-your-repositorys-settings-and-fe…
8031191 
…atures/customizing-your-repository/about-code-owners.md
@isaacmbrown
Update content/repositories/managing-your-repositorys-settings-and-fe…
282670b 
…atures/customizing-your-repository/about-code-owners.md
@isaacmbrown
Update content/repositories/managing-your-repositorys-settings-and-fe…
1857b29 
…atures/customizing-your-repository/about-code-owners.md
@isaacmbrown
Update content/repositories/managing-your-repositorys-settings-and-fe…
5b88f15 
…atures/customizing-your-repository/about-code-owners.md
@isaacmbrown
Update content/repositories/managing-your-repositorys-settings-and-fe…
8460918 
…atures/customizing-your-repository/about-code-owners.md
@isaacmbrown isaacmbrown added Merge-after-freeze ready to merge This pull request is ready to merge labels Aug 8, 2023
@isaacmbrown
Copy link
Contributor

isaacmbrown commented Aug 8, 2023

@cmwilson21 I've applied some suggestions and added the Ready to merge label for when the docs repos unfreeze 🙂

@cmwilson21 cmwilson21 enabled auto-merge August 9, 2023 13:02
@cmwilson21 cmwilson21 added this pull request to the merge queue Aug 9, 2023
Merged via the queue into github:main with commit 496bc13 Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacmbrown isaacmbrown isaacmbrown left review comments

+3 more reviewers

@jsoref jsoref jsoref left review comments

@atifnimran atifnimran atifnimran left review comments

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code owners Content related to code owners content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CODEOWNERS doesn't talk about forks

6 participants

@OlayinkaAtobiloye @cmwilson21 @Tylorj1931992 @isaacmbrown @jsoref @atifnimran