docs(actions): fix incorrect statement regarding permissions & secrets#25118
Conversation
Read-only permissions and no access to secrets only applies to pull requests from forks.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
@Simon-TechForm Thank you for opening a PR and linking it to your issue! ✨ I'll get this triaged for review! ⚡ |
|
@cmwilson21 I just stumbled upon the wording again, and still find it very unfortunate that a security hardening guide provides this false sense of security. Any news on this PR? :) |
This comment was marked as spam.
This comment was marked as spam.
|
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Read-only permissions and no access to secrets only applies to pull requests from forks.
Closes: #25117
What's being changed (if available, include any code snippets, screenshots, or gifs):
The sentence regarding what permissions the workflow will have when triggered by the
pull_requestevent.Check off the following: