Skip to content

fix: Clarify that the example to list and delete caches on PR closure has a limit#26252

Merged
SiaraMist merged 6 commits intogithub:mainfrom
erezrokah:patch-1
Jul 14, 2023
Merged

fix: Clarify that the example to list and delete caches on PR closure has a limit#26252
SiaraMist merged 6 commits intogithub:mainfrom
erezrokah:patch-1

Conversation

@erezrokah
Copy link
Copy Markdown
Contributor

@erezrokah erezrokah commented Jun 26, 2023

Why:

Closes #26251

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added a clarification that the example deletes caches up to a limit, and not all caches. Also set the limit to the maximum value supported

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome bot commented Jun 26, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 26, 2023
Comment thread content/actions/using-workflows/caching-dependencies-to-speed-up-workflows.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/caching-dependencies-to-speed-up-workflows.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

@erezrokah Thanks so much for opening a PR and linking it to your issue! And welcome to the community 🎉

I'll get this triaged for review ⚡

In the meantime, if you are looking for other ways to contribute, check out our help wanted section. 💖

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 27, 2023
Comment thread content/actions/using-workflows/caching-dependencies-to-speed-up-workflows.md Outdated
Copy link
Copy Markdown
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erezrokah! :) I'm @CBID2, nice to meet you! 😄 Aside from my suggestion and question, you're off to a good start with this revision! 😄 👍🏾

…up-workflows.md

Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@erezrokah erezrokah requested a review from CBID2 July 12, 2023 15:36
Copy link
Copy Markdown
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@erezrokah
Copy link
Copy Markdown
Contributor Author

Looks good to me

Thanks for the review @CBID2 🚀 What are the next steps? I can see that the checks still say "Review required"

Copy link
Copy Markdown
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for making this fix @erezrokah! I'll go ahead and get this merged.

@SiaraMist SiaraMist enabled auto-merge July 14, 2023 21:38
@SiaraMist SiaraMist added this pull request to the merge queue Jul 14, 2023
Merged via the queue into github:main with commit 2267cc1 Jul 14, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@erezrokah erezrokah deleted the patch-1 branch July 15, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(actions-cache-docs): Example workflow to delete all caches on PR closure does not delete all caches on PRs with many caches

5 participants