Skip to content

Conversation

@albbus-stack
Copy link
Contributor

@albbus-stack albbus-stack commented Oct 3, 2023

Why:

Makes a clearer explanation of a negated expression inside an if statement.

Closes: #28308

What's being changed (if available, include any code snippets, screenshots, or gifs):

All the changes are as requested by @hubwriter in this comment.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Oct 3, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/learn-github-actions/expressions.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@albbus-stack Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 3, 2023
@albbus-stack
Copy link
Contributor Author

albbus-stack commented Oct 3, 2023

@albbus-stack Thanks so much for submitting a PR! I'll get this triaged for review ⚡

The code block in data/reusables/actions/expression-syntax-if.md fails the content-linter action with:

Error name:    "ParseError"
Error message: "unexpected token at \"! startsWith(...\", line:6, col:6"

Both /actions/using-workflows/workflow-syntax-for-github-actions and /actions/creating-actions/metadata-syntax-for-github-actions break in the preview because they have that reusable.

Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for picking up this issue and making these changes, @albbus-stack! I made a couple of edits just to formatting that got all of the tests passing, so I'll go ahead and get this merged. Thank you again for contributing to the docs! 🚀

@SiaraMist SiaraMist enabled auto-merge October 3, 2023 20:09
@SiaraMist SiaraMist added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge labels Oct 3, 2023
@SiaraMist SiaraMist added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@SiaraMist SiaraMist added this pull request to the merge queue Oct 4, 2023
Merged via the queue into github:main with commit a4dff61 Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify how to use a negated expression in an if statement

3 participants