Change Maven hostname to maven.pkg.github.com#653
Merged
lucascosti merged 6 commits intomainfrom Nov 4, 2020
Merged
Conversation
Make it consistent with other ecosystems.
Contributor
|
👋 Thanks for opening a PR @jcansdale! Would you mind resolving the conflicts? I'll get this triaged for review ⚡ |
janiceilene
added
content
Contributor
Author
|
@janiceilene done. 😄 I don't know why that was conflicted! |
Contributor
|
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
github-actions
Bot
added
the
stale
jcansdale
removed
the
stale
lucascosti
approved these changes
Nov 4, 2020
Contributor
lucascosti
left a comment
lucascosti
left a comment
There was a problem hiding this comment.
Thanks a lot for these fixes, @jcansdale. I'll get them merged in 🚀
Comment on lines
-106
to
-107
| | Java | Apache Maven project management and comprehension tool | `pom.xml` | `mvn` | `maven.HOSTNAME/OWNER/REPOSITORY/IMAGE-NAME` | ||
| | Java | Gradle build automation tool for Java | `build.gradle` or `build.gradle.kts` | `gradle` | `maven.HOSTNAME/OWNER/REPOSITORY/IMAGE-NAME` |
Contributor
There was a problem hiding this comment.
😬 eeep, looks like this probably crept in from the GHES versioning...
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* update * fix 404s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Make Maven hostname consistent with other ecosystems (
maven.pkg.github.com).As suggested here https://github.zendesk.com/agent/tickets/851339
What's being changed:
maven.pkg.github.com.rubygem.pkg.github.comtorubygems.pkg.github.com.tonuget.pkg.github.com`.Check off the following: