Skip to content

Conversation

@RDxR10
Copy link
Contributor

@RDxR10 RDxR10 commented May 26, 2021

An alternative to establishing a connection to the ssh-auth agent.

Why:

Added an alternate command here(this PR would solve part of this issue) [https://github.com//issues/6642]

What's being changed:

exec ssh-agent bash

Check off the following:

  • I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

An alternative to establishing a connection to the ssh-auth agent.
@welcome
Copy link

welcome bot commented May 26, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 26, 2021
@ghost
Copy link

ghost commented May 26, 2021

The ssh-agent man page adequately addresses ways to get an agent set up.

I am opposed to the merging of this pull request.

@ghost ghost mentioned this pull request May 26, 2021
@janiceilene
Copy link
Contributor

@RDxR10 Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added ssh Content related to SSH waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 27, 2021
@RDxR10
Copy link
Contributor Author

RDxR10 commented Jun 2, 2021

Let me know if it needs any further clarification.

@lecoursen
Copy link
Member

Thanks for taking the time, @RDxR10, but our docs are purposefully opinionated. We document one way to accomplish a task and only mention alternatives if there's a compelling reason to do so. I'm going to close this PR, but let me know if there's further explanation for why this alternative is important to document.

@lecoursen lecoursen closed this Jun 3, 2021
@RDxR10
Copy link
Contributor Author

RDxR10 commented Jun 4, 2021

@lecoursen the reason is that depending on the os or Linux environment, the command may vary.
More detailed info here: https://stackoverflow.com/questions/17846529/could-not-open-a-connection-to-your-authentication-agent.
Variant: https://stackoverflow.com/a/20403535/456814

@lecoursen
Copy link
Member

the reason is that depending on the os or Linux environment, the command may vary.

Thanks for clarifying! From those links, it seems that there are more than two possibilities. We can't list them all, so we should instead clarify in {% data reusables.command_line.start_ssh_agent %} that the command we're listing is only an example and that you may need a different command depending your environment. Feel free to reopen this PR if you want to update it accordingly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ssh Content related to SSH waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants