Skip to content

Conversation

@RDxR10
Copy link
Contributor

@RDxR10 RDxR10 commented Jun 4, 2021

#6782

Why:

Minor changes were made.
Closes [https://github.com//issues/6642]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 4, 2021
Abhishek5772705
Abhishek5772705 previously approved these changes Jun 4, 2021
Copy link

@Abhishek5772705 Abhishek5772705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janiceilene
Copy link
Contributor

@RDxR10 Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added ssh Content related to SSH waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 8, 2021
lecoursen
lecoursen previously approved these changes Jun 8, 2021
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉 I pushed some changes to the branch that moved the new to the start_ssh_agent reusable, so it will be included ever ytime we ask folks to start the ssh agent instead of this article only. I also made the phrasing more general, to clarify that these are only a few examples of the commands you might need to use. I'll merge now. ⚡

@lecoursen lecoursen merged commit ac50aa4 into github:main Jun 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ssh Content related to SSH waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants