Skip to content

Add Codespaces capability to contribute to the site#691

Merged
janiceilene merged 7 commits intogithub:mainfrom
ojacques:codespaces
Nov 9, 2020
Merged

Add Codespaces capability to contribute to the site#691
janiceilene merged 7 commits intogithub:mainfrom
ojacques:codespaces

Conversation

@ojacques
Copy link
Copy Markdown
Contributor

Why:

This PR adds the capability to contribute to GitHub docs using GitHub codespaces.

Two clicks, and you are off contributing with a fully configured environment directly from the comfort of your browser!

codespaces

Gets you to:

codespaces-with-preview

Note: this capability is only visible if your GitHub account has access to GitHub codespaces (which is, at the time of writing, in beta).

What's being changed:

The change impacts CONTRIBUTING.md and development/development.md. It does not impact the actual documentation.

The intent is to offer a very simple way to contribute to the documentation, without having to install anything on your MAC/PC.

Check off the following:

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks so much for this @ojacques ✨ I'll get this triaged for review!

@janiceilene janiceilene added contributing docs Content related to our contributing docs engineering Will involve Docs Engineering labels Oct 23, 2020
@chiedo chiedo removed the engineering Will involve Docs Engineering label Oct 26, 2020
@chiedo
Copy link
Copy Markdown
Contributor

chiedo commented Oct 26, 2020

This looks good to me! @janiceilene, @simpsoka, if the two of you approve this PR from a Product perspective, I'll get it merged.

@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Nov 4, 2020
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
@simpsoka
Copy link
Copy Markdown

simpsoka commented Nov 4, 2020

Thanks for opening this @ojacques! Added some quick suggestions to the contributing guide for you. 💖

@ojacques
Copy link
Copy Markdown
Contributor Author

ojacques commented Nov 5, 2020

@simpsoka, took your comments into account. This is ready for your review.

@github-actions github-actions Bot removed the stale There is no recent activity on this issue or pull request label Nov 5, 2020
Comment thread contributing/development.md Outdated

In a matter of minutes, you will be ready to edit, preview and test your changes directly from the comfort of your browser.

![](../assets/images/codespaces-with-preview.jpg)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last one @ojacques, would you mind removing the image from here too, to keep things consistent? Once that's done, I'll get this merged! Thank you so much for helping our Codespaces users get set up 🚀

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janiceilene - done. It became a really small PR eventually 😄. Simple is beautiful.

Copy link
Copy Markdown
Contributor

@janiceilene janiceilene Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for iterating with us @ojacques!

@janiceilene
Copy link
Copy Markdown
Contributor

There was one conflict with some updates made in https://github.com/github/docs/pull/984/files, so I resolved that and I'll get this merged once tests are passing 🍏 Thanks again @ojacques 🎉

@janiceilene janiceilene merged commit 5acc239 into github:main Nov 9, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
The example is about, creating 
multi-dimensional distributed hypertable across all data nodes, partitioned
along `time` and `location`. 

Fixes:timescale/docs#688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributing docs Content related to our contributing docs hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants