chore: Escape single quotes in metadata #913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to be parsing the current version, but trips up spell checking and syntax highlighting
nschonni
force-pushed
the
escape-quote-in-metadata
branch
from
ef5cc86 to
b779566
Compare
Contributor
Author
|
Learned something new https://yaml.org/spec/current.html#c-quoted-quote |
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* update hierarchy for getting started revamp (github#823) * update hierarchy * changes for getting started launch doc pages (github#855) * update hierarchy * updates to first file * update launching doc pages * Apply suggestions from code review update text from suggestions Co-authored-by: Attila Tóth <hello@attilatoth.dev> * Update timescaledb/getting-started/launch-timescaledb/launch-timescaledb-docker.md Co-authored-by: Attila Tóth <hello@attilatoth.dev> * Edit new getting started launch content * some final little adjustments to clarify things Co-authored-by: Attila Tóth <hello@attilatoth.dev> Co-authored-by: Charis Lam <26616127+charislam@users.noreply.github.com> * Miranda/access database updates (github#867) * update first two files * add other page * Copy and style edit * some small adjustments Co-authored-by: Charis Lam <26616127+charislam@users.noreply.github.com> * Miranda/add data (github#917) * some edits * adding the data updates * small change * Apply suggestions from code review ryan's suggestions Co-authored-by: Ryan Booz <ryan@timescale.com> * some updates * Update timescaledb/getting-started/add-data.md * more changes * Apply suggestions from code review add updates Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Apply suggestions from code review more edits * update some line lengths * Update timescaledb/getting-started/add-data.md updates Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Miranda/create hypertable (github#913) * some updates * updates to the hypertable chunks page. * remove section and change around a few things * Apply suggestions from code review updates Co-authored-by: Ryan Booz <ryan@timescale.com> * Apply suggestions from code review changes Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review more edits * Update timescaledb/getting-started/create-hypertable.md edits * fix line lengths Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * miranda/query-your-data updates to the getting started guide (github#936) * add changes * updates * Apply suggestions from code review add changes Co-authored-by: Lana Brindley <github@lanabrindley.com> * Apply suggestions from code review updates Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Apply suggestions from code review final edits * Update timescaledb/getting-started/query-data.md more stuff * Update timescaledb/getting-started/query-data.md last one * Update timescaledb/getting-started/query-data.md little fix * Apply suggestions from code review two more little changes Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Miranda/continuous agg getting started (github#950) * changes * first pass of the continuous aggregates * fix link issue * Apply suggestions from code review updates Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * Apply suggestions from code review more changes Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * some more updates * updates Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * retention updates (github#958) * retention updates * Apply suggestions from code review some updates Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com> * last changes Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com> * Miranda/compression-getting-started-update (github#962) * more updates * Apply suggestions from code review updates Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> * updates to include extra docker step (github#978) * updates to include extra docker step * Apply suggestions from code review updates Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> * Apply suggestions from code review test bullet * Update timescaledb/getting-started/add-data.md test bullet again * updates I made Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> * Final changes for getting started guide (github#996) * had to make a change * remove install and connecting pages * last edits * Apply suggestions from code review Add suggested changes Co-authored-by: Ryan Booz <ryan@timescale.com> * more final edits * found small issue * small update * Apply suggestions from code review fix weird table * get rid of paragraph symbols in table * Update timescaledb/getting-started/add-data.md Adding the correct link for the data file. * Update page-index.js Not sure how I've missed this outline previously, but we want people to save space with compression on raw data before we drop old data. This probably came from earlier discussions that a lot of stock/crypto folks seem to want to drop raw data ASAP, so totally understandable. With this order (and assuming data we provide is ~1 month of data), users get raw data in -> continuous aggregates for rollup and faster query -> compress data that's older than 2 weeks -> drop raw data that's older than 3. This feels like a better overall flow. * Update timescaledb/getting-started/add-data.md * Update timescaledb/getting-started/create-cagg/create-cagg-basics.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update timescaledb/getting-started/compress-data.md * Update timescaledb/getting-started/compress-data.md * Update timescaledb/getting-started/query-data.md * Update timescaledb/getting-started/add-data.md * Update timescaledb/getting-started/query-data.md * Update timescaledb/getting-started/query-data.md * fixed the steps in the procedure * Fix indentation * Apply suggestions from code review Still more suggestions to review, but need to move on for a bit. Will finish review in a couple of hours. Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com> * Apply suggestions from code review A few more suggestions to review and think about. Should finish in the morning. Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com> Co-authored-by: Attila Tóth <hello@attilatoth.dev> Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> * Edits for wording, flow, and adding basic procedure sections for alignment with other docs. * Minor fixes to the query page * Apply suggestions from code review Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Attila Tóth <hello@attilatoth.dev> Co-authored-by: Charis Lam <26616127+charislam@users.noreply.github.com> Co-authored-by: Jacob Prall <prall.jacob@gmail.com> Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
What's being changed:
Check off the following: