Make linter not count punctuation against match #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.
|
lindseywild
approved these changes
Jun 30, 2022
Contributor
lindseywild
left a comment
lindseywild
left a comment
There was a problem hiding this comment.
If someone actually puts Click here!!! as a link, can we make their computer explode, too? 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a PR in dotcom with the text,
Learn more.which this linter didn't catch because it only looks for case-insensitive exact string match.This PR updates the linter to ignore punctuations and multiple whitespaces so we flag:
Learn more.Click here!!!