Skip to content

Make linter not count punctuation against match #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Make linter not count punctuation against match #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a38958
Make linter not count punctuation against match
khiga8 Jun 30, 2022
b0cadce
Run rubocop
khiga8 Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/erblint-github/linters/github/accessibility/avoid_generic_link_text_counter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def autocorrect(processed_source, offense)
private

def banned_text?(text)
BANNED_GENERIC_TEXT.map(&:downcase).include?(text.downcase)
BANNED_GENERIC_TEXT.map(&:downcase).include?(text.downcase.gsub(/\W+/, " ").strip)
end

def valid_accessible_name?(aria_label, text)
Expand Down
13 changes: 13 additions & 0 deletions test/linters/accessibility/avoid_generic_link_text_counter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,19 @@ def test_warns_when_link_text_is_link
refute_empty @linter.offenses
end

def test_warns_when_link_text_is_banned_text_with_punctuation_and_space
@file = <<~ERB
<a>Learn more!</a>
<a> read more.</a>
<a>click here.</a>
ERB
@linter.run(processed_source)

refute_empty @linter.offenses
# 3 offenses, 1 related to matching counter comment not present despite violations
assert_equal 4, @linter.offenses.count
end

def test_does_not_warn_when_banned_text_is_part_of_more_text
@file = "<a>Learn more about GitHub Stars</a>"
@linter.run(processed_source)
Expand Down