Skip to content

Conversation

@shaedrich
Copy link
Contributor

@shaedrich shaedrich commented Jan 11, 2025

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Almost 2K repositories are using this tag.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@shaedrich shaedrich requested a review from a team as a code owner January 11, 2025 02:02
@shaedrich
Copy link
Contributor Author

Btw, is there a reason while only the JSON definitions are a public repository? I mean, the rendering and/or the API sure could also benefit from contributions.

@ahpook
Copy link
Contributor

ahpook commented Jan 15, 2025

Btw, is there a reason while only the JSON definitions are a public repository? I mean, the rendering and/or the API sure could also benefit from contributions.

Hi @shaedrich ! The site build code is unfortunately entwined with our internal management portal, which is itself part of github/github :(

@shaedrich
Copy link
Contributor Author

shaedrich commented Jan 15, 2025

Btw, is there a reason while only the JSON definitions are a public repository? I mean, the rendering and/or the API sure could also benefit from contributions.

Hi @shaedrich ! The site build code is unfortunately entwined with our internal management portal, which is itself part of github/github :(

Hi, @ahpook, thanks for the explanation! Would be cool if that could be untangled some day. If that should ever happen, I'd happily know about it and provide PRs :)

@tomthorogood tomthorogood added this pull request to the merge queue Jan 16, 2025
Merged via the queue into github:main with commit 8ae429b Jan 16, 2025
5 checks passed
@shaedrich shaedrich deleted the patch-1 branch January 16, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants