Skip to content

Conversation

@imrofayel
Copy link
Contributor

@imrofayel imrofayel commented Mar 20, 2025

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Signed-off-by: Adam Rofayel <adamrofayel@gmail.com>
Signed-off-by: Adam Rofayel <adamrofayel@gmail.com>
@imrofayel imrofayel requested a review from a team as a code owner March 20, 2025 03:59
@ahpook
Copy link
Contributor

ahpook commented Mar 27, 2025

There is already https://github.com/collections/dil-dil-pakistan

@ahpook ahpook closed this Mar 27, 2025
@imrofayel
Copy link
Contributor Author

It should be labeled as 'Made in Pakistan' like all others, so it's easy to find. I couldn't even find it; there's no search on the collections page. And for those not from Pakistan, 'Dil Dil Pakistan' is not a good name to represent Open Source contributions of Pakistan. It literally means 'Pakistan is my heart', which should not be the title of such a collection.

@ahpook
Copy link
Contributor

ahpook commented Mar 31, 2025

@imrofayel that is a very valid point. i'll merge this one and add the items from the other one to it.

@ahpook ahpook reopened this Mar 31, 2025
@ahpook ahpook merged commit b5797a9 into github:main Mar 31, 2025
7 of 10 checks passed
ahpook added a commit that referenced this pull request Mar 31, 2025
This should be consistent with the other country-based collections

Relates to #4674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants