Skip to content

Fix lint workflow to checkout PR branch instead of base branch #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahpook merged 2 commits into from
Mar 20, 2026
Merged

Fix lint workflow to checkout PR branch instead of base branch #5084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
188bdef
Initial plan
Copilot Mar 20, 2026
31742ae
fix: checkout PR branch in lint workflow instead of base branch
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6.0.1
with:
ref: ${{ github.event.pull_request.head.ref || github.ref }}
Comment on lines 16 to +18
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking out the PR head branch under pull_request_target while the workflow has contents: write and runs Bundler/RuboCop means untrusted PR code can execute with a write-capable GITHUB_TOKEN (repo-compromise risk). It will also fail for fork PRs because head.ref refers to a branch in the fork, but actions/checkout defaults to the base repo unless repository: is set.

Consider gating this job/step to same-repo PRs only (e.g., if: github.event.pull_request.head.repo.full_name == github.repository) and using a separate read-only lint workflow for forks; or otherwise avoid pull_request_target + write permissions when running PR code.

Copilot uses AI. Check for mistakes.

- name: Setup Ruby
uses: ruby/setup-ruby@v1.284.0
Expand Down
Loading