Fix comma delimiters in topic aliases/related fields#5100
Merged
Conversation
Add space after commas in aliases and related fields across 14 topic index.md files so the Liquid split on ', ' produces individual entries instead of a single concatenated string. Also remove software-testing from testing topic aliases — it conflicts with an existing alias in the production database. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Make the Liquid template tolerant of both 'a, b' and 'a,b' formats by splitting on bare comma and stripping whitespace from each element. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts topic front matter formatting so aliases/related values split correctly in feed.json.liquid (which uses split: ', ') and removes an alias that conflicts with an existing production alias, preventing persistent diffs/noisy importer output.
Changes:
- Normalized
aliases:/related:comma delimiters to,in 14 topicindex.mdfiles. - Removed
software-testingfromtopics/testingaliases to avoid alias collision in the topic importer.
Reviewed changes
Copilot reviewed 1 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| topics/testing/index.md | Removes a conflicting alias from aliases:. |
| topics/southpaw-engine/index.md | Normalizes aliases: delimiter to comma+space. |
| topics/source-engine/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/source-2-engine/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/serious-engine/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/randomizer/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/machinima/index.md | Normalizes related: delimiter to comma+space. |
| topics/irc/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/io/index.md | Normalizes aliases: delimiter to comma+space. |
| topics/hammer/index.md | Normalizes aliases: delimiter to comma+space. |
| topics/data-recovery/index.md | Normalizes aliases: delimiter to comma+space. |
| topics/corruptor/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/build-engine/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/autohotkey/index.md | Normalizes aliases: and related: delimiters to comma+space. |
| topics/apollo-server/index.md | Normalizes related: delimiter to comma+space. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
4
| --- | ||
| display_name: Data Recovery | ||
| aliases: data-carving,digital-forensic,recovery-tool,photo-recovery | ||
| aliases: data-carving, digital-forensic, recovery-tool, photo-recovery | ||
| short_description: Data recovery is a method of recovering using software to undone file deletion or corruption. |
There was a problem hiding this comment.
This file is using CRLF line endings (visible as \r at the end of lines). Since this PR already touches the front matter, please consider normalizing the file to LF line endings to match the rest of the repo and avoid noisy diffs / tooling inconsistencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feed.json.liquid template splits aliases and related fields on
,(comma + space). 14 topics used,(comma without space), so the Liquid split produced a single-element array like["graphql,api,graphql-server"]instead of individual entries. This caused the github/github topic importer to always detect a diff on every dry run, even after a successful import.Also removes
software-testingfrom thetestingtopic aliases — it conflicts with an existing alias in the production database, causing the importer to log "Name is already an alias for another topic".Changes
aliases:andrelated:fieldstopics/testing/index.md: removesoftware-testingfrom aliases