feat: add smoke tests for sink visibility (private-to-public-flows)#6148
Merged
Conversation
Add two workflow .md files to smoke-test the MCP Gateway private-to-public-flows frontmatter from gh-aw#45113: - smoke-sink-visibility-blocked.md: Verifies that the default sink-visibility enforcement blocks reads from private repo github/agentic-workflows when private-to-public-flows is not set. - smoke-sink-visibility-allowed.md: Verifies that private-to-public-flows: allow correctly disables enforcement, permitting reads from the private repo. Both workflows test gh CLI (mcpg proxy mode) and GitHub MCP tools (mcpg gateway mode) with GH_AW_CROSS_REPO_PAT for authentication. All access is read-only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds smoke workflows for MCP Gateway private-to-public repository visibility controls.
Changes:
- Tests default blocking for private-repository reads.
- Tests the
private-to-public-flows: allowopt-out. - Covers both GitHub CLI proxy mode and MCP gateway mode.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/smoke-sink-visibility-blocked.md |
Adds default-enforcement smoke coverage. |
.github/workflows/smoke-sink-visibility-allowed.md |
Adds opt-out smoke coverage. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Medium
| enabled: false | ||
| sandbox: | ||
| mcp: | ||
| version: v0.3.32 |
| enabled: false | ||
| sandbox: | ||
| mcp: | ||
| version: v0.3.32 |
Collaborator
Author
|
@copilot address the review feedback but remove the mcp gateway version. rely on the compiler default |
Contributor
Removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two smoke test workflow
.mdfiles to validate the MCP Gatewayprivate-to-public-flowsfrontmatter implemented in github/gh-aw#45113.Workflows
smoke-sink-visibility-blocked.mdTests that default sink-visibility enforcement blocks reads from private repo
github/agentic-workflowswhenprivate-to-public-flowsis NOT set. Both access methods should be denied:gh repo view github/agentic-workflowsget_file_contentssmoke-sink-visibility-allowed.mdTests that
private-to-public-flows: allowcorrectly disables enforcement, permitting reads from the private repo. Both access methods should succeed:Details
GH_AW_CROSS_REPO_PATfor authentication viatools.github.github-tokengithub/agentic-workflowsis read-only.mdfiles — compilation deferred to a follow-up stepstrict: falsesinceprivate-to-public-flows: allowis incompatible with strict modeRelated
private-to-public-flows: allowas atools.githubfrontmatter field gh-aw#45113 —private-to-public-flowsfrontmatter implementation