Set runtime to docker-sbx in smoke-docker-sbx workflow frontmatter by lpcox · Pull Request #6153 · github/gh-aw-firewall

lpcox · 2026-07-12T21:05:47Z

Summary

Adds sandbox.agent block with runtime: docker-sbx to all four smoke-docker-sbx workflow .md files:

smoke-docker-sbx.md
smoke-docker-sbx-build-test.md
smoke-docker-sbx-claude.md
smoke-docker-sbx-codex.md

This matches the pattern used by the gvisor smoke tests (which set runtime: gvisor). Previously these workflows had no sandbox.agent section, so the runtime was never explicitly set.

Note: Lock files are not recompiled in this PR.

Add sandbox.agent block with runtime: docker-sbx to all four smoke-docker-sbx workflow .md files, matching the pattern used by the gvisor smoke tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds explicit Docker sbx runtime configuration to four smoke workflow sources.

Changes:

Adds sandbox.agent using AWF and docker-sbx.
Enables sudo for each sandbox agent.
Generated lock workflows remain stale.

Show a summary per file

File	Description
`smoke-docker-sbx.md`	Configures Docker sbx runtime.
`smoke-docker-sbx-build-test.md`	Configures runtime for build tests.
`smoke-docker-sbx-claude.md`	Configures runtime for Claude tests.
`smoke-docker-sbx-codex.md`	Configures runtime for Codex tests.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 7/7 changed files
Comments generated: 4
Review effort level: Medium

 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx


 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx


 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx


 sandbox:
+  agent:
+    id: awf
+    runtime: docker-sbx


github-actions · 2026-07-12T21:09:44Z

✅ Copilot review passed with no inline comments.

@lpcox Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-07-12T21:12:05Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.92%	98.95%	📈 +0.03%
Statements	98.88%	98.91%	📈 +0.03%
Functions	99.34%	99.34%	➡️ +0.00%
Branches	95.11%	95.11%	➡️ +0.00%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/log-directory-setup.ts`	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

execa throws 'Cannot read properties of null (reading end)' when input is provided but stdio[0] is 'ignore'. Change stdin to 'pipe' so the confirmation input can be written to the sbx create process. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Replace the released binary install step with a source build so the stdin pipe fix in sbx-manager.ts is exercised in CI. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Removing XDG_CONFIG_HOME from the environment passed to sbx create prevents the sbx CLI from finding Docker Hub credentials stored by sbx login, causing 'user is not authenticated' errors even though the daemon pre-pulled the image successfully. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…t/gh-aw-firewall into set-docker-sbx-runtime

The released AWF binary (v0.27.30) has a bug where execa crashes with 'Cannot read properties of null (reading end)' because stdio[0] is set to 'ignore' while input is provided. Build from source to include the fix (stdio[0] changed to 'pipe'). This is a temporary workaround until a new AWF version is released. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

The compiled dist references ../containers/api-proxy/provider-env-constants.json relative to the dist/ directory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Passing a custom sanitized env to execa replaces the entire process environment, which strips variables the sbx CLI needs to locate its daemon socket and credential store. This causes 'user is not authenticated to Docker' errors even when sbx login was run moments before. Instead, temporarily set DOCKER_SANDBOXES_PROXY in process.env and restore it after the call, letting sbx inherit the full environment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Revert to the original behavior from PR #6101: delete DOCKER_SANDBOXES_PROXY from the env during sbx create. Setting it forces the sbx daemon to route Docker Hub registry auth through Squid, which blocks the pull and causes 'user is not authenticated to Docker' errors. The proxy is set at exec time instead, which is after Squid is fully configured and ready. Also reverts the process.env change (security issue: would have leaked secrets like GITHUB_TOKEN, DOCKER_PAT etc to the sbx CLI). The sanitized env approach (sanitizeEnvForSbx) is the correct security boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

sbx create is a management command that talks to the local daemon — it does not run user code inside the sandbox. Passing a custom sanitized env strips variables the sbx CLI needs to locate the daemon's credential store, causing 'user is not authenticated to Docker' errors. The sandbox interior's env is controlled separately by execInSandbox() which still uses sanitizeEnvForSbx() to strip secrets. DOCKER_SANDBOXES_PROXY is temporarily removed during create to prevent routing Docker Hub registry auth through Squid (which isn't ready yet). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

The Copilot harness sets XDG_CONFIG_HOME=$HOME before running AWF. This makes the sbx CLI look for credentials in $HOME/ instead of the default $HOME/.config/ where 'sbx login' stored them (sbx login runs in a step before the harness, with XDG_CONFIG_HOME unset). Temporarily unset XDG_CONFIG_HOME during sbx create so the sbx CLI finds the daemon credentials at the correct default path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Add source build + credential refresh step to match the other lock files. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-07-13T00:41:08Z

✅ Smoke Gemini completed. All facets verified. 💎

github-actions · 2026-07-13T00:41:09Z

✅ Build Test Suite completed successfully!

github-actions · 2026-07-13T00:41:13Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-07-13T00:41:22Z

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-13T00:45:36Z

Thanks for the focused runtime configuration change. One contribution-guideline item needs clarification: the PR description says lock files are not recompiled, but the diff includes changes to the generated .lock.yml files (metadata, secrets, action references, and runtime-related steps). Under CONTRIBUTING.md, please update the description to accurately describe these generated changes and confirm they are intentional, or remove unintended generated output. Also, per the PR requirements to include tests for new functionality, please add or link to the relevant workflow validation (or explain why the frontmatter-only change does not require an additional test).

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Contribution Check for #6153 · 5.89 AIC · ⊞ 19.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:45:41Z

Smoke Test: Copilot BYOK Direct Mode

✅ GitHub.com Connectivity (HTTP 200)
✅ File Write/Read Test
✅ BYOK Inference Path (api-proxy → api.githubcopilot.com)
✅ MCP Connectivity

Status: PASS — Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:45:45Z

Smoke Test: Copilot PAT Auth — ⚠️ INCOMPLETE

Test	Result
MCP Connectivity	❌ MCP tools unavailable in sandbox
GitHub.com HTTP	❌ Template vars unresolved
File Write/Read	❌ Template vars unresolved

Overall: FAIL — workflow template variables were not substituted (pre-step outputs missing).
Auth mode: PAT (COPILOT_GITHUB_TOKEN)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 PAT report filed by Smoke Copilot PAT
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:46:00Z

Smoke Test Results

Test	Result
GitHub MCP	✅
github.com HTTP	✅ 200
File Write/Read	✅

Overall: PASS

Author: @lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:46:02Z

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
GH check	✅ PASS
File status	✅ PASS

Overall result: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Smoke Claude for #6153 · 55 AIC · ⊞ 3.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:46:35Z

✅ GitHub MCP connectivity
✅ GitHub.com connectivity
✅ File write/read test
✅ BYOK inference test

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

PASS
cc @lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:46:37Z

Smoke Test Results

Redis PING: ❌ Network unreachable
PostgreSQL pg_isready: ❌ No response
PostgreSQL SELECT 1: ❌ Network unreachable

Overall: FAIL — host.docker.internal (172.17.0.1) is not reachable. Service containers may not be running or the network route is unavailable.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:46:41Z

Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Notes
Module Loading	✅ Pass	`otel.js` loads; exports: `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`
Test Suite	✅ Pass	59 tests passed across `otel.test.js` + `otel-fanout.test.js` (2 suites, 0 failures)
Env Var Forwarding	✅ Pass	`api-proxy-env-config.test.ts` confirms forwarding of all 6 OTEL env vars
Token Tracker Integration	✅ Pass	`onUsage` callback present in `token-tracker-http.js` (lines 285/343)
OTEL Diagnostics	✅ Pass	Graceful degradation confirmed — falls back to file exporter when no endpoint configured

All 5 scenarios passed. OTEL tracing integration is functional.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:46:51Z

Recent merged PRs: compiled workflows; compiled workflows
✅ GitHub PR review
✅ GH CLI query
✅ Playwright title check
✅ File write/read
✅ Discussion comment
✅ npm ci && npm run build
Overall status: PASS

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

awmgmcpg
registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:46:53Z

Gemini Smoke Test Results

GitHub MCP Testing: ❌ (Tools not found)
GitHub.com Connectivity: ❌ (DNS SERVFAIL)
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:47:20Z

@lpcox Smoke Test Results:

GitHub MCP Testing: ✅
GitHub.com connectivity: ✅
File write/read: ✅
Direct BYOK inference: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:47:45Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	`Python 3.12.13`	`Python 3.12.3`	❌ NO
Node.js	`v24.18.0`	`v22.23.1`	❌ NO
Go	`go1.22.12`	`go1.22.12`	✅ YES

ALL_TESTS_PASSED: false — Python and Node.js versions differ between host and chroot environments.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:47:48Z

🔥 Smoke Test: Docker Sbx — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ (pre-step)
File write/read	✅ (pre-step)

Overall: PASS

PR by @lpcox — "Set runtime to docker-sbx in smoke-docker-sbx workflow frontmatter"

📰 BREAKING: Report filed by Smoke Docker Sbx
_{Add label ready-for-aw to run again}

github-actions · 2026-07-13T00:48:17Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note: Java Maven required a writable local repository path (-Dmaven.repo.local=/tmp/...) since the default ~/.m2/repository was owned by root.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Build Test Suite for #6153 · 29.2 AIC · ⊞ 6.9K · ◷
_{Add label ready-for-aw to run again}

Copilot AI review requested due to automatic review settings July 12, 2026 21:05

Copilot started reviewing on behalf of lpcox July 12, 2026 21:06 View session

lpcox and others added 2 commits July 12, 2026 14:06

Add sudo: true to sandbox.agent in smoke-docker-sbx workflows

7c2350e

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

compiled workflows

a93dacb

Copilot AI reviewed Jul 12, 2026

View reviewed changes

Merge branch 'main' into set-docker-sbx-runtime

335c310

github-actions Bot mentioned this pull request Jul 12, 2026

[aw] Smoke Docker Sbx has stale lock file #6156

Closed

This was referenced Jul 12, 2026

[aw] Smoke Docker Sbx Codex failed #6158

Closed

[aw] Smoke Docker Sbx Build Test failed #6159

Closed

[aw] Smoke Docker Sbx Claude failed #6160

Closed

lpcox and others added 17 commits July 12, 2026 14:26

Build AWF from source in smoke-docker-sbx-build-test to test sbx fix

84831fe

Replace the released binary install step with a source build so the stdin pipe fix in sbx-manager.ts is exercised in CI. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

compiled workflows

021c52f

Merge branch 'set-docker-sbx-runtime' of https://github.com/githubnex…

fba6408

…t/gh-aw-firewall into set-docker-sbx-runtime

compiled workflows

2b4fff1

fix: include containers/ dir in source build install

0500837

The compiled dist references ../containers/api-proxy/provider-env-constants.json relative to the dist/ directory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

chore: update smoke-docker-sbx.lock.yml to build AWF from source

7de0696

Add source build + credential refresh step to match the other lock files. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

compiled workflows

591be79

compiled workflows

fa3d909

compiled workflows

4842502

chore: build AWF from source in smoke-docker-sbx.lock.yml

4d2fb0f

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions Bot added the smoke-copilot-byok label Jul 13, 2026

github-actions Bot added the smoke-copilot label Jul 13, 2026

github-actions Bot added the smoke-claude label Jul 13, 2026

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jul 13, 2026

github-actions Bot added the smoke-codex label Jul 13, 2026

lpcox temporarily deployed to aoai-model July 13, 2026 00:47 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jul 13, 2026

lpcox temporarily deployed to aoai-model July 13, 2026 00:47 — with GitHub Actions Inactive

github-actions Bot added the smoke-docker-sbx label Jul 13, 2026

github-actions Bot added the build-test label Jul 13, 2026

lpcox merged commit 70f9027 into main Jul 13, 2026
140 of 141 checks passed

lpcox deleted the set-docker-sbx-runtime branch July 13, 2026 01:34

Uh oh!

Conversation

lpcox commented Jul 12, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 12, 2026

Uh oh!

github-actions Bot commented Jul 12, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Smoke Test: Copilot BYOK Direct Mode

Uh oh!

github-actions Bot commented Jul 13, 2026

Smoke Test: Copilot PAT Auth — ⚠️ INCOMPLETE

Uh oh!

github-actions Bot commented Jul 13, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented Jul 13, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented Jul 13, 2026

Smoke Test: API Proxy OpenTelemetry Tracing

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Gemini Smoke Test Results

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Jul 13, 2026

🔥 Smoke Test: Docker Sbx — PASS

Uh oh!

github-actions Bot commented Jul 13, 2026

🏗️ Build Test Suite Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading