docs: sync schemas and specs with source changes#6214
Conversation
- Add security.legacySecurity → --legacy-security CLI mapping - Add security.securityMode → --security-mode as deprecated - Mark apiProxy.enabled → --enable-api-proxy as deprecated Triggered by commit 18817f9 (feat: rename --security-mode to --legacy-security, deprecate --enable-api-proxy) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the AWF configuration specification for renamed and deprecated security options.
Changes:
- Documents
security.legacySecurity. - Marks legacy security mode and API proxy flags deprecated.
- Notes that the API proxy is always enabled.
Show a summary per file
| File | Description |
|---|---|
docs/awf-config-spec.md |
Updates config-to-CLI mappings and deprecation notes. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
| - `network.isolation` → `--network-isolation` *(experimental; enforces egress via Docker network topology instead of host iptables)* | ||
| - `network.topologyAttach[]` → `--topology-attach <name>` *(repeatable; requires `network.isolation: true`)* | ||
| - `apiProxy.enabled` → `--enable-api-proxy` | ||
| - `apiProxy.enabled` → `--enable-api-proxy` *([DEPRECATED] API proxy is always enabled; this flag is ignored)* |
|
@copilot address review feedback |
Done in commit
|
|
✅ Copilot review passed with no inline comments. @github-actions[bot] Add the |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅ |
|
✅ Contribution Check completed successfully! PR #6214 follows the applicable CONTRIBUTING.md guidelines: it is a documentation-only schema/spec sync, so no new functionality or tests are required; documentation and file placement are appropriate, and the PR description clearly explains the changes and references the source commit. |
|
🔌 Smoke Services — All services reachable! ✅ |
|
🚀 Security Guard has started processing this pull request |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed... |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Build Test Suite completed successfully! |
|
🦎🔮 Smoke gVisor Codex reports failed. gVisor + Codex compatibility issue detected. |
Smoke Test: Copilot BYOK (Direct)
Running in direct BYOK mode ( Overall: PASS 🟢 — Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: Claude Engine Validation
Overall result: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: PAT Auth Validation
Auth mode: PAT (COPILOT_GITHUB_TOKEN)
Overall: INCONCLUSIVE Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
🔬 Smoke Test Results
Overall: PARTIAL PASS (engine connectivity verified, pre-step data missing) PR Author: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: Services Connectivity
Result: FAIL — Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: API Proxy OpenTelemetry Tracing
All scenarios pass. OTEL tracing integration is correctly implemented. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Chroot Version Comparison
Not all runtimes match between host and chroot environment. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
🔬 Smoke Test: Docker Sbx — Results
Overall: PARTIAL — infrastructure reachable, pre-step data unavailable.
|
|
@copilot merge main |
Smoke Test: Gemini Engine Validation
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
|
🐳🔮 Docker sbx + Codex
|
🐳🏗️ Docker Sbx Build Test Results
Overall: FAIL
|
…-07-14-aedff7def8f81df4
|
🐳🟣 Docker sbx + Claude
Overall: FAIL
|
Done — merged |
|
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
|
Merged PRs: fix: exclude GITHUB_TOKEN from agent container when API proxy is enabled | fix: update CI workflow tests for new compiler action path format Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"
- "registry.npmjs.org"See Network Configuration for more information.
|
PR #6214 updated docs/awf-config.schema.json to mark apiProxy.enabled as deprecated and update environment descriptions, but did not apply the same changes to src/awf-config-schema.json, causing schema drift. This commit copies the docs schema to src to restore identical copies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Updates
docs/awf-config-spec.mdto reflect changes from commit 18817f9 (feat: rename --security-mode to --legacy-security, deprecate --enable-api-proxy).Changes
security.legacySecurity→--legacy-securityCLI mappingsecurity.securityMode→--security-modeas deprecated (backward compat)apiProxy.enabled→--enable-api-proxyas deprecated (API proxy is always enabled)Note:
docs/awf-config.schema.jsonwas already updated in the source commit itself.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.