[Test Coverage] fix: dns-preresolution test fails on runners with github.com in /etc/hosts by github-actions[bot] · Pull Request #6522 · github/gh-aw-firewall

github-actions · 2026-07-23T09:05:00Z

Problem

The agent-volumes-dns-preresolution.test.ts test was consistently failing on GitHub Actions runners because it used github.com and npmjs.org as test domains. These domains are injected into the runner's /etc/hosts file by GitHub.

The hosts-file.ts generator skips domains already present in /etc/hosts (to avoid duplicates), so the execa.sync mock for getent was never invoked for these domains. This caused the assertions on specific resolved IPs to fail:

expect(content).toContain('140.82.121.4\tgithub.com');  // FAIL — github.com skipped

Fix

Replace github.com / npmjs.org with synthetic .internal domain names (awf-test-alpha.internal, awf-test-beta.internal) that can never appear in a runner's /etc/hosts. This makes the test fully environment-independent.

Verification

PASS src/services/agent-volumes-dns-preresolution.test.ts
  agent service
    ✓ should pre-resolve allowed domains into chroot-hosts file (8 ms)
    ✓ should skip domains that fail to resolve during pre-resolution (1 ms)
    ✓ should not add duplicate entries for domains already in /etc/hosts (1 ms)

Generated by Test Coverage Improver · 58.6 AIC · ⊞ 6.3K · ◷

The test was using 'github.com' and 'npmjs.org' which are injected into /etc/hosts on GitHub Actions runners. The hosts-file generator skips domains already present in /etc/hosts, so the pre-resolution mock was never called and the assertions on specific IPs failed. Replace with synthetic .internal domain names that cannot appear in any runner's /etc/hosts, making the test environment-independent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Makes DNS pre-resolution tests independent of GitHub-hosted runner /etc/hosts entries.

Changes:

Replaces public domains with synthetic .internal test domains.
Updates mocked DNS responses and assertions accordingly.

Show a summary per file

File	Description
`src/services/agent-volumes-dns-preresolution.test.ts`	Uses environment-safe synthetic domains in pre-resolution tests.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 0
Review effort level: Medium

github-actions · 2026-07-23T14:07:40Z

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-23T14:07:41Z

✅ Smoke Gemini completed. All facets verified. 💎

Smoke test completed with partial failures: MCP titles filtered, connectivity failed.

github-actions · 2026-07-23T14:07:42Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-07-23T14:07:42Z

🔌 Smoke Services — Service connectivity failed to deliver outputs ⚠️

github-actions · 2026-07-23T14:07:43Z

✅ Smoke Claude passed

github-actions · 2026-07-23T14:07:43Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-07-23T14:07:44Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

github-actions · 2026-07-23T14:07:45Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-07-23T14:07:45Z

✅ Contribution Check completed successfully!

Contribution check complete: the PR follows the visible guidelines. It adds/updates a targeted test, keeps the change in the correct source tree, and the PR description clearly explains the failure and fix. No comment needed.

github-actions · 2026-07-23T14:07:46Z

✅ Build Test Suite completed successfully!

github-actions · 2026-07-23T14:07:47Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-07-23T14:07:51Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-07-23T14:07:53Z

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

github-actions · 2026-07-23T14:07:59Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-07-23T14:08:01Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-23T14:08:29Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-07-23T14:09:34Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.96%	98.99%	📈 +0.03%
Statements	98.88%	98.91%	📈 +0.03%
Functions	99.41%	99.41%	➡️ +0.00%
Branches	95.30%	95.30%	➡️ +0.00%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/log-directory-setup.ts`	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-07-23T14:11:15Z

@lpcox — Smoke test: Copilot Network Isolation Egress Enforcement

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com): HTTP 200
✅ Blocked domain (example.com): connection denied (403 from proxy)

Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:11:20Z

🧪 Smoke Test: Copilot PAT Auth — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP connectivity	✅
File write/read	✅ (`smoke-test-copilot-pat-30014326468.txt` confirmed)

Overall: PASS | Auth mode: PAT (COPILOT_GITHUB_TOKEN)

🔑 PAT report filed by Smoke Copilot PAT
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:11:35Z

🔬 Smoke Test Results

Test	Status
GitHub MCP connectivity	⚠️ Filtered by secrecy policy
GitHub.com connectivity	✅ HTTP 200
File write/read	⚠️ Pre-step variables not expanded

Overall: PARTIAL — Core connectivity passing; pre-step data unavailable (template variables not expanded in agent context).

cc @lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:11:36Z

Smoke Test: Copilot BYOK (Direct) ✅ PASS

✅ MCP connectivity (github-list_pull_requests)
✅ GitHub.com connectivity (HTTP 200)
✅ File write/read test (smoke-test-copilot-byok.txt)
✅ BYOK inference path operational

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:11:44Z

Smoke Test Results

PR titles: Filtered by secrecy policy
GitHub MCP Testing: ❌
GitHub.com Connectivity: ❌
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:12:03Z

Smoke Test: Claude Engine Validation

Check	Result
API Status	✅ PASS
GH Check	✅ PASS
File Status	✅ PASS

Overall Result: PASS

Generated by Smoke Claude for #6522 · 54.3 AIC · ⊞ 3.2K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:12:16Z

🔬 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Notes
1. Module Loading	✅	`otel.js` loads successfully; exports: `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`
2. Test Suite	✅	59 tests passed, 0 failed (`otel.test.js` + `otel-fanout.test.js`)
3. Env Var Forwarding	✅	`src/services/api-proxy-env-config.ts` forwards `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `OTEL_SERVICE_NAME` (confirmed by `api-proxy-env-config.test.ts`)
4. Token Tracker Integration	✅	`onUsage` callback exists in `token-tracker-http.js` (lines 328, 386) as the OTEL hook point
5. OTEL Diagnostics	✅	No OTLP endpoint configured in this run; gracefully falls back to `FileSpanExporter` at `/var/log/api-proxy/otel.jsonl`. `isEnabled()` returns `true` in both modes.

All scenarios pass. ✅

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:12:40Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	`Python 3.12.13`	`Python 3.12.13`	✅ YES
Node.js	`v24.18.0`	`v22.23.1`	❌ NO
Go	`go1.22.12`	`go1.22.12`	✅ YES

Overall: ❌ FAILED — Node.js version mismatch (host: v24.18.0, chroot: v22.23.1).

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:12:46Z

Smoke Test Results

Redis PING: ❌ (host.docker.internal name resolution failed)
PostgreSQL pg_isready: ❌ (no response)
PostgreSQL SELECT 1: ❌ (name resolution failed)

Overall: FAIL — host.docker.internal is not resolvable in this environment.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:12:53Z

Smoke test: PASS

fix(api-proxy): track token usage for aborted streaming responses — ✅
Retry gVisor agent startup crashes once before failing — ✅
GitHub title check — ✅
File write/read — ✅
Build — ✅
Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:13:12Z

@lpcox
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

GitHub MCP connectivity: ❌ (Resource integrity policy prevented reading PR data)
GitHub.com connectivity: ✅
File write/read: ✅
BYOK inference: ✅

Overall: FAIL

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:13:40Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note on Java: Maven's default local repository (~/.m2/repository) was owned by root (no write permission). Tests ran successfully using -Dmaven.repo.local=/tmp/gh-aw/agent/m2repo as a workaround.

Generated by Build Test Suite for #6522 · 43.4 AIC · ⊞ 8.2K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-23T14:14:42Z

🔥 Smoke Test: Docker Sbx — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	✅ `Smoke test passed for Docker Sbx at Thu Jul 23 14:08:04 UTC 2026`

Overall: ✅ PASS

cc @lpcox

📰 BREAKING: Report filed by Smoke Docker Sbx
_{Add label ready-for-aw to run again}

lpcox marked this pull request as ready for review July 23, 2026 13:45

Copilot AI review requested due to automatic review settings July 23, 2026 13:45

Copilot started reviewing on behalf of lpcox July 23, 2026 13:46 View session

Copilot AI reviewed Jul 23, 2026

View reviewed changes

lpcox added the ready-for-aw label Jul 23, 2026

lpcox temporarily deployed to aoai-model July 23, 2026 14:07 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Jul 23, 2026

github-actions Bot added the smoke-copilot-pat label Jul 23, 2026

github-actions Bot added the smoke-copilot-byok label Jul 23, 2026

github-actions Bot added the smoke-claude label Jul 23, 2026

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jul 23, 2026

lpcox temporarily deployed to aoai-model July 23, 2026 14:12 — with GitHub Actions Inactive

github-actions Bot added the smoke-codex label Jul 23, 2026

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jul 23, 2026

github-actions Bot mentioned this pull request Jul 23, 2026

[aw] Smoke Copilot BYOK AOAI (api-key) failed #6526

Closed

lpcox temporarily deployed to aoai-model July 23, 2026 14:13 — with GitHub Actions Inactive

github-actions Bot added the build-test label Jul 23, 2026

github-actions Bot added the smoke-docker-sbx label Jul 23, 2026

lpcox merged commit 5674a8f into main Jul 23, 2026
140 of 143 checks passed

lpcox deleted the fix/dns-preresolution-test-runner-hosts-e3a52de0f1b7aa18 branch July 23, 2026 15:02

This was referenced Jul 23, 2026

ci: add required supply-chain scan on every PR #6530

Merged

refactor: shared hardened JSON string-map parser for BYOK header/body parsing #6528

Merged

Uh oh!

Conversation

github-actions Bot commented Jul 23, 2026

Problem

Fix

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026

🧪 Smoke Test: Copilot PAT Auth — PASS

Uh oh!

github-actions Bot commented Jul 23, 2026

🔬 Smoke Test Results

Uh oh!

github-actions Bot commented Jul 23, 2026

Smoke Test: Copilot BYOK (Direct) ✅ PASS

Uh oh!

github-actions Bot commented Jul 23, 2026

Smoke Test Results

Uh oh!

github-actions Bot commented Jul 23, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading