Skip to content

fix(agent): restore python3 in agent image for seccomp regression check#6559

Merged
lpcox merged 1 commit into
mainfrom
fix-seccomp-check-no-python
Jul 24, 2026
Merged

fix(agent): restore python3 in agent image for seccomp regression check#6559
lpcox merged 1 commit into
mainfrom
fix-seccomp-check-no-python

Conversation

@lpcox

@lpcox lpcox commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Problem

The release workflow's "Verify seccomp blocks name_to_handle_at/open_by_handle_at" step started failing (run 30055796826) with:

Image does not contain python3, cannot run seccomp syscall regression check

That release-time check (scripts/ci/check-agent-seccomp-syscalls.sh) runs docker run --entrypoint python3 <agent-image> and uses python3 + ctypes to fire the raw name_to_handle_at / open_by_handle_at syscalls and assert the seccomp profile denies them.

python3 had been present in the agent image transitively (via the old NodeSource apt install of Node.js) and the prior release (v0.27.39) ran the probe successfully. PR #6545 ("resolve High/Critical CVEs in agent, api-proxy, and cli-proxy container images", commit 9bfc7260) reworked the package install and switched Node.js from the NodeSource .deb to the official static tarball — the only change to containers/agent/Dockerfile between the passing and failing releases — which inadvertently dropped that transitive python3.

Fix

Restore python3 explicitly by adding it to the agent image's package list. This returns the image to its prior (working) state for the seccomp check, and python3 is also commonly needed by agent workflows, matching the GitHub runner images. --no-install-recommends still pulls libpython3.10-stdlib, so ctypes (used by the probe) is available.

The seccomp check script and profile are unchanged.

Notes

Copilot AI review requested due to automatic review settings July 24, 2026 03:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replaces the agent image’s Python-dependent seccomp regression harness with a static, cross-compiled Go probe.

Changes:

  • Adds an amd64/arm64 raw-syscall Go probe.
  • Builds and bind-mounts the probe for seccomp checks.
  • Adds Go setup to the release workflow.
Show a summary per file
File Description
scripts/ci/seccomp-probe.go Implements the static syscall probe.
scripts/ci/check-agent-seccomp-syscalls.sh Builds and executes the probe.
.github/workflows/release.yml Installs Go for the release check.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread .github/workflows/release.yml Outdated
Comment on lines +199 to +200
with:
go-version: '1.24'
@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 98.96% 98.99% 📈 +0.03%
Statements 98.88% 98.91% 📈 +0.03%
Functions 99.41% 99.41% ➡️ +0.00%
Branches 95.30% 95.30% ➡️ +0.00%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/log-directory-setup.ts 96.2% → 100.0% (+3.78%) 96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

PR #6545 (CVE cleanup) reworked the agent image's package install and
switched Node.js from the NodeSource apt package to the official static
tarball. That inadvertently dropped python3, which had been present
transitively and is used by the release-time seccomp regression check
(scripts/ci/check-agent-seccomp-syscalls.sh) to fire the
name_to_handle_at/open_by_handle_at syscalls via python3+ctypes.

As a result the "Verify seccomp blocks name_to_handle_at/open_by_handle_at"
release step failed with "Image does not contain python3".

Restore python3 by adding it to the agent image's package list. python3 is
also commonly needed by agent workflows, matching GitHub runner images.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b5e69791-2bb7-4379-938e-464e9b83c056
@lpcox
lpcox force-pushed the fix-seccomp-check-no-python branch from 0731185 to 3fc9f73 Compare July 24, 2026 03:25
@github-actions

Copy link
Copy Markdown
Contributor

✅ Copilot review passed with no inline comments.

@lpcox Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

@lpcox lpcox changed the title fix(ci): remove python3 dependency from seccomp regression check fix(agent): restore python3 in agent image for seccomp regression check Jul 24, 2026
@lpcox
lpcox enabled auto-merge (squash) July 24, 2026 03:35
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Smoke Claude passed

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Smoke Gemini completed. All facets verified. 💎

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🔌 Smoke Services — All services reachable! ✅

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Build Test Suite completed successfully!

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🔑 Smoke Copilot PAT reports failed. PAT auth path may have issues...

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Contribution Check completed successfully!

Contribution check complete: PR #6559 is consistent with CONTRIBUTING.md. The change is in the correct container directory, the PR description is clear and references related work, and the existing release-time seccomp regression check covers the behavior. No guideline-level issue to comment on.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Security Guard failed. Please review the logs for details.

@github-actions

Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Status
GitHub MCP connectivity ✅ Connected (PR filtered by policy)
GitHub.com HTTP ⚠️ Pre-step data not injected
File write/read ⚠️ Pre-step data not injected

Overall: PARTIAL — MCP reachable; pre-computed step outputs were not substituted (template variable issue in workflow).

CC: @lpcox

📰 BREAKING: Report filed by Smoke Copilot
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: Claude Engine Validation

Check Result
API status ✅ PASS
gh check ✅ PASS
File status ✅ PASS

Overall result: PASS

Generated by Smoke Claude for #6559 · haiku45 54 AIC · ⊞ 3.3K ·
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

🔒 Smoke Test: Copilot Network Isolation

@lpcox

EGRESS_RESULT allow=pass deny=pass

  • ✅ Allowed domain (api.github.com) → HTTP 200
  • ✅ Blocked domain (example.com) → 403 denied by proxy

Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
Add label ready-for-aw to run again

@github-actions github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Direct) Mode ✅

Tests Passed:

  • ✅ MCP Connectivity: Verified GitHub API access
  • ✅ GitHub.com Connectivity: HTTP 200
  • ✅ File Write/Read: Successful
  • ✅ BYOK Inference: Direct mode active (api-proxy sidecar → api.githubcopilot.com)

Status: PASS

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar with real credentials held server-side.

🔑 BYOK report filed by Smoke Copilot BYOK
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

Gemini Smoke Test Results

  • GitHub MCP Testing: ❌ (Tool executed but results filtered by secrecy)
  • GitHub.com Connectivity: ❌ (Connection failed)
  • File Writing Testing: ✅ (Passed)
  • Bash Tool Testing: ✅ (Passed)

Overall Status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test

  • ci: use github.token for copilot-engine workflows (drop removed COPILOT_GITHUB_TOKEN secret)
  • fix: resolve High/Critical CVEs in agent, api-proxy, and cli-proxy container images
  • GitHub title: ✅
  • File write/read: ✅
  • Discussion lookup: ✅
  • Build: ✅
  • Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.13 ✅ YES
Node.js v24.18.0 v22.23.1 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall: ❌ FAILED — Node.js version mismatch between host (v24.18.0) and chroot (v22.23.1).

Tested by Smoke Chroot
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: Services Connectivity

Check Result
Redis PING ❌ Name resolution failed for host.docker.internal
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Name resolution failed

Overall: FAILhost.docker.internal is not resolvable in this environment (not running inside Docker).

🔌 Service connectivity validated by Smoke Services
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

@lpcox Smoke test results:

  • GitHub MCP Testing: ✅
  • GitHub.com Connectivity: ✅
  • File Write/Read Test: ✅
  • BYOK Inference Test: ✅
    Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
    Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario Result Notes
Module Loading ✅ Pass otel.js loads cleanly; exports: startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled + internals
Test Suite ✅ Pass 59 tests passed, 0 failed across 2 suites (otel.test.js, otel-fanout.test.js)
Env Var Forwarding ✅ Pass src/services/api-proxy-env-config.ts forwards OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS, GITHUB_AW_OTEL_TRACE_ID, GITHUB_AW_OTEL_PARENT_SPAN_ID, and sets OTEL_SERVICE_NAME=awf-api-proxy
Token Tracker Integration ✅ Pass onUsage callback exists in token-tracker-http.js (line 348/406) as the OTEL hook point
OTEL Diagnostics ✅ Pass Spans export correctly; FileSpanExporter falls back to /var/log/api-proxy/otel.jsonl when no endpoint configured

All 5 scenarios pass. OTEL tracing integration is fully functional.

📡 OTel tracing validated by Smoke OTel Tracing
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note (Java): The default ~/.m2 directory was root-owned in this environment. Tests ran successfully using -Dmaven.repo.local=/tmp/gh-aw/agent/m2repo as a workaround.

Generated by Build Test Suite for #6559 · sonnet46 47.8 AIC · ⊞ 8.3K ·
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor

🔥 Smoke Test Results — PR #6559

Test Status
GitHub MCP connectivity ✅ (connected, secrecy policy filtered results)
GitHub.com HTTP ✅ HTTP 200
File write/read ❌ File not found (template vars unresolved in pre-step)

Overall: PARTIAL PASS (2/3 infra tests passed; file test blocked by unresolved template variables)

@lpcox

📰 BREAKING: Report filed by Smoke Docker Sbx
Add label ready-for-aw to run again

@lpcox
lpcox merged commit 9e815e1 into main Jul 24, 2026
138 of 142 checks passed
@lpcox
lpcox deleted the fix-seccomp-check-no-python branch July 24, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants