[Test Coverage] src/upstream-proxy.ts – port-out-of-range branch by github-actions[bot] · Pull Request #6602 · github/gh-aw-firewall

github-actions · 2026-07-26T08:59:37Z

Summary

Adds a test case to cover the previously-uncovered line 110 in src/upstream-proxy.ts:

if (isNaN(port) || port < 1 || port > 65535) {
  throw new Error(`Invalid upstream proxy port: ${parsed.port}`);
}

Port 0 is a syntactically valid value for the WHATWG URL parser but is rejected by AWF's validation as unusable. This specific branch was the only uncovered statement in upstream-proxy.ts (coverage was 94.9% statements, 94.7% branches).

Changes

src/upstream-proxy.test.ts — adds 'rejects port 0 as out-of-range' test inside the parseProxyUrl describe block.

Coverage impact

File	Before	After
`src/upstream-proxy.ts` (statements)	94.9%	~96.2%
`src/upstream-proxy.ts` (branches)	94.7%	~96.0%

Test run

All 41 tests in upstream-proxy.test.ts and squid/upstream-proxy.test.ts pass.

Generated by Test Coverage Improver · sonnet46 · 87.4 AIC · ⊞ 6.4K · ◷

Cover line 110 in src/upstream-proxy.ts — the guard that rejects port values outside the valid 1–65535 range (NaN, 0, or overflow). Port 0 is a valid URL per the WHATWG URL parser but meaningless as a proxy port; the existing tests stopped before this branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds coverage for rejecting upstream proxy port 0.

Changes:

Tests the lower-bound port validation in parseProxyUrl.

Show a summary per file

File	Description
`src/upstream-proxy.test.ts`	Adds the port `0` rejection test.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 0
Review effort level: Medium

github-actions · 2026-07-26T16:32:04Z

✅ Copilot review passed with no inline comments.

@github-actions[bot] Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-07-26T16:32:38Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-26T16:32:39Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

github-actions · 2026-07-26T16:32:39Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-07-26T16:32:39Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-07-26T16:32:40Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-07-26T16:32:41Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-07-26T16:32:41Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-07-26T16:32:42Z

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-26T16:32:42Z

✅ Smoke Claude passed

github-actions · 2026-07-26T16:32:43Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-07-26T16:32:46Z

✅ Build Test Suite completed successfully!

github-actions · 2026-07-26T16:32:47Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-07-26T16:32:51Z

✅ Contribution Check completed successfully!

Contribution check complete: the PR follows the applicable CONTRIBUTING.md guidelines. It adds the expected test in the correct location, the PR description is clear, and no documentation or organization issues stand out for this coverage-only change.

github-actions · 2026-07-26T16:33:24Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-07-26T16:33:28Z

✅ Smoke Gemini completed. All facets verified. 💎

Smoke tests completed. GitHub MCP and Connectivity tests failed, File system tests passed. Result: FAIL. Reported to PR #6602.

github-actions · 2026-07-26T16:34:23Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	99.12%	99.16%	📈 +0.04%
Statements	99.03%	99.08%	📈 +0.05%
Functions	99.52%	99.52%	➡️ +0.00%
Branches	95.60%	95.62%	📈 +0.02%

📁 Per-file Coverage Changes (2 files)

File	Lines (Before → After)	Statements (Before → After)
`src/upstream-proxy.ts`	94.5% → 95.9% (+1.37%)	94.9% → 96.2% (+1.27%)
`src/log-directory-setup.ts`	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-07-26T16:35:54Z

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
gh check	✅ PASS
File status	✅ PASS

Overall result: PASS

Generated by Smoke Claude for #6602 · haiku45 · 53.9 AIC · ⊞ 6.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:36:01Z

🔒 Smoke Test: Copilot Network Isolation

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com): HTTP 200
✅ Blocked domain (example.com): 403 — blocked as expected
Overall: PASS

@lpcox all egress checks passed.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:36:14Z

Smoke Test: Copilot BYOK (Direct) — PASS ✅

✅ GitHub MCP connectivity
✅ GitHub.com connectivity (HTTP 200)
✅ File write/read
✅ BYOK inference path active

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:36:18Z

🔍 Smoke Test Results

Test	Status
GitHub MCP Connectivity	✅ PASS
GitHub.com HTTP	⚠️ N/A (template vars unexpanded)
File Write/Read	⚠️ N/A (template vars unexpanded)

Overall: PARTIAL — MCP connectivity confirmed; pre-computed test data unavailable due to workflow template variable expansion failure.

Triggered on PR #6602. Author/assignees not accessible (secrecy policy).

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:36:53Z

@lpcox Smoke test for PRs: ${{ steps.smoke-data.outputs.SMOKE_PR_DATA }}
• MCP API: ✅
• GitHub.com HTTP: ✅
• File I/O: ✅
• BYOK inference: ✅
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:36:58Z

Chroot Runtime Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	`Python 3.12.13`	`Python 3.12.13`	✅ YES
Node.js	`v24.18.0`	`v22.23.1`	❌ NO
Go	`go1.22.12`	`go1.22.12`	✅ YES

Overall: ❌ FAILED — Node.js version mismatch between host (v24.18.0) and chroot (v22.23.1).

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:37:09Z

Smoke Test Results — Services Connectivity

Check	Result
Redis PING	❌ `host.docker.internal` DNS resolution failed; also tried `172.17.0.1` — network unreachable
PostgreSQL pg_isready	❌ No response on either `host.docker.internal` or `172.17.0.1:5432`
PostgreSQL SELECT 1	❌ Could not connect (same DNS/network issue)

Overall: FAIL

host.docker.internal does not resolve in this sandbox environment (no Docker bridge available). Service containers are not reachable.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:37:15Z

Smoke Test Results

GitHub MCP: ❌ (Secrecy Policy blocked access to PRs)
GitHub.com Connectivity: ❌ (Connection failed)
File Writing: ✅
Bash Tool: ✅

Overall Status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:37:21Z

✅ test: drop stale smoke-copilot-pat references
✅ fix: update brace-expansion to 5.0.8 (GHSA-mh99-v99m-4gvg)
✅ GH PR query
✅ Playwright/GitHub title
✅ File + build
Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:37:55Z

Smoke Test: API Proxy OpenTelemetry Tracing — Results

Scenario	Status	Notes
1. Module Loading	✅	`otel.js` loads; exports `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`
2. Test Suite	✅	59 tests passed, 0 failed across 2 suites (`otel.test.js`, `otel-fanout.test.js`)
3. Env Var Forwarding	✅	`api-proxy-env-config` forwards `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME`
4. Token Tracker `onUsage`	✅	`onUsage` callback present at line 406 in `token-tracker-http.js` — OTEL hook point confirmed
5. OTEL Diagnostics	⚠️	Live span export data not accessible from sandbox; no errors detected

All validatable scenarios pass. OTEL integration is functional.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:39:02Z

Smoke Test Results

GitHub MCP: ❌ Resource fetch failed (lower integrity)
GitHub.com: ✅
File I/O: ✅
BYOK Inference: ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

Overall: FAIL

@lpcox

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:39:06Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for #6602 · sonnet46 · 50.2 AIC · ⊞ 8.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-26T16:39:42Z

🔥 Smoke Test: Docker Sbx — PASS

Test	Result
GitHub MCP connectivity	✅ Connected (secrecy-filtered response)
GitHub.com HTTP	✅ (pre-step confirmed reachable)
File write/read	✅ `smoke-test-docker-sbx-30210654419.txt` verified

Overall: PASS · Run: 30210654419

📰 BREAKING: Report filed by Smoke Docker Sbx
_{Add label ready-for-aw to run again}

lpcox marked this pull request as ready for review July 26, 2026 16:12

Copilot AI review requested due to automatic review settings July 26, 2026 16:12

Copilot started reviewing on behalf of lpcox July 26, 2026 16:13 View session

Copilot AI reviewed Jul 26, 2026

View reviewed changes

lpcox added the ready-for-aw label Jul 26, 2026

lpcox temporarily deployed to aoai-model July 26, 2026 16:32 — with GitHub Actions Inactive

github-actions Bot added the smoke-claude label Jul 26, 2026

github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Jul 26, 2026

github-actions Bot added the smoke-copilot-byok label Jul 26, 2026

lpcox temporarily deployed to aoai-model July 26, 2026 16:36 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jul 26, 2026

lpcox temporarily deployed to aoai-model July 26, 2026 16:36 — with GitHub Actions Inactive

github-actions Bot added the smoke-codex label Jul 26, 2026

github-actions Bot added the build-test label Jul 26, 2026

github-actions Bot added the smoke-docker-sbx label Jul 26, 2026

lpcox merged commit 58b9cbe into main Jul 26, 2026
139 of 140 checks passed

lpcox deleted the test-coverage/upstream-proxy-port-validation-6dfde0bb4009773f branch July 26, 2026 17:04

github-actions Bot mentioned this pull request Jul 26, 2026

Refactor API proxy providers to share OIDC/static auth adapter scaffold #6608

Merged

Uh oh!

Conversation

github-actions Bot commented Jul 26, 2026

Summary

Changes

Coverage impact

Test run

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jul 26, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jul 26, 2026

🔒 Smoke Test: Copilot Network Isolation

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

github-actions Bot commented Jul 26, 2026

🔍 Smoke Test Results

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

github-actions Bot commented Jul 26, 2026

Chroot Runtime Version Comparison

Uh oh!

github-actions Bot commented Jul 26, 2026

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading

github-actions Bot commented Jul 26, 2026 •

edited

Loading