[docs] sbx/gVisor: docs: add missing usesIptables to sbx-integration.md registry snippets - #6620
Conversation
The RUNTIME_REGISTRY code snippets in docs/sbx-integration.md were missing the `usesIptables` capability flag that exists in the actual registry in src/container-runtime.ts. Updated both snippets: 1. The descriptive registry excerpt in Part 2 (executionModel abstraction) 2. The "Adding another microVM backend" example in Part 3 Source: src/container-runtime.ts RUNTIME_REGISTRY definition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
🔌 Smoke Services — All services reachable! ✅ |
|
✅ Smoke Claude passed |
|
✅ Contribution Check completed successfully! Contribution check complete for PR #6620: the PR is documentation-only, the description is clear, and the change is placed in the docs area. No additional review comment was needed. |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤 |
|
🚀 Security Guard has started processing this pull request |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓 |
|
✅ Build Test Suite completed successfully! |
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
Smoke Test: Claude Engine Validation
Overall result: PASS ✅
|
🔬 Smoke Test Results
Overall: PARTIAL — MCP secrecy policy filtered PR data; HTTP connectivity confirmed ✅
|
Smoke Test: Copilot Network Isolation Egress Enforcement
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: API Proxy OpenTelemetry Tracing
Overall: All 5 scenarios pass ✅
|
|
Smoke test summary: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Version Comparison Results
Overall: ❌ FAILED — Node.js version mismatch (host:
|
|
Smoke Copilot BYOK Test Results ✅ File write/read test (passed) Overall: PASS — Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar.
|
Smoke Test Results — FAIL
Overall: FAIL —
|
Smoke Test: Gemini Engine Validation
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results — Docker Sbx
Overall: INCONCLUSIVE — Template variables from pre-agent steps were not expanded; pre-fetched data unavailable in this context. MCP read filtered by secrecy policy.
|
|
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Overall: FAIL
|
|
Smoke test Copilot BYOK (AOAI Entra):
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
|
Weekly doc reconciliation — 2026-07-27
What changed
docs/sbx-integration.md— two code snippets corrected.Correction 1:
RUNTIME_REGISTRYexcerpt in Part 2 ("TheexecutionModelabstraction")The snippet showed only three fields per registry entry. The actual registry in
src/container-runtime.tshas four fields —usesIptableswas added to theRuntimeCapabilitiesinterface and both entries (gvisor,sbx) declare it. The excerpt now matches the real code:Source:
src/container-runtime.tslines 99–115.Correction 2: new-runtime example in Part 3 ("Adding another KVM-based microVM backend")
The
myvmsnippet in the "Register the runtime" step was also missingusesIptables, making it inconsistent with the real interface. AddedusesIptables: falsewith an explanatory comment.Source:
src/container-runtime.tsRuntimeCapabilitiesinterface.docs/gvisor-integration.mdReviewed against upstream gVisor docs (
https://gvisor.dev/docs/architecture_guide/platforms/,/networking/,/intro/) and the implementation (src/container-runtime.ts,src/services/agent-service.ts,src/topology.ts,src/services/agent-environment/tool-specific-environment.ts). The doc's registry snippet already contains all four fields. Platform names (Systrap/KVM/ptrace), netstack DNS workaround,usesIptables: falsebehavior,BUN_JSC_useJIT=0shim, andextra_hostswiring are all still accurate. No changes needed.Files reviewed but not changed
src/sbx-manager.ts—DOCKER_SANDBOXES_PROXYbehavior, credential scrubbing, mount logic all match doc descriptions.src/commands/main-action.ts—SBX_GATEWAY_IP = '172.17.0.0',host.docker.internaltargeting, health poll, all match.src/commands/validators/security-mode.ts—isMicroVmRuntime/DOCKER_SANDBOXES_PROXYcomment matches doc.#6607harness refactor) — no behavior changes to the files cited by either doc.