Skip to content

[docs] sbx/gVisor: docs: add missing usesIptables to sbx-integration.md registry snippets - #6620

Merged
lpcox merged 1 commit into
mainfrom
docs/sbx-gvisor-weekly-update-2026-07-27-736dcedb83e68a4a
Jul 27, 2026
Merged

[docs] sbx/gVisor: docs: add missing usesIptables to sbx-integration.md registry snippets#6620
lpcox merged 1 commit into
mainfrom
docs/sbx-gvisor-weekly-update-2026-07-27-736dcedb83e68a4a

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Weekly doc reconciliation — 2026-07-27

What changed

docs/sbx-integration.md — two code snippets corrected.

Correction 1: RUNTIME_REGISTRY excerpt in Part 2 ("The executionModel abstraction")

The snippet showed only three fields per registry entry. The actual registry in src/container-runtime.ts has four fields — usesIptables was added to the RuntimeCapabilities interface and both entries (gvisor, sbx) declare it. The excerpt now matches the real code:

// before
gvisor: { executionModel: 'compose', dockerRuntime: 'runsc', needsStaticDns: true },
sbx:    { executionModel: 'microvm', dockerRuntime: undefined, needsStaticDns: false },

// after
gvisor: { executionModel: 'compose', dockerRuntime: 'runsc', needsStaticDns: true,  usesIptables: false },
sbx:    { executionModel: 'microvm', dockerRuntime: undefined, needsStaticDns: false, usesIptables: false },

Source: src/container-runtime.ts lines 99–115.

Correction 2: new-runtime example in Part 3 ("Adding another KVM-based microVM backend")

The myvm snippet in the "Register the runtime" step was also missing usesIptables, making it inconsistent with the real interface. Added usesIptables: false with an explanatory comment.

Source: src/container-runtime.ts RuntimeCapabilities interface.


docs/gvisor-integration.md

Reviewed against upstream gVisor docs (https://gvisor.dev/docs/architecture_guide/platforms/, /networking/, /intro/) and the implementation (src/container-runtime.ts, src/services/agent-service.ts, src/topology.ts, src/services/agent-environment/tool-specific-environment.ts). The doc's registry snippet already contains all four fields. Platform names (Systrap/KVM/ptrace), netstack DNS workaround, usesIptables: false behavior, BUN_JSC_useJIT=0 shim, and extra_hosts wiring are all still accurate. No changes needed.

Files reviewed but not changed

  • src/sbx-manager.tsDOCKER_SANDBOXES_PROXY behavior, credential scrubbing, mount logic all match doc descriptions.
  • src/commands/main-action.tsSBX_GATEWAY_IP = '172.17.0.0', host.docker.internal targeting, health poll, all match.
  • src/commands/validators/security-mode.tsisMicroVmRuntime / DOCKER_SANDBOXES_PROXY comment matches doc.
  • Recent git log (7 days): one relevant commit (#6607 harness refactor) — no behavior changes to the files cited by either doc.

Generated by sbx & gVisor Documentation Updater · sonnet46 · 121.9 AIC · ⊞ 6.1K ·

The RUNTIME_REGISTRY code snippets in docs/sbx-integration.md were
missing the `usesIptables` capability flag that exists in the actual
registry in src/container-runtime.ts. Updated both snippets:

1. The descriptive registry excerpt in Part 2 (executionModel
   abstraction)
2. The "Adding another microVM backend" example in Part 3

Source: src/container-runtime.ts RUNTIME_REGISTRY definition.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added ai-generated documentation Improvements or additions to documentation labels Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

Documentation Preview

Documentation build failed for this PR. View logs.

Built from commit 9abdf21

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Gemini completed. All facets verified. 💎

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

🔌 Smoke Services — All services reachable! ✅

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Claude passed

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Contribution Check completed successfully!

Contribution check complete for PR #6620: the PR is documentation-only, the description is clear, and the change is placed in the docs area. No additional review comment was needed.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

@github-actions

Copy link
Copy Markdown
Contributor Author

🚀 Security Guard has started processing this pull request

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Build Test Suite completed successfully!

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: Claude Engine Validation

Check Result
API status ✅ PASS
gh check ✅ PASS
File status ✅ PASS

Overall result: PASS

Generated by Smoke Claude for #6620 · haiku45 · 31 AIC · ⊞ 3.3K ·
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

🔬 Smoke Test Results

Test Status
GitHub MCP connectivity ⚠️ filtered by secrecy policy
GitHub.com HTTP ✅ 200
File write/read ⚠️ template vars not expanded

Overall: PARTIAL — MCP secrecy policy filtered PR data; HTTP connectivity confirmed ✅

📰 BREAKING: Report filed by Smoke Copilot
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: Copilot Network Isolation Egress Enforcement

EGRESS_RESULT allow=pass deny=pass

  • ✅ Allowed domain (api.github.com): HTTP 403 received — proxy reachable, egress works
  • ✅ Blocked domain (example.com): connection denied (proxy 403) — blocked as expected
  • Overall: PASS

@lpcox — both egress checks passed.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
Add label ready-for-aw to run again

@github-actions github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: API Proxy OpenTelemetry Tracing

Scenario Result Notes
S1: Module Loading otel.js loads successfully; exports: startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled + test helpers
S2: Test Suite 45 tests passed, 0 failed (otel.test.js, otel-fanout.test.js, upstream-token.test.js) — spans, exporters, serialization, graceful degradation all covered
S3: Env Var Forwarding src/services/api-proxy-env-config.ts forwards all OTEL vars: GH_AW_OTLP_ENDPOINTS, OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS, GITHUB_AW_OTEL_TRACE_ID, GITHUB_AW_OTEL_PARENT_SPAN_ID, OTEL_SERVICE_NAME
S4: Token Tracker Integration onUsage callback exists in token-tracker-http.js (line 348); invoked after normalized usage extraction; wired to OTEL span attributes via upstream-token.js
S5: OTEL Diagnostics Graceful degradation confirmed: when no endpoint configured, spans write to /var/log/api-proxy/otel.jsonl as local fallback

Overall: All 5 scenarios pass ✅

📡 OTel tracing validated by Smoke OTel Tracing
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke test summary:
✅ Upgrade gh-aw to v0.83.3 pre-release and recompile workflows
✅ Refactor API proxy providers to share OIDC/static auth adapter scaffold
✅ GitHub title check passed
✅ File write/read check passed
✅ Latest discussion lookup returned #6624
✅ Build: npm ci && npm run build
Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.13 ✅ YES
Node.js v24.18.0 v22.23.1 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall: ❌ FAILED — Node.js version mismatch (host: v24.18.0, chroot: v22.23.1).

Tested by Smoke Chroot
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK Test Results

✅ File write/read test (passed)
✅ GitHub.com connectivity (HTTP 200)
✅ BYOK inference path active (agent responding via api-proxy → api.githubcopilot.com)
⚠️ GitHub MCP testing (filtered by secrecy policy - expected)

Overall: PASS — Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar.

🔑 BYOK report filed by Smoke Copilot BYOK
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test Results — FAIL

Check Result
Redis PING ❌ Name resolution failed for host.docker.internal
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Name resolution failed

Overall: FAILhost.docker.internal is not resolvable in this environment.

🔌 Service connectivity validated by Smoke Services
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: Gemini Engine Validation

  • GitHub MCP Testing: ❌ (Filtered by secrecy policy)
  • GitHub.com Connectivity: ❌ (HTTP 000 / DNS SERVFAIL)
  • File Writing Testing: ✅
  • Bash Tool Testing: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx passed ✅ PASS
Node.js execa passed ✅ PASS
Node.js p-limit passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note: Java tests required using a custom local Maven repo path (-Dmaven.repo.local) because ~/.m2/repository was owned by root.

Generated by Build Test Suite for #6620 · sonnet46 · 35.7 AIC · ⊞ 8.3K ·
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test Results — Docker Sbx

Test Status
GitHub MCP connectivity ⚠️ Filtered by secrecy policy
GitHub.com HTTP ⚠️ Pre-step data not expanded
File write/read ⚠️ Pre-step data not expanded

Overall: INCONCLUSIVE — Template variables from pre-agent steps were not expanded; pre-fetched data unavailable in this context. MCP read filtered by secrecy policy.

Author: @lpcox

📰 BREAKING: Report filed by Smoke Docker Sbx
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

  • MCP connectivity: ❌ tool error (filtered by secrecy policy)
  • GitHub.com connectivity: ✅
  • File write/read: ✅
  • BYOK inference: ✅

Overall: FAIL

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke test Copilot BYOK (AOAI Entra):

  • GitHub MCP: ✅
  • GitHub.com HTTP: ✅
  • File write/read: ✅
  • BYOK inference: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
Overall: PASS
@lpcox

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
Add label ready-for-aw to run again

@lpcox
lpcox merged commit ce9169d into main Jul 27, 2026
129 of 130 checks passed
@lpcox
lpcox deleted the docs/sbx-gvisor-weekly-update-2026-07-27-736dcedb83e68a4a branch July 27, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant