fix: patch vulnerable gRPC in GitHub CLI images - #7997
Conversation
PR #7954 refactored Gemini/Vertex to share makeGoogleProviderFactory() instead of directly sharing createGoogleApiKeyAdapter. Update the auth-matrix implementation note to match current main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately reflects the verified Gemini and Vertex adapter implementations.
Pull request overview
Updates authentication documentation to match the shared Google provider factory introduced in #7954.
Changes:
- Corrects the Vertex AI implementation note.
- Documents that both Vertex and Gemini use
makeGoogleProviderFactory.
File summaries
| File | Description |
|---|---|
docs/auth-matrix.md |
Aligns Vertex adapter documentation with current implementation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
✅ Copilot review passed with no inline comments. @github-actions[bot] Add the |
Override GitHub CLI's vulnerable gRPC dependency in both images. Verify the fixed module version is embedded in each resulting binary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 21b0cf92-6035-4af9-8570-f84d0dff9ed1
Keep the current declarative Google provider documentation while retaining the gRPC image fix. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 21b0cf92-6035-4af9-8570-f84d0dff9ed1
|
✅ Security Guard completed successfully! PR #7997 security review complete. No security issues found. Changes patch a vulnerable gRPC dependency in GitHub CLI Dockerfiles with verification step. No firewall rules weakened, no capabilities added, no allowlist expansion. PR passes security review.
|
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤
|
|
🔌 Smoke Services — All services reachable! ✅
|
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed25.pkgs.visualstudio.com"See Network Configuration for more information.
|
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
✅ Contribution Check completed successfully! No contribution-guideline issues found in PR #7997. The description is clear and references the fix, the change is in the correct container directories, and it includes validation notes; no additional comment was needed.
|
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅
|
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓
|
|
✅ Build Test Suite completed successfully!
|
|
✅ Smoke Claude passed Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.anthropic.com"See Network Configuration for more information.
|
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓
|
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤
|
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall status: PASS
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: Claude Engine Validation
Overall result: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.anthropic.com"See Network Configuration for more information.
|
Copilot Engine Smoke Test
Results:
Overall: PASS
|
|
Smoke Test: API Proxy OTEL Tracing — Results
Overall: 4/5 scenarios passed directly; 1 pending live-run diagnostics confirmation (expected/non-blocking).
|
Smoke Test Results: FAIL ❌
Overall: FAIL —
|
|
Smoke Test: Docker Sbx — cc
Overall: PASS
|
|
Smoke Test: Copilot BYOK (Direct) Mode — PASS ✅ GitHub MCP connectivity Running in direct BYOK mode via
|
|
PR titles: unavailable (required GitHub read tools missing) Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed25.pkgs.visualstudio.com"See Network Configuration for more information.
|
Chroot Version Comparison
Result: Not all tests passed — Node.js version mismatch between host and chroot environment.
|
|
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Note: Java builds required overriding the local Maven repository (
|
|
Connect agent enclaves directly to shared GitHub MCP: ✅ Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall: PASS
|
Summary
google.golang.org/grpcv1.83.1.ghbinary embeds the fixed module version.main, where the provider registry documentation is already current.This fixes the blocking Grype finding for
GHSA-vp52-pcj8-j9qc/CVE-2026-84304.Validation
gh-buildDocker stages successfully.