[log] Add debug logging to internal/githubhttp/rate_limit.go by github-actions[bot] · Pull Request #10586 · github/gh-aw-mcpg

github-actions · 2026-08-02T23:42:31Z

Summary

Adds meaningful debug logging to internal/githubhttp/rate_limit.go to aid troubleshooting of GitHub API rate-limit detection.

Changes

IsRateLimitText: logs when a rate-limit indicator is detected in error text (reusing the existing logHTTP logger and truncated/sanitized text, consistent with ParseRateLimitResetFromText in the same file).
RateLimitSignal: logs when a nil response is passed (no signal possible), and logs the status code, remaining, and reset header values when a rate limit is detected.

No new logger was created — the file already declares logHTTP (used elsewhere in the same file), so all new calls reuse it per the pkg:filename naming convention already established.

Validation

go build -o awmg . — succeeds
go vet ./internal/githubhttp — clean
go test ./internal/githubhttp — passes

Only this one file was modified.

Generated by Go Logger Enhancement · auto · 46 AIC · ⊞ 12.4K · ◷

Add meaningful debug log calls to IsRateLimitText and RateLimitSignal to aid troubleshooting of GitHub API rate-limit detection, using the existing logHTTP logger. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds debug diagnostics for GitHub API rate-limit detection.

Changes:

Logs sanitized rate-limit text matches.
Logs nil responses and detected HTTP rate-limit signals.

Show a summary per file

File	Description
`internal/githubhttp/rate_limit.go`	Adds rate-limit detection logging.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Balanced

 		strings.Contains(lower, "secondary rate limit") ||
 		strings.Contains(lower, "too many requests")
+	if isRateLimit {
+		logHTTP.Printf("IsRateLimitText: detected rate-limit indicator in text=%q", util.Truncate(sanitize.SanitizeString(text), 120))


lpcox · 2026-08-03T15:18:58Z

@copilot address review feedback

Copilot · 2026-08-03T15:24:35Z

@copilot address review feedback

Addressed in fcb5984.

github-actions · 2026-08-03T16:05:00Z

🔒 mcpg Read-Only Stress — gVisor

Surface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Isolation runtime: gVisor (runsc) kernel-level isolation

Part	Surface	Op	Result	Expected	Status
A	MCP	reads (list_issues/list_prs/get_file/list_commits)	data returned	ALLOWED	✅
B	MCP	writes (reaction/star/issue/comment/branch/file/PR)	`unknown tool` for all 7	BLOCKED	✅
C	CLI	reads (list_issues/get_file via `github` CLI)	data returned	ALLOWED	✅
D	CLI	REST writes (reaction/star/issue/comment/file)	`GH_TOKEN` not set — rejected	BLOCKED	✅
E	CLI	GraphQL mutations (addReaction/addStar/createIssue)	`GH_TOKEN` not set — rejected	BLOCKED	✅

Overall: PASS

Part B note: Gateway exposes only 22 read-only tools (-32602 unknown tool for all write attempts). No write tool reached the backend.
Parts D/E note: gh CLI unauthenticated (no GH_TOKEN); all REST and GraphQL write attempts rejected at the CLI layer before reaching GitHub API.

References: §30827279820

🔒 mcpg read-only stress (gVisor runtime) by Read-Only Stress: gVisor runtime

github-actions · 2026-08-03T16:06:16Z

🔒 mcpg Read-Only Stress — default AWF

Surface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Isolation runtime: default AWF (normal container isolation)

Part	Surface	Op	Result	Expected	Status
A	MCP	reads (list_issues, list_pulls, get_file_contents, list_commits)	data returned	ALLOWED	✅
B	MCP	writes (reaction/star/issue/comment/branch/file/PR)	all refused by gateway allowlist	BLOCKED	✅
C	CLI	reads	data returned via MCP CLI (gh unauthenticated)	ALLOWED	✅
D	CLI	REST writes (reaction/star/issue/comment/file)	all refused — gh unauthenticated	BLOCKED	✅
E	CLI	GraphQL mutations (addReaction/addStar/createIssue)	all refused — gh unauthenticated	BLOCKED	✅

Overall: PASS

Part B detail: Gateway exposes only 22 read-only tools (get_*, list_*, search_*). All 7 write tool calls returned Error [-32602]: unknown tool — gateway-enforced allowlisting. No write succeeded.

Part D/E detail: gh CLI has no GH_TOKEN; all REST and GraphQL write attempts rejected with auth error before reaching GitHub API.

References: §30827279721

🔒 mcpg read-only stress (default AWF runtime) by Read-Only Stress: default runtime

github-actions · 2026-08-03T16:10:12Z

🔒 mcpg Read-Only Stress — docker-sbx

Surface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Isolation runtime: docker-sbx (KVM-isolated microVM)

Part	Surface	Op	Result	Expected	Status
A	MCP	list_issues	3 issues returned	ALLOWED	✅
A	MCP	list_pull_requests	3 PRs returned	ALLOWED	✅
A	MCP	get_file_contents (README.md)	file returned	ALLOWED	✅
A	MCP	list_commits	3 commits returned	ALLOWED	✅
B	MCP	add_issue_reaction	`unknown tool [-32602]` (gateway)	BLOCKED	✅
B	MCP	star_repository	`unknown tool [-32602]` (gateway)	BLOCKED	✅
B	MCP	create_issue	`unknown tool [-32602]` (gateway)	BLOCKED	✅
B	MCP	add_issue_comment	`unknown tool [-32602]` (gateway)	BLOCKED	✅
B	MCP	create_branch	`unknown tool [-32602]` (gateway)	BLOCKED	✅
B	MCP	create_or_update_file	`unknown tool [-32602]` (gateway)	BLOCKED	✅
B	MCP	create_pull_request	`unknown tool [-32602]` (gateway)	BLOCKED	✅
C	CLI	list_issues (github CLI)	3 issues returned	ALLOWED	✅
C	CLI	get_file_contents (github CLI)	file returned	ALLOWED	✅
D	CLI	REST reaction POST	gh unauthenticated (blocked)	BLOCKED	✅
D	CLI	REST star PUT	gh unauthenticated (blocked)	BLOCKED	✅
D	CLI	gh issue create	gh unauthenticated (blocked)	BLOCKED	✅
D	CLI	REST issue POST	gh unauthenticated (blocked)	BLOCKED	✅
D	CLI	REST comment POST	gh unauthenticated (blocked)	BLOCKED	✅
D	CLI	REST file PUT	gh unauthenticated (blocked)	BLOCKED	✅
E	GraphQL	addReaction mutation	gh unauthenticated (blocked)	BLOCKED	✅
E	GraphQL	addStar mutation	gh unauthenticated (blocked)	BLOCKED	✅
E	GraphQL	createIssue mutation	gh unauthenticated (blocked)	BLOCKED	✅

Overall: PASS

Note (Part B): Gateway enforces read-only via tool manifest — only 22 read tools exposed. Write tool calls return MCP [-32602]: unknown tool, a gateway-level protocol refusal.

Note (Parts D/E): gh is unauthenticated (GH_TOKEN absent), so all REST/GraphQL writes fail before reaching GitHub.

References: §30827284185

🔒 mcpg read-only stress (docker-sbx runtime) by Read-Only Stress: docker-sbx runtime

Add debug logging to githubhttp rate_limit.go

34f42d5

Add meaningful debug log calls to IsRateLimitText and RateLimitSignal to aid troubleshooting of GitHub API rate-limit detection, using the existing logHTTP logger. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions Bot added automation enhancement New feature or request labels Aug 2, 2026

lpcox marked this pull request as ready for review August 3, 2026 14:57

Copilot AI review requested due to automatic review settings August 3, 2026 14:57

Copilot started reviewing on behalf of lpcox August 3, 2026 14:57 View session

Copilot AI reviewed Aug 3, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

github-actions Bot added the readonly-stress-pass-default label Aug 3, 2026

This comment has been minimized.

Sign in to view

github-actions Bot added the readonly-stress-pass-gvisor label Aug 3, 2026

This comment has been minimized.

Sign in to view

Copilot started work on behalf of lpcox August 3, 2026 15:19 View session

Use file-local rate limit logger

fcb5984

Copilot finished work on behalf of lpcox August 3, 2026 15:25

Copilot AI requested a review from lpcox August 3, 2026 15:25

lpcox merged commit 25105e3 into main Aug 3, 2026
37 checks passed

lpcox deleted the log/githubhttp-rate-limit-66e211a5f22771ef branch August 3, 2026 16:32

Navigation Menu

Uh oh!

[log] Add debug logging to internal/githubhttp/rate_limit.go - #10586

[log] Add debug logging to internal/githubhttp/rate_limit.go#10586
lpcox merged 2 commits into
mainfrom
log/githubhttp-rate-limit-66e211a5f22771ef

github-actions Bot commented Aug 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lpcox commented Aug 3, 2026

Uh oh!

Copilot AI commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

github-actions Bot commented Aug 2, 2026

Summary

Changes

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lpcox commented Aug 3, 2026

Uh oh!

Copilot AI commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

🔒 mcpg Read-Only Stress — gVisor

Uh oh!

github-actions Bot commented Aug 3, 2026

🔒 mcpg Read-Only Stress — default AWF

Uh oh!

github-actions Bot commented Aug 3, 2026

🔒 mcpg Read-Only Stress — docker-sbx

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants