[eslint-refiner] ESLint Refiner — Daily Report 2026-07-19

[github-actions[bot]]

Overview

Reviewed the two newest, never-before-reviewed custom rules in eslint-factory and filed 3 grounded refinement issues. The rule inventory grew from 12 → 21 during the review gap since 2026-07-08, so memory was refreshed and 7 rules remain never-reviewed.

Key metrics

Metric	Value
Rules in index.ts	21
Rules reviewed ≥1×	14
Rules never reviewed	7
Rules reviewed this run	2 (newest)
Issues filed	3 (all grounded, 0 duplicates)

Issues filed

1. no-core-error-then-process-exit — autofix core.setFailed(msg); return; is not control-flow-equivalent to core.error(msg); process.exit(nonzero): return exits only the enclosing function, while process.exit aborts the process. Grounded in convert_gateway_config_shared.cjs value-returning helpers (requireEnvVar :45-52, loadGatewayContext :66-72) where the fix would return undefined and let callers continue with bad state. Detection is sound (3 real true-positives); the fix quality is the defect.
2. prefer-core-logging — rewriting console.error/console.warn (→ stderr) to core.error/core.warning (→ stdout ::error:: commands) corrupts the JSON-RPC channel of stdio MCP servers/transports that own stdout. Grounded: safe_outputs_mcp_server.cjs:101, mcp_scripts_mcp_server.cjs:87/105, mcp_http_transport.cjs:295 (+ HTTP variants). All are linted.
3. prefer-core-logging — multi-argument autofix joins args positionally, but core.* logging methods accept a single message string, so trailing args are silently dropped (and %s/%d specifiers are not interpolated). Grounded: mcp_http_transport.cjs:295 drops error; the rule's own test (prefer-core-logging.test.ts:180) canonizes the lossy output.

Method & grounding notes

• No live lint (no node_modules/dist, npm firewalled); findings grounded statically via ripgrep over non-test actions/setup/js/**/*.cjs (the lint config ignores only *.test.cjs) plus rule source and tests.
• Key fact: @actions/core logging emits workflow commands to stdout, which is why stderr-based console.error in stdio MCP servers is intentional and must not be mechanically rewritten.
• Dedupe: no open issues reference prefer-core-logging or no-core-error-then-process-exit. #45206 (open) tracks a different rule (no-github-request-interpolated-route).
• Continuity: state.json + history.jsonl updated; memory validated at the 12 KB ceiling (flagged for trimming next run).

Next actions

• Pick from the 7 never-reviewed rules next (e.g. no-throw-plain-object, no-core-exportvariable-non-string, require-return-after-core-setfailed), grounding before filing.
• On refinement of the two rules above: re-verify the convert_gateway_config_* sites (autofix gated) and mcp_http_transport.cjs:295 (no data-loss fix; console.error unregressed in MCP servers).

References:

• §29675916840

Generated by 🤖 ESLint Refiner · 312.3 AIC · ⌖ 12.9 AIC · ⊞ 4.6K · ◷

• expires on Jul 19, 2026, 10:22 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by ESLint Refiner.

A newer discussion is available at Discussion #46736.