[eslint-refiner] Daily ESLint Rule Refinement — 2026-07-20

[github-actions[bot]]

Overview

Daily refinement pass over the eslint-factory custom ESLint rules. Major change since last run (2026-07-08): the package grew 12 → 22 rules via a squash-commit that reset every rule file's git add-date to 2026-07-20 — the previous "newest-rule-first" cadence heuristic is now dead, so this pass diffed index.ts rules[] against the reviewed set instead. All 22 rules are now reviewed at least once.

Key metrics

Metric	Value
Rules registered	22
Never-reviewed rules this pass	10
Reviewed this run (subagent fan-out)	8
Skipped as already-tracked	2 (prefer-core-logging → #46643, no-core-error-then-process-exit → #46642, both filed by the Code-Quality miner)
Issues filed	3 (at cap)
Corpus violations (live)	0 — corpus is disciplined; all findings are latent/consistency gaps

Issues filed

1. no-github-request-interpolated-route — the rule's getOctokit source set is {github, actions} but the repo's actual factory is global.getOctokit(...) (setup_globals.cjs:56, used in 8+ files) plus globalState.getOctokit. Aliases of the dominant factory aren't recognized as Octokit clients, so an interpolated route on one would be silently unflagged. HIGH, grounded, latent.
2. core-method-resolve (shared helper → 3 core rules) — the resolver rejects non-Variable defs, so a function parameter carrying core (DI style: validate_context_variables.cjs coreArg.setFailed(...)) is never recognized as core, disabling require-return-after-core-setfailed / no-core-exportvariable-non-string / no-core-setoutput-non-string for that shape. MED, grounded, high-leverage.
3. require-mkdirsync-try-catch — omits the allowUnboundFsIdentifier: true option its sibling require-fs-sync-try-catch passes, so an unwrapped fs.mkdirSync(...) with an unresolved fs receiver is ignored while fs.readFileSync(...) is flagged. MED, consistency gap.

Unfiled backlog (recorded in repo-memory for next pass)

• no-exec-interpolated-command — only matches an object literally named exec, but the repo DI-passes exec as execApi (git_helpers.cjs, create_pull_request.cjs). Tests explicitly mark aliased-exec out-of-scope, so this is a design discussion, not an issue — and it's asymmetric with the sibling request rule that does resolve aliases.
• require-return-after-core-setfailed — findContinuationOutsideBlock never inspects a TryStatement.finalizer; setFailed as the last statement of a try/catch that has a finally runs cleanup in the failed state undetected. Ungrounded soundness gap.
• no-throw-plain-object — JSON-RPC exemption only accepts numeric-literal code; a named-constant code (throw { code: INVALID_PARAMS }) would be a false positive. Low, ungrounded.
• require-spawnsync-error-check — .error on the right of && is rejected (the || form is accepted), false-positiving a valid combined guard. Low.
• require-new-url-try-catch — exempts all static-string args, so new URL('rel/path') (throws at runtime) is unflagged, contradicting the rule's own message. Low.

no-core-exportvariable-non-string and no-throw-plain-object have zero grounded corpus defects — every exportVariable arg is a string and every throw {} is the exempt JSON-RPC shape.

Next actions

• Re-parse index.ts next run for any rules added beyond 22, and re-check whether [Code Quality] Fix no-core-error-then-process-exit autofix: return is not equivalent to process.exit #46642/[Code Quality] Fix prefer-core-logging: corrupts MCP stdio channel and drops multi-arg content #46643 landed fixes.
• Second-pass the unfiled backlog: attempt to ground exec-DI and setfailed-try/finally against live sites; consolidate the design-level ones into a discussion rather than issues.
• All refinement strategy + findings persisted to repo-memory (memory/eslint-refiner branch) for continuity.

Filed by ESLint Refiner. Dedup verified against open issues; the Code-Quality/Discussion-Task-Miner agents also file eslint-factory rule issues, so cross-agent dedup was applied.

Generated by 🤖 ESLint Refiner · 786.5 AIC · ⌖ 10.8 AIC · ⊞ 4.6K · ◷

• expires on Jul 20, 2026, 10:35 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by ESLint Refiner.

A newer discussion is available at Discussion #46995.