[daily-compiler-quality] Daily Compiler Code Quality Report - 2026-07-29

[github-actions[bot]]

🔍 Compiler Code Quality Analysis Report

Analysis Date: 2026-07-29
Files Analyzed: compiler_experiments.go, compiler_types.go, compiler_yaml_runtime_setup.go
Overall Status: ⚠️ Some files need attention

---

Executive Summary

Today's rotation covered three previously never-analyzed files, prioritized because they had no prior cache entry. compiler_experiments.go (738 lines) scored Good (75/100), backed by strong test coverage (0.84 test-to-source ratio) but weakened by a lack of error wrapping and an oversized 100-line parsing function. compiler_types.go (455 lines) scored Acceptable (73/100) — its functional-options pattern and consistent naming are solid, but its 50 exported methods are thinly tested (0.25 ratio) and hint the Compiler struct may be accumulating too many responsibilities.

The outlier is compiler_yaml_runtime_setup.go (434 lines), which scored Needs Work (58/100) — it has no corresponding _test.go file at all, and its most complex function (addCustomStepsWithRuntimeInsertion, 81 lines) handles multiple branching insertion strategies without dedicated coverage. This is the clearest actionable gap from today's run.

---

Files Analyzed Today

📁 Detailed File Analysis

1. compiler_experiments.go — Score: 75/100 ✅

Dimension	Score
Structure	18/25
Readability	15/20
Error Handling	12/20
Testing	18/20
Patterns	12/15
Total	75/100

Strengths: Comprehensive test coverage (622-line test file); clear separation of extraction/validation/generation helpers; good comment density (~18%).
Issues: File is 738 lines with a 100-line extractOneExperimentConfig; only 3 fmt.Errorf calls, none use %w; buildPushExperimentsStateJob (88 lines) mixes job construction with step generation.
Recommendations: Split into experiments_config.go (parsing/validation) and experiments_steps.go (job/step generation); adopt %w error wrapping; decompose extractOneExperimentConfig into field-specific parsers.

2. compiler_types.go — Score: 73/100 ⚠️

Dimension	Score
Structure	22/25
Readability	18/20
Error Handling	12/20
Testing	8/20
Patterns	13/15
Total	73/100

Strengths: Clean functional-options pattern (CompilerOption); consistent setter/getter naming across 50 methods; small single-purpose setters (mostly <10 lines).
Issues: Thin test coverage (112-line test for 455-line file, 50 exported methods); zero error wrapping despite being a core config surface; large setter surface suggests possible SRP violation on Compiler.
Recommendations: Add table-driven tests for setter/getter pairs and slug lock/unlock behavior; consider grouping related setters (e.g., action-pin config) into a sub-struct; add missing godoc.

3. compiler_yaml_runtime_setup.go — Score: 58/100 ❌

Dimension	Score
Structure	19/25
Readability	14/20
Error Handling	8/20
Testing	5/20
Patterns	12/15
Total	58/100

Strengths: Function names clearly map to pipeline stages (emit/generate/prepare); logical staging order mirrors the YAML generation pipeline.
Issues: No _test.go file exists for this file; addCustomStepsWithRuntimeInsertion (81 lines) has multiple untested branching insertion strategies; most functions have no error return, relying on silent warnings via sanitizeAndWarnCustomSteps.
Recommendations: Add compiler_yaml_runtime_setup_test.go covering custom-step insertion and ARC/DinD branches; split addCustomStepsWithRuntimeInsertion per insertion strategy; introduce explicit error returns instead of silent warnings.

---

Overall Statistics

Rating	Count
Good (75-89)	1
Acceptable (60-74)	1
Needs Work (40-59)	1

Average Score: 68.7/100 · Files meeting ≥75 threshold: 1/3

---

Top 3 Issues

1. compiler_yaml_runtime_setup.go has zero test coverage — highest-risk gap found today.
2. No error wrapping (%w) used across any of the three files despite non-trivial validation/parsing logic.
3. Oversized functions: extractOneExperimentConfig (100 lines) and addCustomStepsWithRuntimeInsertion (81 lines) both mix multiple concerns.

Top 3 Strengths

1. compiler_experiments.go has strong test-to-source ratio (0.84).
2. compiler_types.go's functional-options constructor pattern is idiomatic and consistent.
3. All three files use clear, descriptive naming that maps directly to pipeline stages.

Recommended Action

Priority: Create compiler_yaml_runtime_setup_test.go covering addCustomStepsWithRuntimeInsertion and the ARC/DinD redirect paths — this is the only file among today's rotation with zero test coverage. Estimated effort: 2-3 hours.

---

💾 Cache Memory Summary

Total Files Tracked: 24 · Files Analyzed Today: 3 · Files Never Yet Analyzed: ~30 (compiler_activation_, compiler_yaml_ helpers, compiler_workflow_*)

Next priority candidates (never analyzed, largest first): compiler_workflow_call.go (353 lines), compiler_activation_steps.go (373 lines), compiler_safe_output_jobs.go (384 lines), compiler_main_job_helpers.go (408 lines).

---

Report generated by Daily Compiler Quality Check workflow · Analysis powered by Serena MCP Server

Generated by 📊 Daily Compiler Quality Check · sonnet50 · 45.5 AIC · ⌖ 11 AIC · ⊞ 13.8K · ◷

• expires on Jul 29, 2026, 7:42 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Daily Compiler Quality Check.

A newer discussion is available at Discussion #49027.