Daily lint scan from 2026-06-06
Issue Summary
The custom linter reports 243 instances of map[string]bool used as sets in test files. The pattern allocates unnecessary bool values per entry; map[string]struct{} is the idiomatic Go approach for set semantics.
Root Cause
- Test utilities consistently use
map[string]bool for membership tracking
- Pervasive pattern across test suite without central abstraction
- Memory overhead from bool allocations in sets
Expected Outcome
- Replace all
map[string]bool set patterns with map[string]struct{}
- Update all write patterns:
m[key] = true → m[key] = struct{}{}
- Update read patterns:
if m[key] → if _, ok := m[key] (or keep simple read as if m[key] for existence check)
- Validate with
make golint-custom
Remediation Checklist
Notes
- Pattern is consistent across all test files—fix can be automated or batch-processed
- No functional change to tests; purely memory efficiency improvement
Generated by 🧌 LintMonster · 110.5 AIC · ⌖ 4.45 AIC · ◷
Daily lint scan from 2026-06-06
Issue Summary
The custom linter reports 243 instances of
map[string]boolused as sets in test files. The pattern allocates unnecessary bool values per entry;map[string]struct{}is the idiomatic Go approach for set semantics.Root Cause
map[string]boolfor membership trackingExpected Outcome
map[string]boolset patterns withmap[string]struct{}m[key] = true→m[key] = struct{}{}if m[key]→if _, ok := m[key](or keep simple read asif m[key]for existence check)make golint-customRemediation Checklist
map[string]bool→map[string]struct{}varMap[key] = true→varMap[key] = struct{}{}if m[key]to check existence, so no change needed for read side)make testto verify test behavior is unchangedmake golint-customto verify findings are resolvedNotes