Replace test set-style map[string]bool usage with map[string]struct{}#37257
Draft
Copilot wants to merge 4 commits into
Draft
Replace test set-style map[string]bool usage with map[string]struct{}#37257Copilot wants to merge 4 commits into
map[string]bool usage with map[string]struct{}#37257Copilot wants to merge 4 commits into
Conversation
7 tasks
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix set type usages from map[string]bool to map[string]struct{}
Replace test set-style Jun 6, 2026
map[string]bool usage with map[string]struct{}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily linting flagged widespread test-only set patterns implemented as
map[string]bool, which are non-idiomatic and allocate unnecessary values. This change converts the flagged set usages tomap[string]struct{}and updates related write/read patterns without changing test intent.Scope: test set patterns
map[string]booltomap[string]struct{}.m[k] = truetom[k] = struct{}{}.Membership checks and assertions
_, ok := m[k]) where direct boolean reads were used.assert.Contains/assert.NotContainsfor set membership checks).Compatibility where APIs still require
map[string]boolpkg/cli/engine_secrets.go(stringSetToBoolMap) and used it in affected tests that pass set data into bool-map APIs, keeping production behavior unchanged while allowing idiomatic set representation in test setup.