Skip to content

[lint-monster] function-length refactoring backlog snapshot (683 findings) #49700

Description

@github-actions

Summary

Current custom lint scan reports 683 shared largefunc findings under pkg/workflow and pkg/cli. Per lint-monster policy, these findings belong to one shared tracking topic: function-length refactoring.

Current authoritative count

  • pkg/workflow: 295 findings
  • pkg/cli: 388 findings
  • Shared topic total: 683 findings

Existing authoritative tracker

An open authoritative function-length tracker already exists: #49251. This snapshot issue records the latest count because this workflow run cannot call update_issue against that existing tracker in the current safe-output configuration. Future manual or issue-triggered updates should consolidate into #49251.

Representative diagnostics

  • pkg/workflow/awf_helpers.go:229BuildAWFCommand is 377 lines long
  • pkg/workflow/codex_engine.go:207GetExecutionSteps is 318 lines long
  • pkg/workflow/compiler_safe_outputs_job.go:269buildSafeOutputsHandlerOutputsAndActionSteps is 220 lines long
  • pkg/workflow/unified_prompt_step.go:266generateUnifiedPromptCreationStep is 259 lines long
  • pkg/cli/add_interactive_git.go:26createWorkflowPRAndConfigureSecret is 171 lines long
  • pkg/cli/audit_diff.go:67computeFirewallDiff is 144 lines long

Next slices to refactor

  • Slice 1: workflow engine and log parsers (pkg/workflow/*engine*.go, pkg/workflow/*logs*.go)
  • Slice 2: workflow config / compiler / safe-output builders (pkg/workflow/awf_*, pkg/workflow/compiler_*, pkg/workflow/safe_outputs_*, pkg/workflow/tools_parser.go)
  • Slice 3: CLI interactive / audit / entrypoint flows (pkg/cli/add_*, pkg/cli/audit_*, pkg/cli/access_log.go, pkg/cli/actions_build_command.go)

Remediation checklist

  • Keep changes scoped to the assigned lint slice only
  • Prefer minimal, targeted code edits and helper extraction over broad rewrites
  • Preserve behavior and existing tests
  • Validate with make golint-custom before handoff

Duplicate handling

  • No duplicate open function-length trackers were identified in the available search results.
  • No issues were closed in this run.

Generated by 🧌 LintMonster · gpt54 · 34.8 AIC · ⌖ 5.54 AIC · ⊞ 5.3K ·

  • expires on Aug 8, 2026, 7:47 PM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions