[Code Quality] Add dedicated unit test file for compiler_activation_steps.go

[github-actions]

Description

pkg/workflow/compiler_activation_steps.go (373 lines, 18 functions) has no dedicated _test.go file. It currently relies only on broader compiler integration tests for indirect coverage. This was flagged in the Daily Compiler Code Quality Report - 2026-08-02 with a score of 69/100 (below the 75-point quality threshold), citing weak error handling (only 1 wrapped error across 18 functions) and missing focused tests.

Suggested Changes

• Create pkg/workflow/compiler_activation_steps_test.go with focused unit tests for the exported/receiver functions in compiler_activation_steps.go, including:
  • addActivationReactionStep
  • addActivationSecretValidationStep
  • addActivationOAuthTokenCheckStep
  • addActivationCrossRepoGuidanceStep
  • addActivationRepositoryAndOutputSteps (returns error)
  • addActivationCheckoutAndBaseRestoreStep
  • addActivationLockFileStep
  • addActivationVersionCheckStep
  • addActivationSkillInstallSteps (returns error)
  • addActivationTextOutputStep (returns error)
  • computeActivationSanitizationDomains (returns error)
  • addActivationStatusCommentStep (returns error)
  • addActivationSafeOutputMessagesEnv (returns error)
  • addActivationIssueLockStep
  • ensureActivationCommentOutputs
• Where a function returns error, add both success-path and error-path test cases so error handling is exercised directly rather than only via integration tests.

Files Affected

• pkg/workflow/compiler_activation_steps.go (no direct changes needed)
• pkg/workflow/compiler_activation_steps_test.go (new file)

Success Criteria

• New test file exists with coverage for all functions listed above.
• go test ./pkg/workflow/... -run ActivationSteps (or equivalent) passes.
• All existing tests continue to pass.

Source

Extracted from Daily Compiler Code Quality Report - 2026-08-02

Priority

Medium - improves maintainability and test coverage, not blocking.

🔍 Task mining by Discussion Task Miner - Code Quality Improvement Agent · auto · 51.6 AIC · ⌖ 11.4 AIC · ⊞ 10.3K · ◷

• expires on Aug 2, 2026, 11:41 PM UTC-08:00