Step Name Alignment Issues
Found in: pkg/workflow/notify_comment.go (line 124) -> compiled into all .lock.yml files using safe-outputs
Summary
One compiler-generated step name uses lowercase safe outputs while every sibling Safe-Outputs-related step name in the same job consistently capitalizes the term as a product name (Title Case). This affects roughly 270 step occurrences across the workflow fleet.
Issues Identified
1. [High Priority] Capitalization Inconsistency: "Download safe outputs items manifest"
Source: pkg/workflow/notify_comment.go:124
Current step name:
Download safe outputs items manifest
Issue:
This step uses lowercase safe outputs, but every other Safe-Outputs step generated for the same job capitalizes the term:
| Current (inconsistent) |
Source |
Sibling steps (consistent) |
Download safe outputs items manifest |
notify_comment.go:124 |
Generate Safe Outputs Config (mcp_setup_safe_outputs.go:27) |
|
|
Generate Safe Outputs Tools (mcp_setup_safe_outputs.go:85) |
|
|
Copy Safe Outputs (compiler_yaml_step_lifecycle.go:246) |
|
|
Process Safe Outputs (compiler_safe_outputs_steps.go:98) |
|
|
Upload Safe Outputs Items (compiler_safe_outputs_job.go:946) |
This is not a duplicate of previously-closed issue #20502 (which flagged a now-renamed Upload safe output items manifest step, singular "output"/"Upload" verb - that exact string no longer exists in the codebase). The current step uses "outputs" (plural) and "Download", and was left with lowercase casing when the manifest-download step was introduced.
Suggested improvement:
Download safe outputs items manifest -> Download Safe Outputs Items Manifest
Agentic Task Description
- Edit
pkg/workflow/notify_comment.go:124: change " - name: Download safe outputs items manifest\n" to " - name: Download Safe Outputs Items Manifest\n"
- Update the corresponding assertion in
pkg/workflow/notify_comment_test.go (around lines 1319 and 1330) which checks for the literal string Download safe outputs items manifest
- Recompile affected workflows (
make recompile, or gh aw compile for individual .md files) so all ~270 .lock.yml occurrences pick up the change
- Run
go test ./pkg/workflow/... to confirm the updated assertions pass
Related Files
- Source:
pkg/workflow/notify_comment.go
- Test:
pkg/workflow/notify_comment_test.go
- Sibling implementations:
pkg/workflow/mcp_setup_safe_outputs.go, pkg/workflow/compiler_yaml_step_lifecycle.go, pkg/workflow/compiler_safe_outputs_steps.go, pkg/workflow/compiler_safe_outputs_job.go
- Project glossary:
docs/src/content/docs/reference/glossary.md
Priority
This issue is High Priority - a single-line fix in shared compiler code resolves a naming inconsistency present in roughly 270 step occurrences across the workflow fleet.
AI generated by Step Name Alignment for daily maintenance
Generated by 📋 Step Name Alignment · agent · 102.3 AIC · ⌖ 32.7 AIC · ⊞ 10.1K · ◷
Step Name Alignment Issues
Found in:
pkg/workflow/notify_comment.go(line 124) -> compiled into all.lock.ymlfiles usingsafe-outputsSummary
One compiler-generated step name uses lowercase
safe outputswhile every sibling Safe-Outputs-related step name in the same job consistently capitalizes the term as a product name (Title Case). This affects roughly 270 step occurrences across the workflow fleet.Issues Identified
1. [High Priority] Capitalization Inconsistency: "Download safe outputs items manifest"
Source:
pkg/workflow/notify_comment.go:124Current step name:
Download safe outputs items manifestIssue:
This step uses lowercase
safe outputs, but every other Safe-Outputs step generated for the same job capitalizes the term:Download safe outputs items manifestnotify_comment.go:124Generate Safe Outputs Config(mcp_setup_safe_outputs.go:27)Generate Safe Outputs Tools(mcp_setup_safe_outputs.go:85)Copy Safe Outputs(compiler_yaml_step_lifecycle.go:246)Process Safe Outputs(compiler_safe_outputs_steps.go:98)Upload Safe Outputs Items(compiler_safe_outputs_job.go:946)This is not a duplicate of previously-closed issue #20502 (which flagged a now-renamed
Upload safe output items manifeststep, singular "output"/"Upload" verb - that exact string no longer exists in the codebase). The current step uses "outputs" (plural) and "Download", and was left with lowercase casing when the manifest-download step was introduced.Suggested improvement:
Agentic Task Description
pkg/workflow/notify_comment.go:124: change" - name: Download safe outputs items manifest\n"to" - name: Download Safe Outputs Items Manifest\n"pkg/workflow/notify_comment_test.go(around lines 1319 and 1330) which checks for the literal stringDownload safe outputs items manifestmake recompile, orgh aw compilefor individual.mdfiles) so all ~270.lock.ymloccurrences pick up the changego test ./pkg/workflow/...to confirm the updated assertions passRelated Files
pkg/workflow/notify_comment.gopkg/workflow/notify_comment_test.gopkg/workflow/mcp_setup_safe_outputs.go,pkg/workflow/compiler_yaml_step_lifecycle.go,pkg/workflow/compiler_safe_outputs_steps.go,pkg/workflow/compiler_safe_outputs_job.godocs/src/content/docs/reference/glossary.mdPriority
This issue is High Priority - a single-line fix in shared compiler code resolves a naming inconsistency present in roughly 270 step occurrences across the workflow fleet.