[aw] PR Code Quality Reviewer failed

[github-actions]

Workflow Failure

Workflow: PR Code Quality Reviewer
Branch: copilot/deep-report-add-items-succeeded-failed-signal
Run: https://github.com/github/gh-aw/actions/runs/30943794959
Pull Request: #50371

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

{"type":"tool.execution_complete","timestamp":"2026-08-04T19:38:07.706Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"{\"additions\":146,\"body\":\"`safe_outputs` batches could persist many items but still appear as a flat failure when one item failed. This adds item-level status signals so consumers can distinguish partial success from total failure.\\n\\n- **Runtime outputs**\\n  - Emit `items_succeeded`, `items_failed`, and `status` from the `process_safe_outputs` step.\\n  - `status` is one of `success`, `partial_success`, or `failure`.\\n\\n- **Job-level signals**\\n  - Expose the new step outputs through the `safe_outputs` job as:\\n    - `process_safe_outputs_items_succeeded`\\n    - `process_safe_outputs_items_failed`\\n    - `process_safe_outputs_status`\\n\\n- **Step summary**\\n  - Include the same item counts and status in the Safe Output Processing Summary.\\n\\nExample output shape:\\n\\n```yaml\\nneeds.safe_outputs.outputs.process_safe_outputs_items_succeeded: \\\"10\\\"\\nneeds.safe_outputs.outputs.process_safe_outputs_items_failed: \\\"5\\\"\\nneeds.safe_outputs.outputs.process_safe_outputs_status: \\\"partial_success\\\"\\n```\\n\\n<!-- START COPILOT CODING AGENT SUFFIX -->\\n\\n- Fixes #50301\",\"changedFiles\":8,\"deletions\":13,\"files\":[{\"path\":\".github/skills/agentic-workflows/SKILL.md\",\"additions\":0,\"deletions\":1,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_handler_manager.cjs\",\"additions\":28,\"deletions\":12,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_handler_manager.test.cjs\",\"additions\":44,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_summary.cjs\",\"additions\":5,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_summary.test.cjs\",\"additions\":29,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_outputs_status.cjs\",\"additions\":31,\"deletions\":0,\"changeType\":\"ADDED\"},{\"path\":\"pkg/workflow/compiler_safe_outputs_job.go\",\"additions\":3,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/workflow/compiler_safe_outputs_job_test.go\",\"additions\":6,\"deletions\":0,\"changeType\":\"MODIFIED\"}],\"headRefName\":\"copilot/deep-report-add-items-succeeded-failed-signal\",\"headRefOid\":\"5d6b8761e4329eb9e156e031e7e48be205ed1e4c\",\"number\":50371,\"title\":\"Expose safe output partial-batch status counts\"}\n---\n325 /tmp/gh-aw/agent/pr-diff.patch\n---\n[]\n<shellId: 6 completed with exit code 0>","detailedContent":"{\"additions\":146,\"body\":\"`safe_outputs` batches could persist many items but still appear as a flat failure when one item failed. This adds item-level status signals so consumers can distinguish partial success from total failure.\\n\\n- **Runtime outputs**\\n  - Emit `items_succeeded`, `items_failed`, and `status` from the `process_safe_outputs` step.\\n  - `status` is one of `success`, `partial_success`, or `failure`.\\n\\n- **Job-level signals**\\n  - Expose the new step outputs through the `safe_outputs` job as:\\n    - `process_safe_outputs_items_succeeded`\\n    - `process_safe_outputs_items_failed`\\n    - `process_safe_outputs_status`\\n\\n- **Step summary**\\n  - Include the same item counts and status in the Safe Output Processing Summary.\\n\\nExample output shape:\\n\\n```yaml\\nneeds.safe_outputs.outputs.process_safe_outputs_items_succeeded: \\\"10\\\"\\nneeds.safe_outputs.outputs.process_safe_outputs_items_failed: \\\"5\\\"\\nneeds.safe_outputs.outputs.process_safe_outputs_status: \\\"partial_success\\\"\\n```\\n\\n<!-- START COPILOT CODING AGENT SUFFIX -->\\n\\n- Fixes #50301\",\"changedFiles\":8,\"deletions\":13,\"files\":[{\"path\":\".github/skills/agentic-workflows/SKILL.md\",\"additions\":0,\"deletions\":1,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_handler_manager.cjs\",\"additions\":28,\"deletions\":12,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_handler_manager.test.cjs\",\"additions\":44,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_summary.cjs\",\"additions\":5,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_output_summary.test.cjs\",\"additions\":29,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"actions/setup/js/safe_outputs_status.cjs\",\"additions\":31,\"deletions\":0,\"changeType\":\"ADDED\"},{\"path\":\"pkg/workflow/compiler_safe_outputs_job.go\",\"additions\":3,\"deletions\":0,\"changeType\":\"MODIFIED\"},{\"path\":\"pkg/workflow/compiler_safe_outputs_job_test.go\",\"additions\":6,\"deletions\":0,\"changeType\":\"MODIFIED\"}],\"headRefName\":\"copilot/deep-report-add-items-succeeded-failed-signal\",\"headRefOid\":\"5d6b8761e4329eb9e156e031e7e48be205ed1e4c\",\"number\":50371,\"title\":\"Expose safe output partial-batch status counts\"}\n---\n325 /tmp/gh-aw/agent/pr-diff.patch\n---\n[]\n<shellId: 6 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-04T19:38:10.245Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-04T19:38:10.247Z","data":{"toolName":"bash","mcpServerName":"","command":"cat /tmp/gh-aw/agent/pr-diff.patch"}}
{"type":"tool.execution_complete","timestamp":"2026-08-04T19:38:10.319Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"diff --git a/.github/skills/agentic-workflows/SKILL.md b/.github/skills/agentic-workflows/SKILL.md\nindex e9f1125c621..f11eaadd2e7 100644\n--- a/.github/skills/agentic-workflows/SKILL.md\n+++ b/.github/skills/agentic-workflows/SKILL.md\n@@ -98,6 +98,5 @@ After loading the matching workflow prompt or skill, follow it directly:\n - Choose workflow architecture and patterns: `.github/aw/patterns.md`\n - Optimize token usage and cost: `.github/aw/token-optimization.md`\n - Design long-running multi-agent research workflows: `.github/aw/multi-agent-research.md`\n-- Maintaining a repository, consuming backlog: `.githbub/aw/maintainer.md`\n \n When the task involves OTEL, OTLP, traces, observability backends, or telemetry-driven analysis, also read and follow `skills/otel-queries/SKILL.md` after loading the matching workflow prompt or skill.\ndiff --git a/actions/setup/js/safe_output_handler_manager.cjs b/actions/setup/js/safe_output_handler_manager.cjs\nindex 3164ca7ab1f..ca152ba02da 100644\n--- a/actions/setup/js/safe_output_handler_manager.cjs\n+++ b/actions/setup/js/safe_output_handler_manager.cjs\n@@ -12,6 +12,7 @@\n const { loadAgentOutput } = require(\"./load_agent_output.cjs\");\n const { getErrorMessage } = require(\"./error_helpers.cjs\");\n const { ERR_CONFIG, ERR_PARSE, ERR_VALIDATION } = require(\"./error_codes.cjs\");\n+const { computeSafeOutputsStatus, isFailedProcessingResult } = require(\"./safe_outputs_status.cjs\");\n const { hasUnresolvedTemporaryIds, replaceTemporaryIdReferences, replaceArtifactUrlReferences, normalizeTemporaryId } = require(\"./temporary_id.cjs\");\n const { generateMissingInfoSections } = require(\"./missing_info_formatter.cjs\");\n const { setCollectedMissings } = require(\"./missing_messages_helper.cjs\");\n@@ -657,16 +658,6 @@ function skipReviewResultsForPR(results, repo, prNumber, skipReason) {\n   }\n }\n \n-/**\n- * Determine whether a processing result is a non-skipped, non-deferred, non-cancelled failure.\n- *\n- * @param {{success?: boolean, deferred?: boolean, skipped?: boolean, cancelled?: boolean}|null|undefined} result\n- * @returns {boolean}\n- */\n-function isFailedProcessingResult(result) {\n-  return Boolean(result?.success === false && !result?.deferred && !result?.skipped && !result?.cancelled);\n-}\n-\n /** Types whose failures are surfaced as warnings rather than failing the safe_outputs job. */\n const REPORT_ONLY_FAILURE_TYPES = new Set([\"assign_to_agent\", \"upload_artifact\"]);\n \n@@ -697,6 +688,17 @@ function partitionFailureResults(results) {\n   return { fatalFailures, reportOnlyFailures };\n }\n \n+/**\n+ * Export item-level safe-output status as GitHub Actions outputs.\n+ *\n+ * @param {{itemsSucceeded: number, itemsFailed: number, status: string}} status\n+ */\n+function setSafeOutputsStatusOutputs(status) {\n+  core.setOutput(\"items_succeeded\", String(status.itemsSucceeded));\n+  core.setOutput(\"items_failed\", String(status.itemsFailed));\n+  core.setOutput(\"status\", status.status);\n+}\n+\n /**\n  * Process all messages from agent output in the order they appear\n  * Dispatches each message to the appropriate handler while maintaining shared state (temporary ID map)\n@@ -1459,6 +1461,7 @@ async function main() {\n   const isStaged = isStagedMode();\n   /** @type {string | null} */\n   let failedOutputsMessage = null;\n+  let statusOutputsSet = false;\n \n   try {\n     core.info(\"Safe Output Handler Manager starting...\");\n@@ -1483,6 +1486,8 @@ async function main() {\n       if (!isStaged) ensureManifestExists();\n       core.setOutput(\"temporary_id_map\", \"{}\");\n       core.setOutput(\"processed_count\", \"0\");\n+      setSafeOutputsStatusOutputs({ itemsSucceeded: 0, itemsFailed: 0, status: \"success\" });\n+      statusOutputsSet = true;\n       return;\n     }\n \n@@ -1515,6 +1520,8 @@ async function main() {\n       // Set empty outputs for downstream steps\n       core.setOutput(\"temporary_id_map\", \"{}\");\n       core.setOutput(\"processed_count\", \"0\");\n+      setSafeOutputsStatusOutputs({ itemsSucceeded: 0, itemsFailed: 0, status: \"success\" });\n+      statusOutputsSet = true;\n       return;\n     }\n \n@@ -1592,7 +1599,8 @@ async function main() {\n     await writeSafeOutputSummaries(processingResult.results, allMessages);\n \n     // Log summary\n-    const successCount = processingResult.results.filter(r => r.success).length;\n+    const safeOutputsStatus = computeSafeOutputsStatus(processingResult.results);\n+    const successCount = safeOutputsStatus.itemsSucceeded;\n     const { fatalFailures, reportOnlyFailures } = partitionFailureResults(processingResult.results);\n     const failureCount = fatalFailures.length;\n     const reportOnlyFailureCount = reportOnlyFailures.length;\n@@ -1605,8 +1613,9 @@ async function main() {\n \n     core.info(`\\n=== Processing Summary ===`);\n     core.info(`Total messages: ${processingResult.results.length}`);\n+    core.info(`Status: ${safeOutputsStatus.status}`);\n     core.info(`Successful: ${successCount}`);\n-    core.info(`Failed: ${failureCount}`);\n+    core.info(`Failed: ${safeOutputsStatus.itemsFailed}`);\n     if (reportOnlyFailureCount > 0) {\n       core.info(`Reported assignment failures: ${reportOnlyFailureCount}`);\n     }\n@@ -1671,6 +1680,8 @@ async function main() {\n \n     // Export processed count for consistency with project handler\n     core.setOutput(\"processed_count\", String(successCount));\n+    setSafeOutputsStatusOutputs(safeOutputsStatus);\n+    statusOutputsSet = true;\n \n     // Export assign_to_agent outputs when the handler was loaded\n     if (messageHandlers.has(\"assign_to_agent\")) {\n@@ -1748,6 +1759,9 @@ async function main() {\n     core.info(\"Safe Output Handler Manager completed\");\n   } catch (error) {\n     const handlerError = `${ERR_VALIDATION}: Handler manager failed: ${getErrorMessage(error)}`;\n+    if (!statusOutputsSet) {\n+      setSafeOutputsStatusOutputs({ itemsSucceeded: 0, itemsFailed: 0, status: \"failure\" });\n+    }\n     if (failedOutputsMessage !== null) {\n       core.setFailed(`${failedOutputsMessage}\\n${handlerError}`);\n       return;\n@@ -1780,4 +1794,6 @@ module.exports = {\n   isFailedProcessingResult,\n   isReportOnlyFailureResult,\n   partitionFailureResults,\n+  computeSafeOutputsStatus,\n+  setSafeOutputsStatusOutputs,\n };diff --git a/actions/setup/js/safe_output_handler_manager.test.cjs b/actions/setup/js/safe_output_handler_manager.test.cjs\nindex 3e138408451..cf32b6d1b53 100644\n--- a/actions/setup/js/safe_output_handler_manager.test.cjs\n+++ b/actions/setup/js/safe_output_handler_manager.test.cjs\n@@ -16,6 +16,8 @@ import {\n   isFailedProcessingResult,\n   isReportOnlyFailureResult,\n   partitionFailureResults,\n+  computeSafeOutputsStatus,\n+  setSafeOutputsStatusOutputs,\n } from \"./safe_output_handler_manager.cjs\";\n \n const require = createRequire(import.meta.url);\n@@ -205,6 +207,48 @@ describe(\"Safe Output Handler Manager\", () => {\n       expect(fatalFailures).toEqual([{ type: \"create_issue\", success: false, error: \"Validation failed\" }]);\n     });\n \n+    it(\"computes partial success item status from mixed successful and failed results\", () => {\n+      const status = computeSafeOutputsStatus([\n+        { type: \"create_issue\", success: true },\n+        { type: \"add_comment\", success: true },\n+        { type: \"create_discussion\", success: false, error: \"Validation failed\" },\n+        { type: \"noop\", success: false, skipped: true },\n+        { type: \"link_sub_issue\", success: false, deferred: true },\n+        { type: \"merge_pull_request\", success: false, cancelled: true },\n+      ]);\n+\n+      expect(status).toEqual({\n+        itemsSucceeded: 2,\n+        itemsFailed: 1,\n+        status: \"partial_success\",\n+      });\n+    });\n+\n+    it(\"computes failure item status when all active results failed\", () => {\n+      expect(\n+        computeSafeOutputsStatus([\n+          { type: \"create_issue\", success: false, error: \"Validation failed\" },\n+          { type: \"add_comment\", success: false, error: \"Validation failed\" },\n+        ])\n+      ).toEqual({\n+        itemsSucceeded: 0,\n+        itemsFailed: 2,\n+        status: \"failure\",\n+      });\n+    });\n+\n+    it(\"exports item status outputs\", () => {\n+      setSafeOutputsStatusOutputs({\n+        itemsSucceeded: 10,\n+        itemsFailed: 5,\n+        status: \"partial_success\",\n+      });\n+\n+      expect(core.setOutput).toHaveBeenCalledWith(\"items_succeeded\", \"10\");\n+      expect(core.setOutput).toHaveBeenCalledWith(\"items_failed\", \"5\");\n+      expect(core.setOutput).toHaveBeenCalledWith(\"status\", \"partial_success\");\n+    });\n+\n     it(\"keeps review cleanup failures fatal unless a handler marks them skipped\", () => {\n       const { fatalFailures, reportOnlyFailures } = partitionFailureResults([\n         { type: \"resolve_pull_request_review_thread\", success: false, error: \"wrong node type\" },diff --git a/actions/setup/js/safe_output_summary.cjs b/actions/setup/js/safe_output_summary.cjs\nindex 600c60db937..86c9b6ac657 100644\n--- a/actions/setup/js/safe_output_summary.cjs\n+++ b/actions/setup/js/safe_output_summary.cjs\n@@ -10,6 +10,7 @@\n \n const { displayFileContent } = require(\"./display_file_helpers.cjs\");\n const { getErrorMessage } = require(\"./error_helpers.cjs\");\n+const { computeSafeOutputsStatus } = require(\"./safe_outputs_status.cjs\");\n \n /**\n  * Generate a step summary for a single safe-output message\n@@ -196,6 +197,10 @@ async function writeSafeOutputSummaries(results, messages) {\n \n   let summaryContent = `## Safe Output Processing Summary\\n\\n`;\n   summaryContent += `Processed ${results.length} safe-output message(s).\\n\\n`;\n+  const status = computeSafeOutputsStatus(results);\n+  summaryContent += `Status: **${status.status}**\\n\\n`;\n+  summaryContent += `Items succeeded: **${status.itemsSucceeded}**\\n\\n`;\n+  summaryContent += `Items failed: **${status.itemsFailed}**\\n\\n`;\n \n   // Generate summary for each result\n   for (const result of results) {diff --git a/actions/setup/js/safe_output_summary.test.cjs b/actions/setup/js/safe_output_summary.test.cjs\nindex 5af93f6ab25..42dc5e0b3b1 100644\n--- a/actions/setup/js/safe_output_summary.test.cjs\n+++ b/actions/setup/js/safe_output_summary.test.cjs\n@@ -541,10 +541,39 @@ describe(\"safe_output_summary\", () => {\n       const summaryContent = mockCore.summary.addRaw.mock.calls[0][0];\n       expect(summaryContent).toContain(\"Safe Output Processing Summary\");\n       expect(summaryContent).toContain(\"Processed 2 safe-output message(s)\");\n+      expect(summaryContent).toContain(\"Status: **success**\");\n+      expect(summaryContent).toContain(\"Items succeeded: **2**\");\n+      expect(summaryContent).toContain(\"Items failed: **0**\");\n       expect(summaryContent).toContain(\"Create Issue\");\n       expect(summaryContent).toContain(\"Create Project\");\n     });\n \n+    it(\"should include partial success item counts in the summary\", async () => {\n+      const results = [\n+        {\n+          type: \"create_issue\",\n+          messageIndex: 0,\n+          success: true,\n+          result: { repo: \"owner/repo\", number: 123 },\n+        },\n+        {\n+          type: \"create_discussion\",\n+          messageIndex: 1,\n+          success: false,\n+          error: \"Validation failed\",\n+        },\n+      ];\n+\n+      const messages = [{ title: \"Issue 1\" }, { title: \"Discussion 1\" }];\n+\n+      await writeSafeOutputSummaries(results, messages);\n+\n+      const summaryContent = mockCore.summary.addRaw.mock.calls[0][0];\n+      expect(summaryContent).toContain(\"Status: **partial_success**\");\n+      expect(summaryContent).toContain(\"Items succeeded: **1**\");\n+      expect(summaryContent).toContain(\"Items failed: **1**\");\n+    });\n+\n     it(\"should skip results handled by standalone steps\", async () => {\n       const results = [\n         {diff --git a/actions/setup/js/safe_outputs_status.cjs b/actions/setup/js/safe_outputs_status.cjs\nnew file mode 100644\nindex 00000000000..ce2ca35567a\n--- /dev/null\n+++ b/actions/setup/js/safe_outputs_status.cjs\n@@ -0,0 +1,31 @@\n+// @ts-check\n+\n+/**\n+ * Determine whether a processing result is a non-skipped, non-deferred, non-cancelled failure.\n+ *\n+ * @param {{success?: boolean, deferred?: boolean, skipped?: boolean, cancelled?: boolean}|null|undefined} result\n+ * @returns {boolean}\n+ */\n+function isFailedProcessingResult(result) {\n+  return Boolean(result?.success === false && !result?.deferred && !result?.skipped && !result?.cancelled);\n+}\n+\n+/**\n+ * Compute item-level safe-output status for logs, step summary, and GitHub Actions outputs.\n+ *\n+ * @param {Array<{success?: boolean, deferred?: boolean, skipped?: boolean, cancelled?: boolean}>|null|undefined} results\n+ * @returns {{itemsSucceeded: number, itemsFailed: number, status: \"success\" | \"partial_success\" | \"failure\"}}\n+ */\n+function computeSafeOutputsStatus(results) {\n+  const safeResults = Array.isArray(results) ? results : [];\n+  const itemsSucceeded = safeResults.filter(r => r?.success).length;\n+  const itemsFailed = safeResults.filter(isFailedProcessingResult).length;\n+  const status = itemsFailed === 0 ? \"success\" : itemsSucceeded > 0 ? \"partial_success\" : \"failure\";\n+\n+  return { itemsSucceeded, itemsFailed, status };\n+}\n+\n+module.exports = {\n+  computeSafeOutputsStatus,\n+  isFailedProcessingResult,\n+};diff --git a/pkg/workflow/compiler_safe_outputs_job.go b/pkg/workflow/compiler_safe_outputs_job.go\nindex f1df94e1042..975f1dd37e2 100644\n--- a/pkg/workflow/compiler_safe_outputs_job.go\n+++ b/pkg/workflow/compiler_safe_outputs_job.go\n@@ -368,6 +368,9 @@ func (c *Compiler) buildSafeOutputsHandlerOutputsAndActionSteps(data *WorkflowDa\n \t\t// Add outputs from handler manager\n \t\toutputs[\"process_safe_outputs_temporary_id_map\"] = \"${{ steps.process_safe_outputs.outputs.temporary_id_map }}\"\n \t\toutputs[\"process_safe_outputs_processed_count\"] = \"${{ steps.process_safe_outputs.outputs.processed_count }}\"\n+\t\toutputs[\"process_safe_outputs_items_succeeded\"] = \"${{ steps.process_safe_outputs.outputs.items_succeeded }}\"\n+\t\toutputs[\"process_safe_outputs_items_failed\"] = \"${{ steps.process_safe_outputs.outputs.items_failed }}\"\n+\t\toutputs[\"process_safe_outputs_status\"] = \"${{ steps.process_safe_outputs.outputs.status }}\"\n \t\toutputs[\"create_discussion_errors\"] = \"${{ steps.process_safe_outputs.outputs.create_discussion_errors }}\"\n \t\toutputs[\"create_discussion_error_count\"] = \"${{ steps.process_safe_outputs.outputs.create_discussion_error_count }}\"\n \t\toutputs[\"code_push_failure_errors\"] = \"${{ steps.process_safe_outputs.outputs.code_push_failure_errors }}\"diff --git a/pkg/workflow/compiler_safe_outputs_job_test.go b/pkg/workflow/compiler_safe_outputs_job_test.go\nindex e5d9604d704..b14196d9c08 100644\n--- a/pkg/workflow/compiler_safe_outputs_job_test.go\n+++ b/pkg/workflow/compiler_safe_outputs_job_test.go\n@@ -929,9 +929,15 @@ func TestJobOutputs(t *testing.T) {\n \t// Handler manager outputs\n \tassert.Contains(t, job.Outputs, \"process_safe_outputs_temporary_id_map\")\n \tassert.Contains(t, job.Outputs, \"process_safe_outputs_processed_count\")\n+\tassert.Contains(t, job.Outputs, \"process_safe_outputs_items_succeeded\")\n+\tassert.Contains(t, job.Outputs, \"process_safe_outputs_items_failed\")\n+\tassert.Contains(t, job.Outputs, \"process_safe_outputs_status\")\n \n \t// Check output format\n \tassert.Contains(t, job.Outputs[\"process_safe_outputs_temporary_id_map\"], \"steps.process_safe_outputs.outputs\")\n+\tassert.Equal(t, \"${{ steps.process_safe_outputs.outputs.items_succeeded }}\", job.Outputs[\"process_safe_outputs_items_succeeded\"])\n+\tassert.Equal(t, \"${{ steps.process_safe_outputs.outputs.items_failed }}\", job.Outputs[\"process_safe_outputs_items_failed\"])\n+\tassert.Equal(t, \"${{ steps.process_safe_outputs.outputs.status }}\", job.Outputs[\"process_safe_outputs_status\"])\n }\n \n // TestJobDependencies tests that job dependencies are correctly set\n<shellId: 7 completed with exit code 0>","detailedContent":"diff --git a/.github/skills/agentic-workflows/SKILL.md b/.github/skills/agentic-workflows/SKILL.md\nindex e9f1125c621..f11eaadd2e7 100644\n--- a/.github/skills/agentic-workflows/SKILL.md\n+++ b/.github/skills/agentic-workflows/SKILL.md\n@@ -98,6 +98,5 @@ After loading the matching workflow prompt or skill, follow it directly:\n - Choose workflow architecture and patterns: `.github/aw/patterns.md`\n - Optimize token usage and cost: `.github/aw/token-optimization.md`\n - Design long-running multi-agent research workflows: `.github/aw/multi-agent-research.md`\n-- Maintaining a repository, consuming backlog: `.githbub/aw/maintainer.md`\n \n When the task involves OTEL, OTLP, traces, observability backends, or telemetry-driven analysis, also read and follow `skills/otel-queries/SKILL.md` after loading the matching workflow prompt or skill.\ndiff --git a/actions/setup/js/safe_output_handler_manager.cjs b/actions/setup/js/safe_output_handler_manager.cjs\nindex 3164ca7ab1f..ca152ba02da 100644\n--- a/actions/setup/js/safe_output_handler_manager.cjs\n+++ b/actions/setup/js/safe_output_handler_manager.cjs\n@@ -12,6 +12,7 @@\n const { loadAgentOutput } = require(\"./load_agent_output.cjs\");\n const { getErrorMessage } = require(\"./error_helpers.cjs\");\n const { ERR_CONFIG, ERR_PARSE, ERR_VALIDATION } = require(\"./error_codes.cjs\");\n+const { computeSafeOutputsStatus, isFailedProcessingResult } = require(\"./safe_outputs_status.cjs\");\n const { hasUnresolvedTemporaryIds, replaceTemporaryIdReferences, replaceArtifactUrlReferences, normalizeTemporaryId } = require(\"./temporary_id.cjs\");\n const { generateMissingInfoSections } = require(\"./missing_info_formatter.cjs\");\n const { setCollectedMissings } = require(\"./missing_messages_helper.cjs\");\n@@ -657,16 +658,6 @@ function skipReviewResultsForPR(results, repo, prNumber, skipReason) {\n   }\n }\n \n-/**\n- * Determine whether a processing result is a non-skipped, non-deferred, non-cancelled failure.\n- *\n- * @param {{success?: boolean, deferred?: boolean, skipped?: boolean, cancelled?: boolean}|null|undefined} result\n- * @returns {boolean}\n- */\n-function isFailedProcessingResult(result) {\n-  return Boolean(result?.success === false && !result?.deferred && !result?.skipped && !result?.cancelled);\n-}\n-\n /** Types whose failures are surfaced as warnings rather than failing the safe_outputs job. */\n const REPORT_ONLY_FAILURE_TYPES = new Set([\"assign_to_agent\", \"upload_artifact\"]);\n \n@@ -697,6 +688,17 @@ function partitionFailureResults(results) {\n   return { fatalFailures, reportOnlyFailures };\n }\n \n+/**\n+ * Export item-level safe-output status as GitHub Actions outputs.\n+ *\n+ * @param {{itemsSucceeded: number, itemsFailed: number, status: string}} status\n+ */\n+function setSafeOutputsStatusOutputs(status) {\n+  core.setOutput(\"items_succeeded\", String(status.itemsSucceeded));\n+  core.setOutput(\"items_failed\", String(status.itemsFailed));\n+  core.setOutput(\"status\", status.status);\n+}\n+\n /**\n  * Process all messages from agent output in the order they appear\n  * Dispatches each message to the appropriate handler while maintaining shared state (temporary ID map)\n@@ -1459,6 +1461,7 @@ async function main() {\n   const isStaged = isStagedMode();\n   /** @type {string | null} */\n   let failedOutputsMessage = null;\n+  let statusOutputsSet = false;\n \n   try {\n     core.info(\"Safe Output Handler Manager starting...\");\n@@ -1483,6 +1486,8 @@ async function main() {\n       if (!isStaged) ensureManifestExists();\n       core.setOutput(\"temporary_id_map\", \"{}\");\n       core.setOutput(\"processed_count\", \"0\");\n+      setSafeOutputsStatusOutputs({ itemsSucceeded: 0, itemsFailed: 0, status: \"success\" });\n+      statusOutputsSet = true;\n       return;\n     }\n \n@@ -1515,6 +1520,8 @@ async function main() {\n       // Set empty outputs for downstream steps\n       core.setOutput(\"temporary_id_map\", \"{}\");\n       core.setOutput(\"processed_count\", \"0\");\n+      setSafeOutputsStatusOutputs({ itemsSucceeded: 0, itemsFailed: 0, status: \"success\" });\n+      statusOutputsSet = true;\n       return;\n     }\n \n@@ -1592,7 +1599,8 @@ async function main() {\n     await writeSafeOutputSummaries(processingResult.results, allMessages);\n \n     // Log summary\n-    const successCount = processingResult.results.filter(r => r.success).length;\n+    const safeOutputsStatus = computeSafeOutputsStatus(processingResult.results);\n+    const successCount = safeOutputsStatus.itemsSucceeded;\n     const { fatalFailures, reportOnlyFailures } = partitionFailureResults(processingResult.results);\n     const failureCount = fatalFailures.length;\n     const reportOnlyFailureCount = reportOnlyFailures.length;\n@@ -1605,8 +1613,9 @@ async function main() {\n \n     core.info(`\\n=== Processing Summary ===`);\n     core.info(`Total messages: ${processingResult.results.length}`);\n+    core.info(`Status: ${safeOutputsStatus.status}`);\n     core.info(`Successful: ${successCount}`);\n-    core.info(`Failed: ${failureCount}`);\n+    core.info(`Failed: ${safeOutputsStatus.itemsFailed}`);\n     if (reportOnlyFailureCount > 0) {\n       core.info(`Reported assignment failures: ${reportOnlyFailureCount}`);\n     }\n@@ -1671,6 +1680,8 @@ async function main() {\n \n     // Export processed count for consistency with project handler\n     core.setOutput(\"processed_count\", String(successCount));\n+    setSafeOutputsStatusOutputs(safeOutputsStatus);\n+    statusOutputsSet = true;\n \n     // Export assign_to_agent outputs when the handler was loaded\n     if (messageHandlers.has(\"assign_to_agent\")) {\n@@ -1748,6 +1759,9 @@ async function main() {\n     core.info(\"Safe Output Handler Manager completed\");\n   } catch (error) {\n     const handlerError = `${ERR_VALIDATION}: Handler manager failed: ${getErrorMessage(error)}`;\n+    if (!statusOutputsSet) {\n+      setSafeOutputsStatusOutputs({ itemsSucceeded: 0, itemsFailed: 0, status: \"failure\" });\n+    }\n     if (failedOutputsMessage !== null) {\n       core.setFailed(`${failedOutputsMessage}\\n${handlerError}`);\n       return;\n@@ -1780,4 +1794,6 @@ module.exports = {\n   isFailedProcessingResult,\n   isReportOnlyFailureResult,\n   partitionFailureResults,\n+  computeSafeOutputsStatus,\n+  setSafeOutputsStatusOutputs,\n };diff --git a/actions/setup/js/safe_output_handler_manager.test.cjs b/actions/setup/js/safe_output_handler_manager.test.cjs\nindex 3e138408451..cf32b6d1b53 100644\n--- a/actions/setup/js/safe_output_handler_manager.test.cjs\n+++ b/actions/setup/js/safe_output_handler_manager.test.cjs\n@@ -16,6 +16,8 @@ import {\n   isFailedProcessingResult,\n   isReportOnlyFailureResult,\n   partitionFailureResults,\n+  computeSafeOutputsStatus,\n+  setSafeOutputsStatusOutputs,\n } from \"./safe_output_handler_manager.cjs\";\n \n const require = createRequire(import.meta.url);\n@@ -205,6 +207,48 @@ describe(\"Safe Output Handler Manager\", () => {\n       expect(fatalFailures).toEqual([{ type: \"create_issue\", success: false, error: \"Validation failed\" }]);\n     });\n \n+    it(\"computes partial success item status from mixed successful and failed results\", () => {\n+      const status = computeSafeOutputsStatus([\n+        { type: \"create_issue\", success: true },\n+        { type: \"add_comment\", success: true },\n+        { type: \"create_discussion\", success: false, error: \"Validation failed\" },\n+        { type: \"noop\", success: false, skipped: true },\n+        { type: \"link_sub_issue\", success: false, deferred: true },\n+        { type: \"merge_pull_request\", success: false, cancelled: true },\n+      ]);\n+\n+      expect(status).toEqual({\n+        itemsSucceeded: 2,\n+        itemsFailed: 1,\n+        status: \"partial_success\",\n+      });\n+    });\n+\n+    it(\"computes failure item status when all active results failed\", () => {\n+      expect(\n+        computeSafeOutputsStatus([\n+          { type: \"create_issue\", success: false, error: \"Validation failed\" },\n+          { type: \"add_comment\", success: false, error: \"Validation failed\" },\n+        ])\n+      ).toEqual({\n+        itemsSucceeded: 0,\n+        itemsFailed: 2,\n+        status: \"failure\",\n+      });\n+    });\n+\n+    it(\"exports item status outputs\", () => {\n+      setSafeOutputsStatusOutputs({\n+        itemsSucceeded: 10,\n+        itemsFailed: 5,\n+        status: \"partial_success\",\n+      });\n+\n+      expect(core.setOutput).toHaveBeenCalledWith(\"items_succeeded\", \"10\");\n+      expect(core.setOutput).toHaveBeenCalledWith(\"items_failed\", \"5\");\n+      expect(core.setOutput).toHaveBeenCalledWith(\"status\", \"partial_success\");\n+    });\n+\n     it(\"keeps review cleanup failures fatal unless a handler marks them skipped\", () => {\n       const { fatalFailures, reportOnlyFailures } = partitionFailureResults([\n         { type: \"resolve_pull_request_review_thread\", success: false, error: \"wrong node type\" },diff --git a/actions/setup/js/safe_output_summary.cjs b/actions/setup/js/safe_output_summary.cjs\nindex 600c60db937..86c9b6ac657 100644\n--- a/actions/setup/js/safe_output_summary.cjs\n+++ b/actions/setup/js/safe_output_summary.cjs\n@@ -10,6 +10,7 @@\n \n const { displayFileContent } = require(\"./display_file_helpers.cjs\");\n const { getErrorMessage } = require(\"./error_helpers.cjs\");\n+const { computeSafeOutputsStatus } = require(\"./safe_outputs_status.cjs\");\n \n /**\n  * Generate a step summary for a single safe-output message\n@@ -196,6 +197,10 @@ async function writeSafeOutputSummaries(results, messages) {\n \n   let summaryContent = `## Safe Output Processing Summary\\n\\n`;\n   summaryContent += `Processed ${results.length} safe-output message(s).\\n\\n`;\n+  const status = computeSafeOutputsStatus(results);\n+  summaryContent += `Status: **${status.status}**\\n\\n`;\n+  summaryContent += `Items succeeded: **${status.itemsSucceeded}**\\n\\n`;\n+  summaryContent += `Items failed: **${status.itemsFailed}**\\n\\n`;\n \n   // Generate summary for each result\n   for (const result of results) {diff --git a/actions/setup/js/safe_output_summary.test.cjs b/actions/setup/js/safe_output_summary.test.cjs\nindex 5af93f6ab25..42dc5e0b3b1 100644\n--- a/actions/setup/js/safe_output_summary.test.cjs\n+++ b/actions/setup/js/safe_output_summary.test.cjs\n@@ -541,10 +541,39 @@ describe(\"safe_output_summary\", () => {\n       const summaryContent = mockCore.summary.addRaw.mock.calls[0][0];\n       expect(summaryContent).toContain(\"Safe Output Processing Summary\");\n       expect(summaryContent).toContain(\"Processed 2 safe-output message(s)\");\n+      expect(summaryContent).toContain(\"Status: **success**\");\n+      expect(summaryContent).toContain(\"Items succeeded: **2**\");\n+      expect(summaryContent).toContain(\"Items failed: **0**\");\n       expect(summaryContent).toContain(\"Create Issue\");\n       expect(summaryContent).toContain(\"Create Project\");\n     });\n \n+    it(\"should include partial success item counts in the summary\", async () => {\n+      const results = [\n+        {\n+          type: \"create_issue\",\n+          messageIndex: 0,\n+          success: true,\n+          result: { repo: \"owner/repo\", number: 123 },\n+        },\n+        {\n+          type: \"create_discussion\",\n+          messageIndex: 1,\n+          success: false,\n+          error: \"Validation failed\",\n+        },\n+      ];\n+\n+      const messages = [{ title: \"Issue 1\" }, { title: \"Discussion 1\" }];\n+\n+      await writeSafeOutputSummaries(results, messages);\n+\n+      const summaryContent = mockCore.summary.addRaw.mock.calls[0][0];\n+      expect(summaryContent).toContain(\"Status: **partial_success**\");\n+      expect(summaryContent).toContain(\"Items succeeded: **1**\");\n+      expect(summaryContent).toContain(\"Items failed: **1**\");\n+    });\n+\n     it(\"should skip results handled by standalone steps\", async () => {\n       const results = [\n         {diff --git a/actions/setup/js/safe_outputs_status.cjs b/actions/setup/js/safe_outputs_status.cjs\nnew file mode 100644\nindex 00000000000..ce2ca35567a\n--- /dev/null\n+++ b/actions/setup/js/safe_outputs_status.cjs\n@@ -0,0 +1,31 @@\n+// @ts-check\n+\n+/**\n+ * Determine whether a processing result is a non-skipped, non-deferred, non-cancelled failure.\n+ *\n+ * @param {{success?: boolean, deferred?: boolean, skipped?: boolean, cancelled?: boolean}|null|undefined} result\n+ * @returns {boolean}\n+ */\n+function isFailedProcessingResult(result) {\n+  return Boolean(result?.success === false && !result?.deferred && !result?.skipped && !result?.cancelled);\n+}\n+\n+/**\n+ * Compute item-level safe-output status for logs, step summary, and GitHub Actions outputs.\n+ *\n+ * @param {Array<{success?: boolean, deferred?: boolean, skipped?: boolean, cancelled?: boolean}>|null|undefined} results\n+ * @returns {{itemsSucceeded: number, itemsFailed: number, status: \"success\" | \"partial_success\" | \"failure\"}}\n+ */\n+function computeSafeOutputsStatus(results) {\n+  const safeResults = Array.isArray(results) ? results : [];\n+  const itemsSucceeded = safeResults.filter(r => r?.success).length;\n+  const itemsFailed = safeResults.filter(isFailedProcessingResult).length;\n+  const status = itemsFailed === 0 ? \"success\" : itemsSucceeded > 0 ? \"partial_success\" : \"failure\";\n+\n+  return { itemsSucceeded, itemsFailed, status };\n+}\n+\n+module.exports = {\n+  computeSafeOutputsStatus,\n+  isFailedProcessingResult,\n+};diff --git a/pkg/workflow/compiler_safe_outputs_job.go b/pkg/workflow/compiler_safe_outputs_job.go\nindex f1df94e1042..975f1dd37e2 100644\n--- a/pkg/workflow/compiler_safe_outputs_job.go\n+++ b/pkg/workflow/compiler_safe_outputs_job.go\n@@ -368,6 +368,9 @@ func (c *Compiler) buildSafeOutputsHandlerOutputsAndActionSteps(data *WorkflowDa\n \t\t// Add outputs from handler manager\n \t\toutputs[\"process_safe_outputs_temporary_id_map\"] = \"${{ steps.process_safe_outputs.outputs.temporary_id_map }}\"\n \t\toutputs[\"process_safe_outputs_processed_count\"] = \"${{ steps.process_safe_outputs.outputs.processed_count }}\"\n+\t\toutputs[\"process_safe_outputs_items_succeeded\"] = \"${{ steps.process_safe_outputs.outputs.items_succeeded }}\"\n+\t\toutputs[\"process_safe_outputs_items_failed\"] = \"${{ steps.process_safe_outputs.outputs.items_failed }}\"\n+\t\toutputs[\"process_safe_outputs_status\"] = \"${{ steps.process_safe_outputs.outputs.status }}\"\n \t\toutputs[\"create_discussion_errors\"] = \"${{ steps.process_safe_outputs.outputs.create_discussion_errors }}\"\n \t\toutputs[\"create_discussion_error_count\"] = \"${{ steps.process_safe_outputs.outputs.create_discussion_error_count }}\"\n \t\toutputs[\"code_push_failure_errors\"] = \"${{ steps.process_safe_outputs.outputs.code_push_failure_errors }}\"diff --git a/pkg/workflow/compiler_safe_outputs_job_test.go b/pkg/workflow/compiler_safe_outputs_job_test.go\nindex e5d9604d704..b14196d9c08 100644\n--- a/pkg/workflow/compiler_safe_outputs_job_test.go\n+++ b/pkg/workflow/compiler_safe_outputs_job_test.go\n@@ -929,9 +929,15 @@ func TestJobOutputs(t *testing.T) {\n \t// Handler manager outputs\n \tassert.Contains(t, job.Outputs, \"process_safe_outputs_temporary_id_map\")\n \tassert.Contains(t, job.Outputs, \"process_safe_outputs_processed_count\")\n+\tassert.Contains(t, job.Outputs, \"process_safe_outputs_items_succeeded\")\n+\tassert.Contains(t, job.Outputs, \"process_safe_outputs_items_failed\")\n+\tassert.Contains(t, job.Outputs, \"process_safe_outputs_status\")\n \n \t// Check output format\n \tassert.Contains(t, job.Outputs[\"process_safe_outputs_temporary_id_map\"], \"steps.process_safe_outputs.outputs\")\n+\tassert.Equal(t, \"${{ steps.process_safe_outputs.outputs.items_succeeded }}\", job.Outputs[\"process_safe_outputs_items_succeeded\"])\n+\tassert.Equal(t, \"${{ steps.process_safe_outputs.outputs.items_failed }}\", job.Outputs[\"process_safe_outputs_items_failed\"])\n+\tassert.Equal(t, \"${{ steps.process_safe_outputs.outputs.status }}\", job.Outputs[\"process_safe_outputs_status\"])\n }\n \n // TestJobDependencies tests that job dependencies are correctly set\n<shellId: 7 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-04T19:38:35.537Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-04T19:38:35.540Z","data":{"toolName":"task","mcpServerName":""}}
{"type":"subagent.started","timestamp":"2026-08-04T19:38:35.548Z","data":{"agentName":"general-purpose","agentDisplayName":"General Purpose Agent","toolCallId":"toolu_01JpjoXYQ31UpmSn3a5vf5mn"}}
{"type":"tool.execution_complete","timestamp":"2026-08-04T19:38:35.555Z","data":{"toolName":"task","mcpServerName":"","success":true,"result":{"content":"Agent started in background with agent_id: grumpy-coder-3. You'll be notified when it completes. Tell the user you're waiting and end your response, or continue unrelated work until notified. The agent supports multi-turn conversations — use write_agent to send follow-up messages.","detailedContent":"Prompt to general-purpose agent (grumpy-coder-3):\nYou are a highly critical, grumpy senior code reviewer doing first-pass issue mining on a GitHub PR diff. Be skeptical, look for correctness bugs, edge cases, race conditions, performance issues, and maintainability problems. ONLY look at changed lines in the diff below.\n\nPR: \"Expose safe output partial-batch status counts\" in github/gh-aw repo. It adds an `computeSafeOutputsStatus` function that classifies safe-output batch processing results as success/partial_success/failure based on item success/failure counts, exposes GitHub Actions outputs (items_succeeded, items_failed, status), and shows them in step summary and Go compiler job outputs.\n\nChanged files: .github/skills/agentic-workflows/SKILL.md, actions/setup/js/safe_output_handler_manager.cjs, actions/setup/js/safe_output_handler_manager.test.cjs, actions/setup/js/safe_output_summary.cjs, actions/setup/js/safe_output_summary.test.cjs, actions/setup/js/safe_outputs_status.cjs (NEW), pkg/workflow/compiler_safe_outputs_job.go, pkg/workflow/compiler_safe_outputs_job_test.go\n\nFull diff:\n```diff\n$(cat /tmp/gh-aw/agent/pr-diff.patch)\n```\n\nIMPORTANT CONTEXT: In the same file (safe_output_handler_manager.cjs), there is an existing function `partitionFailureResults` that splits failures into `fatalFailures` and `reportOnlyFailures` based on a `REPORT_ONLY_FAILURE_TYPES` set (types: \"assign_to_agent\", \"upload_artifact\") — these are failures that should NOT fail the overall job. The new `computeSafeOutputsStatus`/`isFailedProcessingResult` function does NOT exclude these report-only failure types when computing `itemsFailed` and `status`. Consider whether this creates an inconsistency where the new `status` output (and step summary) could report \"partial_success\" or \"failure\" even when the job actually succeeds (because only non-fatal report-only failures occurred, e.g. upload_artifact failing while everything else succeeds).\n\nAlso examine:\n- The catch-all error handler block: `if (!statusOutputsSet) { setSafeOutputsStatusOutputs({ itemsSucceeded: 0, itemsFailed: 0, status: \"failure\" }); }` — does hardcoding 0/0 lose useful partial info if processingResult.results existed before the exception?\n- Any duplicated logic between old `isFailedProcessingResult` (deleted from safe_output_handler_manager.cjs) and new module (safe_outputs_status.cjs) — check for consistency issues in re-export.\n- Test coverage adequacy: do new tests cover the report-only-failure-type interaction with computeSafeOutputsStatus? (They likely don't — check.)\n- Naming/type issues, magic strings (\"success\"/\"partial_success\"/\"failure\") repeated instead of using constants/enum.\n\nOutput STRICT JSONL, one finding per line, each line a JSON object with fields: `file`, `line` (best estimate of line number in the new file version from the diff hunk, or null), `severity` (critical/high/medium/low), `issue` (short description), `impact` (why it matters). Do not output anything except JSONL lines. If no issues found in a category, omit it — do not pad with low-value findings."}}}
[copilot-sdk-driver] [sdk-driver] error: Execution failed: Error: No model available. Check policy enablement under GitHub Settings > Copilot
{"type":"subagent.completed","timestamp":"2026-08-04T19:38:35.630Z","data":{"agentName":"general-purpose","toolCallId":"toolu_01JpjoXYQ31UpmSn3a5vf5mn"}}

Action Required

Assign this issue to an agent to debug and fix the issue.

Debug with any coding agent

Use this prompt with any coding agent (GitHub Copilot, Claude, Gemini, etc.):

Debug the agentic workflow failure using https://raw.githubusercontent.com/github/gh-aw/main/debug.md

The failed workflow run is at https://github.com/github/gh-aw/actions/runs/30943794959

Manually invoke the agent

Debug this workflow failure using your favorite Agent CLI and the agentic-workflows prompt.

• Start your agent
• Load the agentic-workflows skill from .github/skills/agentic-workflows/SKILL.md or https://github.com/github/gh-aw/blob/main/.github/skills/agentic-workflows/SKILL.md
• Type debug the agentic workflow pr-code-quality-reviewer failure in https://github.com/github/gh-aw/actions/runs/30943794959

Tip

Stop reporting this workflow as a failure

To stop a workflow from creating failure issues, set report-failure-as-issue: false in its frontmatter:

safe-outputs:
  report-failure-as-issue: false

Generated from PR Code Quality Reviewer · 50.5 AIC · ◷

• expires on Aug 5, 2026, 7:42 AM UTC

[github-actions]

Agent job 30943711376 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

{"type":"tool.execution_complete","timestamp":"2026-08-04T19:38:58.970Z","data":{"toolName":"view","mcpServerName":"","success":true,"result":{"content":"1. diff --git a/actions/setup/js/resolve_pr_review_thread.cjs b/actions/setup/js/resolve_pr_review_thread.cjs\n2. index ae508ee53c6..2b3b1612024 100644\n3. --- a/actions/setup/js/resolve_pr_review_thread.cjs\n4. +++ b/actions/setup/js/resolve_pr_review_thread.cjs\n5. @@ -24,8 +24,9 @@ const HANDLER_TYPE = \"resolve_pull_request_review_thread\";\n6.   * `@param` {string} threadId - Review thread node ID (e.g., 'PRRT_kwDOABCD...')\n7.   * `@returns` {Promise<\n8.   *   | {status: \"missing\"}\n9. - *   | {status: \"thread\", prNumber: number, repoNameWithOwner: string|null, isResolved: boolean}\n10. + *   | {status: \"thread\", threadId: string, prNumber: number, repoNameWithOwner: string|null, isResolved: boolean}\n11.   *   | {status: \"invalid_type\", nodeType: string}\n12. + *   | {status: \"comment_without_thread\"}\n13.   * >} Thread lookup result\n14.   */\n15.  async function getThreadPullRequestInfo(github, threadId) {\n16. @@ -34,6 +35,7 @@ async function getThreadPullRequestInfo(github, threadId) {\n17.        node(id: $threadId) {\n18.          __typename\n19.          ... on PullRequestReviewThread {\n20. +          id\n21.            isResolved\n22.            pullRequest {\n23.              number\n24. @@ -42,6 +44,18 @@ async function getThreadPullRequestInfo(github, threadId) {\n25.              }\n26.            }\n27.          }\n28. +        ... on PullRequestReviewComment {\n29. +          pullRequest {\n30. +            number\n31. +            repository {\n32. +              name\n33. +              nameWithOwner\n34. +              owner {\n35. +                login\n36. +              }\n37. +            }\n38. +          }\n39. +        }\n40.        }\n41.      }\n42.    `;\n43. @@ -52,6 +66,9 @@ async function getThreadPullRequestInfo(github, threadId) {\n44.    if (!threadNode) {\n45.      return { status: \"missing\" };\n46.    }\n47. +  if (threadNode.__typename === \"PullRequestReviewComment\") {\n48. +    return findThreadInfoForReviewComment(github, threadId, threadNode);\n49. +  }\n50.    if (threadNode.__typename !== \"PullRequestReviewThread\") {\n51.      return {\n52.        status: \"invalid_type\",\n53. @@ -62,12 +79,87 @@ async function getThreadPullRequestInfo(github, threadId) {\n54.  \n55.    return {\n56.      status: \"thread\",\n57. +    threadId: threadNode.id || threadId,\n58.      prNumber: pullRequest.number,\n59.      repoNameWithOwner: pullRequest.repository?.nameWithOwner ?? null,\n60.      isResolved: threadNode?.isResolved === true,\n61.    };\n62.  }\n63.  \n64. +/**\n65. + * Resolve a PullRequestReviewComment node ID to its containing review thread.\n66. + * `@param` {any} github - GitHub GraphQL instance\n67. + * `@param` {string} commentId - Pull request review comment node ID (e.g., 'PRRC_kwDOABCD...')\n68. + * `@param` {any} commentNode - PullRequestReviewComment node returned by the initial lookup\n69. + * `@returns` {Promise<\n70. + *   | {status: \"thread\", threadId: string, prNumber: number, repoNameWithOwner: string|null, isResolved: boolean}\n71. + *   | {status: \"comment_without_thread\"}\n72. + * >}\n73. + */\n74. +async function findThreadInfoForReviewComment(github, commentId, commentNode) {\n75. +  const pullRequest = commentNode.pullRequest;\n76. +  const repository = pullRequest?.repository;\n77. +  const prNumber = pullRequest?.number;\n78. +  const repoOwner = repository?.owner?.login;\n79. +  const repoName = repository?.name;\n80. +  const repoNameWithOwner = repository?.nameWithOwner ?? (repoOwner && repoName ? `${repoOwner}/${repoName}` : null);\n81. +\n82. +  if (!prNumber || !repoOwner || !repoName) {\n83. +    return { status: \"comment_without_thread\" };\n84. +  }\n85. +\n86. +  let cursor = null;\n87. +  do {\n88. +    const query = /* GraphQL */ `\n89. +      query ($owner: String!, $repo: String!, $number: Int!, $cursor: String) {\n90. +        repository(owner: $owner, name: $repo) {\n91. +          pullRequest(number: $number) {\n92. +            reviewThreads(first: 100, after: $cursor) {\n93. +              pageInfo {\n94. +                hasNextPage\n95. +                endCursor\n96. +              }\n97. +              nodes {\n98. +                id\n99. +                isResolved\n100. +                comments(first: 100) {\n101. +                  nodes {\n102. +                    id\n103. +                  }\n104. +                }\n105. +              }\n106. +            }\n107. +          }\n108. +        }\n109. +      }\n110. +    `;\n111. +\n112. +    const result = await github.graphql(query, {\n113. +      owner: repoOwner,\n114. +      repo: repoName,\n115. +      number: prNumber,\n116. +      cursor,\n117. +    });\n118. +    const reviewThreads = result?.repository?.pullRequest?.reviewThreads;\n119. +\n120. +    for (const thread of reviewThreads?.nodes || []) {\n121. +      if ((thread.comments?.nodes || []).some(comment => comment?.id === commentId)) {\n122. +        return {\n123. +          status: \"thread\",\n124. +          threadId: thread.id,\n125. +          prNumber,\n126. +          repoNameWithOwner,\n127. +          isResolved: thread.isResolved === true,\n128. +        };\n129. +      }\n130. +    }\n131. +\n132. +    cursor = reviewThreads?.pageInfo?.hasNextPage ? reviewThreads.pageInfo.endCursor : null;\n133. +  } while (cursor);\n134. +\n135. +  return { status: \"comment_without_thread\" };\n136. +}\n137. +\n138.  /**\n139.   * Resolve a pull request review thread using the GraphQL API.\n140.   * `@param` {any} github - GitHub GraphQL instance\n141. @@ -199,6 +291,13 @@ async function main(config = {}) {\n142.          };\n143.        }\n144.  \n145. +      if (threadInfo.status === \"comment_without_thread\") {\n146. +        return {\n147. +          success: false,\n148. +          error: `Could not find a PullRequestReviewThread containing review comment ${threadId}`,\n149. +        };\n150. +      }\n151. +\n152.        if (threadInfo.status !== \"thread\") {\n153.          return {\n154.            success: false,\n155. @@ -206,7 +305,10 @@ async function main(config = {}) {\n156.          };\n157.        }\n158.  \n159. -      const { prNumber: threadPRNumber, repoNameWithOwner: threadRepo, isResolved } = threadInfo;\n160. +      const { threadId: resolvedThreadId, prNumber: threadPRNumber, repoNameWithOwner: threadRepo, isResolved } = threadInfo;\n161. +      if (resolvedThreadId !== threadId) {\n162. +        core.info(`Resolved review comment ${threadId} to review thread ${resolvedThreadId}`);\n163. +      }\n164.  \n165.        // When the user explicitly configured target-repo or allowed-repos, validate the thread's\n166.        // repository using validateTargetRepo (supports wildcards like \"*\", \"org/*\").\n167. @@ -214,15 +316,15 @@ async function main(config = {}) {\n168.        if (hasExplicitTargetConfig) {\n169.          // Cross-repo mode: validate thread repo against configured repos (fail closed if missing)\n170.          if (!threadRepo) {\n171. -          core.warning(`Could not determine repository for thread ${threadId}`);\n172. +          core.warning(`Could not determine repository for thread ${resolvedThreadId}`);\n173.            return {\n174.              success: false,\n175. -            error: `Could not determine the repository for thread ${threadId}`,\n176. +            error: `Could not determine the repository for thread ${resolvedThreadId}`,\n177.            };\n178.          }\n179.          const repoValidation = validateTargetRepo(threadRepo, defaultTargetRepo, allowedRepos);\n180.          if (!repoValidation.valid) {\n181. -          core.warning(`Thread ${threadId} belongs to repo ${threadRepo}, which is not in the allowed repos`);\n182. +          core.warning(`Thread ${resolvedThreadId} belongs to repo ${threadRepo}, which is not in the allowed repos`);\n183.            return {\n184.              success: false,\n185.              error: repoValidation.error,\n186. @@ -239,7 +341,7 @@ async function main(config = {}) {\n187.              };\n188.            }\n189.            if (threadPRNumber !== triggeringPRNumber) {\n190. -            core.warning(`Thread ${threadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n191. +            core.warning(`Thread ${resolvedThreadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n192.              return {\n193.                success: false,\n194.                error: `Thread belongs to PR #${threadPRNumber}, but only threads on the triggering PR #${triggeringPRNumber} can be resolved`,\n195. @@ -256,7 +358,7 @@ async function main(config = {}) {\n196.              };\n197.            }\n198.            if (threadPRNumber !== targetPRNumber) {\n199. -            core.warning(`Thread ${threadId} belongs to PR #${threadPRNumber}, not target PR #${targetPRNumber}`);\n200. +            core.warning(`Thread ${resolvedThreadId} belongs to PR #${threadPRNumber}, not target PR #${targetPRNumber}`);\n201.              return {\n202.                success: false,\n203.                error: `Thread belongs to PR #${threadPRNumber}, but target is PR #${targetPRNumber}`,\n204. @@ -268,16 +370,16 @@ async function main(config = {}) {\n205.          // Default (legacy) mode: always validate thread repo against defaultTargetRepo to stay\n206.          // least-privilege, even when there is no triggering PR (e.g. schedule/workflow_dispatch).\n207.          if (!threadRepo) {\n208. -          core.warning(`Unable to determine repository for review thread ${threadId}; refusing to resolve in legacy mode`);\n209. +          core.warning(`Unable to determine repository for review thread ${resolvedThreadId}; refusing to resolve in legacy mode`);\n210.            return {\n211.              success: false,\n212. -            error: `Unable to determine repository for review thread ${threadId}`,\n213. +            error: `Unable to determine repository for review thread ${resolvedThreadId}`,\n214.            };\n215.          }\n216.  \n217.          const legacyRepoValidation = validateTargetRepo(threadRepo, defaultTargetRepo, allowedRepos);\n218.          if (!legacyRepoValidation.valid) {\n219. -          core.warning(`Thread ${threadId} repository ${threadRepo} is not allowed in legacy mode`);\n220. +          core.warning(`Thread ${resolvedThreadId} repository ${threadRepo} is not allowed in legacy mode`);\n221.            return {\n222.              success: false,\n223.              error: legacyRepoValidation.error || `Repository ${threadRepo} is not allowed for this handler`,\n224. @@ -288,9 +390,9 @@ async function main(config = {}) {\n225.          if (!triggeringPRNumber) {\n226.            // No triggering PR (e.g. schedule/workflow_dispatch trigger), but the thread has been\n227.            // resolved to a specific allowed repository via the API — allow the resolution to proceed\n228. -          core.info(`No triggering PR context; resolving thread ${threadId} via explicit thread_id (PR #${threadPRNumber} in ${threadRepo})`);\n229. +          core.info(`No triggering PR context; resolving thread ${resolvedThreadId} via explicit thread_id (PR #${threadPRNumber} in ${threadRepo})`);\n230.          } else if (threadPRNumber !== triggeringPRNumber) {\n231. -          core.warning(`Thread ${threadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n232. +          core.warning(`Thread ${resolvedThreadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n233.            return {\n234.              success: false,\n235.              error: `Thread belongs to PR #${threadPRNumber}, but only threads on the triggering PR #${triggeringPRNumber} can be resolved`,\n236. @@ -298,7 +400,7 @@ async function main(config = {}) {\n237.          }\n238.        }\n239.  \n240. -      core.info(`Resolving review thread: ${threadId} (PR #${threadPRNumber}${threadRepo ? \" in \" + threadRepo : \"\"})`);\n241. +      core.info(`Resolving review thread: ${resolvedThreadId} (PR #${threadPRNumber}${threadRepo ? \" in \" + threadRepo : \"\"})`);\n242.  \n243.        // Apply required-labels/required-title-prefix filter\n244.        const [threadOwner, threadRepoName] = (threadRepo || `${context.repo.owner}/${context.repo.repo}`).split(\"/\");\n245. @@ -307,10 +409,10 @@ async function main(config = {}) {\n246.        if (filterResult) return filterResult;\n247.  \n248.        if (isResolved) {\n249. -        core.info(`Review thread ${threadId} is already resolved; skipping`);\n250. +        core.info(`Review thread ${resolvedThreadId} is already resolved; skipping`);\n251.          return {\n252.            success: true,\n253. -          thread_id: threadId,\n254. +          thread_id: resolvedThreadId,\n255.            is_resolved: true,\n256.            skipped: true,\n257.          };\n258. @@ -318,12 +420,12 @@ async function main(config = {}) {\n259.  \n260.        // If in staged mode, preview without executing\n261.        if (isStaged) {\n262. -        logStagedPreviewInfo(`Would resolve review thread ${threadId}`);\n263. +        logStagedPreviewInfo(`Would resolve review thread ${resolvedThreadId}`);\n264.          return {\n265.            success: true,\n266.            staged: true,\n267.            previewInfo: {\n268. -            thread_id: threadId,\n269. +            thread_id: resolvedThreadId,\n270.              pr_number: threadPRNumber,\n271.            },\n272.          };\n273. @@ -331,11 +433,11 @@ async function main(config = {}) {\n274.  \n275.        let resolveResult;\n276.        try {\n277. -        resolveResult = await resolveReviewThreadAPI(githubClient, threadId);\n278. +        resolveResult = await resolveReviewThreadAPI(githubClient, resolvedThreadId);\n279.        } catch (error) {\n280.          if (isIntegrationAccessError(error)) {\n281.            const warningMessage =\n282. -            `Skipping resolve_pull_request_review_thread for ${threadId}: configuration mismatch ` +\n283. +            `Skipping resolve_pull_request_review_thread for ${resolvedThreadId}: configuration mismatch ` +\n284.              `(GitHub integration token cannot resolve this review thread: Resource not accessible by integration). ` +\n285.              `Use safe-outputs.resolve-pull-request-review-thread.github-token with a token that can resolve review threads.`;\n286.            core.warning(warningMessage);\n287. @@ -349,17 +451,17 @@ async function main(config = {}) {\n288.        }\n289.  \n290.        if (resolveResult.isResolved) {\n291. -        core.info(`Successfully resolved review thread: ${threadId}`);\n292. +        core.info(`Successfully resolved review thread: ${resolvedThreadId}`);\n293.          return {\n294.            success: true,\n295. -          thread_id: threadId,\n296. +          thread_id: resolvedThreadId,\n297.            is_resolved: true,\n298.          };\n299.        } else {\n300. -        core.error(`Failed to resolve review thread: ${threadId}`);\n301. +        core.error(`Failed to resolve review thread: ${resolvedThreadId}`);\n302.          return {\n303.            success: false,\n304. -          error: `Failed to resolve review thread: ${threadId}`,\n305. +          error: `Failed to resolve review thread: ${resolvedThreadId}`,\n306.          };\n307.        }\n308.      } catch (error) {\n309. diff --git a/actions/setup/js/resolve_pr_review_thread.test.cjs b/actions/setup/js/resolve_pr_review_thread.test.cjs\n310. index 78b4d560f29..35e73f719d4 100644\n311. --- a/actions/setup/js/resolve_pr_review_thread.test.cjs\n312. +++ b/actions/setup/js/resolve_pr_review_thread.test.cjs\n313. @@ -153,10 +153,72 @@ describe(\"resolve_pr_review_thread\", () => {\n314.      expect(mockGraphql).toHaveBeenCalledTimes(1);\n315.    });\n316.  \n317. -  it(\"should reject non-thread node IDs instead of treating them as resolved\", async () => {\n318. +  it(\"should resolve a review comment node ID by finding its parent thread\", async () => {\n319. +    mockGraphql.mockImplementation(query => {\n320. +      if (query.includes(\"resolveReviewThread\")) {\n321. +        return Promise.resolve({\n322. +          resolveReviewThread: {\n323. +            thread: {\n324. +              id: \"PRRT_kwDOThread123\",\n325. +              isResolved: true,\n326. +            },\n327. +          },\n328. +        });\n329. +      }\n330. +      if (query.includes(\"reviewThreads\")) {\n331. +        return Promise.resolve({\n332. +          repository: {\n333. +            pullRequest: {\n334. +              reviewThreads: {\n335. +                pageInfo: { hasNextPage: false, endCursor: null },\n336. +                nodes: [\n337. +                  {\n338. +                    id: \"PRRT_kwDOThread123\",\n339. +                    isResolved: false,\n340. +                    comments: {\n341. +                      nodes: [{ id: \"PRRC_kwDOComment123\" }],\n342. +                    },\n343. +                  },\n344. +                ],\n345. +              },\n346. +            },\n347. +          },\n348. +        });\n349. +      }\n350. +      return Promise.resolve({\n351. +        node: {\n352. +          __typename: \"PullRequestReviewComment\",\n353. +          pullRequest: {\n354. +            number: 42,\n355. +            repository: {\n356. +              name: \"test-repo\",\n357. +              nameWithOwner: \"test-owner/test-repo\",\n358. +              owner: { login: \"test-owner\" },\n359. +            },\n360. +          },\n361. +        },\n362. +      });\n363. +    });\n364. +\n365. +    const { main } = require(\"./resolve_pr_review_thread.cjs\");\n366. +    const freshHandler = await main({ max: 10 });\n367. +\n368. +    const result = await freshHandler({\n369. +      type: \"resolve_pull_request_review_thread\",\n370. +      thread_id: \"PRRC_kwDOComment123\",\n371. +    });\n372. +\n373. +    expect(result.success).toBe(true);\n374. +    expect(result.thread_id).toBe(\"PRRT_kwDOThread123\");\n375. +    expect(result.is_resolved).toBe(true);\n376. +    expect(mockGraphql).toHaveBeenCalledTimes(3);\n377. +    expect(mockGraphql).toHaveBeenCalledWith(expect.stringContaining(\"resolveReviewThread\"), expect.objectContaining({ threadId: \"PRRT_kwDOThread123\" }));\n378. +  });\n379. +\n380. +  it(\"should still reject non-thread and non-comment node IDs\", async () => {\n381.      mockGraphql.mockResolvedValue({\n382.        node: {\n383. -        __typename: \"PullRequestReviewComment\",\n384. +        __typename: \"Issue\",\n385.        },\n386.      });\n387.  \n388. @@ -165,12 +227,12 @@ describe(\"resolve_pr_review_thread\", () => {\n389.  \n390.      const result = await freshHandler({\n391.        type: \"resolve_pull_request_review_thread\",\n392. -      thread_id: \"PRRC_kwDOComment123\",\n393. +      thread_id: \"I_kwDOIssue123\",\n394.      });\n395.  \n396.      expect(result.success).toBe(false);\n397.      expect(result.error).toContain(\"PullRequestReviewThread\");\n398. -    expect(result.error).toContain(\"PullRequestReviewComment\");\n399. +    expect(result.error).toContain(\"Issue\");\n400.    });\n401.  \n402.    it(\"should still reject already resolved threads from a different PR\", async () => {\n403. ","detailedContent":"\ndiff --git a/tmp/gh-aw/agent/pr-diff.patch b/tmp/gh-aw/agent/pr-diff.patch\nindex 0000000..0000000 100644\n--- a/tmp/gh-aw/agent/pr-diff.patch\n+++ b/tmp/gh-aw/agent/pr-diff.patch\n@@ -1,403 +1,403 @@\n diff --git a/actions/setup/js/resolve_pr_review_thread.cjs b/actions/setup/js/resolve_pr_review_thread.cjs\n index ae508ee53c6..2b3b1612024 100644\n --- a/actions/setup/js/resolve_pr_review_thread.cjs\n +++ b/actions/setup/js/resolve_pr_review_thread.cjs\n @@ -24,8 +24,9 @@ const HANDLER_TYPE = \"resolve_pull_request_review_thread\";\n   * `@param` {string} threadId - Review thread node ID (e.g., 'PRRT_kwDOABCD...')\n   * `@returns` {Promise<\n   *   | {status: \"missing\"}\n - *   | {status: \"thread\", prNumber: number, repoNameWithOwner: string|null, isResolved: boolean}\n + *   | {status: \"thread\", threadId: string, prNumber: number, repoNameWithOwner: string|null, isResolved: boolean}\n   *   | {status: \"invalid_type\", nodeType: string}\n + *   | {status: \"comment_without_thread\"}\n   * >} Thread lookup result\n   */\n  async function getThreadPullRequestInfo(github, threadId) {\n @@ -34,6 +35,7 @@ async function getThreadPullRequestInfo(github, threadId) {\n        node(id: $threadId) {\n          __typename\n          ... on PullRequestReviewThread {\n +          id\n            isResolved\n            pullRequest {\n              number\n @@ -42,6 +44,18 @@ async function getThreadPullRequestInfo(github, threadId) {\n              }\n            }\n          }\n +        ... on PullRequestReviewComment {\n +          pullRequest {\n +            number\n +            repository {\n +              name\n +              nameWithOwner\n +              owner {\n +                login\n +              }\n +            }\n +          }\n +        }\n        }\n      }\n    `;\n @@ -52,6 +66,9 @@ async function getThreadPullRequestInfo(github, threadId) {\n    if (!threadNode) {\n      return { status: \"missing\" };\n    }\n +  if (threadNode.__typename === \"PullRequestReviewComment\") {\n +    return findThreadInfoForReviewComment(github, threadId, threadNode);\n +  }\n    if (threadNode.__typename !== \"PullRequestReviewThread\") {\n      return {\n        status: \"invalid_type\",\n @@ -62,12 +79,87 @@ async function getThreadPullRequestInfo(github, threadId) {\n  \n    return {\n      status: \"thread\",\n +    threadId: threadNode.id || threadId,\n      prNumber: pullRequest.number,\n      repoNameWithOwner: pullRequest.repository?.nameWithOwner ?? null,\n      isResolved: threadNode?.isResolved === true,\n    };\n  }\n  \n +/**\n + * Resolve a PullRequestReviewComment node ID to its containing review thread.\n + * `@param` {any} github - GitHub GraphQL instance\n + * `@param` {string} commentId - Pull request review comment node ID (e.g., 'PRRC_kwDOABCD...')\n + * `@param` {any} commentNode - PullRequestReviewComment node returned by the initial lookup\n + * `@returns` {Promise<\n + *   | {status: \"thread\", threadId: string, prNumber: number, repoNameWithOwner: string|null, isResolved: boolean}\n + *   | {status: \"comment_without_thread\"}\n + * >}\n + */\n +async function findThreadInfoForReviewComment(github, commentId, commentNode) {\n +  const pullRequest = commentNode.pullRequest;\n +  const repository = pullRequest?.repository;\n +  const prNumber = pullRequest?.number;\n +  const repoOwner = repository?.owner?.login;\n +  const repoName = repository?.name;\n +  const repoNameWithOwner = repository?.nameWithOwner ?? (repoOwner && repoName ? `${repoOwner}/${repoName}` : null);\n +\n +  if (!prNumber || !repoOwner || !repoName) {\n +    return { status: \"comment_without_thread\" };\n +  }\n +\n +  let cursor = null;\n +  do {\n +    const query = /* GraphQL */ `\n +      query ($owner: String!, $repo: String!, $number: Int!, $cursor: String) {\n +        repository(owner: $owner, name: $repo) {\n +          pullRequest(number: $number) {\n +            reviewThreads(first: 100, after: $cursor) {\n +              pageInfo {\n +                hasNextPage\n +                endCursor\n +              }\n +              nodes {\n +                id\n +                isResolved\n +                comments(first: 100) {\n +                  nodes {\n +                    id\n +                  }\n +                }\n +              }\n +            }\n +          }\n +        }\n +      }\n +    `;\n +\n +    const result = await github.graphql(query, {\n +      owner: repoOwner,\n +      repo: repoName,\n +      number: prNumber,\n +      cursor,\n +    });\n +    const reviewThreads = result?.repository?.pullRequest?.reviewThreads;\n +\n +    for (const thread of reviewThreads?.nodes || []) {\n +      if ((thread.comments?.nodes || []).some(comment => comment?.id === commentId)) {\n +        return {\n +          status: \"thread\",\n +          threadId: thread.id,\n +          prNumber,\n +          repoNameWithOwner,\n +          isResolved: thread.isResolved === true,\n +        };\n +      }\n +    }\n +\n +    cursor = reviewThreads?.pageInfo?.hasNextPage ? reviewThreads.pageInfo.endCursor : null;\n +  } while (cursor);\n +\n +  return { status: \"comment_without_thread\" };\n +}\n +\n  /**\n   * Resolve a pull request review thread using the GraphQL API.\n   * `@param` {any} github - GitHub GraphQL instance\n @@ -199,6 +291,13 @@ async function main(config = {}) {\n          };\n        }\n  \n +      if (threadInfo.status === \"comment_without_thread\") {\n +        return {\n +          success: false,\n +          error: `Could not find a PullRequestReviewThread containing review comment ${threadId}`,\n +        };\n +      }\n +\n        if (threadInfo.status !== \"thread\") {\n          return {\n            success: false,\n @@ -206,7 +305,10 @@ async function main(config = {}) {\n          };\n        }\n  \n -      const { prNumber: threadPRNumber, repoNameWithOwner: threadRepo, isResolved } = threadInfo;\n +      const { threadId: resolvedThreadId, prNumber: threadPRNumber, repoNameWithOwner: threadRepo, isResolved } = threadInfo;\n +      if (resolvedThreadId !== threadId) {\n +        core.info(`Resolved review comment ${threadId} to review thread ${resolvedThreadId}`);\n +      }\n  \n        // When the user explicitly configured target-repo or allowed-repos, validate the thread's\n        // repository using validateTargetRepo (supports wildcards like \"*\", \"org/*\").\n @@ -214,15 +316,15 @@ async function main(config = {}) {\n        if (hasExplicitTargetConfig) {\n          // Cross-repo mode: validate thread repo against configured repos (fail closed if missing)\n          if (!threadRepo) {\n -          core.warning(`Could not determine repository for thread ${threadId}`);\n +          core.warning(`Could not determine repository for thread ${resolvedThreadId}`);\n            return {\n              success: false,\n -            error: `Could not determine the repository for thread ${threadId}`,\n +            error: `Could not determine the repository for thread ${resolvedThreadId}`,\n            };\n          }\n          const repoValidation = validateTargetRepo(threadRepo, defaultTargetRepo, allowedRepos);\n          if (!repoValidation.valid) {\n -          core.warning(`Thread ${threadId} belongs to repo ${threadRepo}, which is not in the allowed repos`);\n +          core.warning(`Thread ${resolvedThreadId} belongs to repo ${threadRepo}, which is not in the allowed repos`);\n            return {\n              success: false,\n              error: repoValidation.error,\n @@ -239,7 +341,7 @@ async function main(config = {}) {\n              };\n            }\n            if (threadPRNumber !== triggeringPRNumber) {\n -            core.warning(`Thread ${threadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n +            core.warning(`Thread ${resolvedThreadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n              return {\n                success: false,\n                error: `Thread belongs to PR #${threadPRNumber}, but only threads on the triggering PR #${triggeringPRNumber} can be resolved`,\n @@ -256,7 +358,7 @@ async function main(config = {}) {\n              };\n            }\n            if (threadPRNumber !== targetPRNumber) {\n -            core.warning(`Thread ${threadId} belongs to PR #${threadPRNumber}, not target PR #${targetPRNumber}`);\n +            core.warning(`Thread ${resolvedThreadId} belongs to PR #${threadPRNumber}, not target PR #${targetPRNumber}`);\n              return {\n                success: false,\n                error: `Thread belongs to PR #${threadPRNumber}, but target is PR #${targetPRNumber}`,\n @@ -268,16 +370,16 @@ async function main(config = {}) {\n          // Default (legacy) mode: always validate thread repo against defaultTargetRepo to stay\n          // least-privilege, even when there is no triggering PR (e.g. schedule/workflow_dispatch).\n          if (!threadRepo) {\n -          core.warning(`Unable to determine repository for review thread ${threadId}; refusing to resolve in legacy mode`);\n +          core.warning(`Unable to determine repository for review thread ${resolvedThreadId}; refusing to resolve in legacy mode`);\n            return {\n              success: false,\n -            error: `Unable to determine repository for review thread ${threadId}`,\n +            error: `Unable to determine repository for review thread ${resolvedThreadId}`,\n            };\n          }\n  \n          const legacyRepoValidation = validateTargetRepo(threadRepo, defaultTargetRepo, allowedRepos);\n          if (!legacyRepoValidation.valid) {\n -          core.warning(`Thread ${threadId} repository ${threadRepo} is not allowed in legacy mode`);\n +          core.warning(`Thread ${resolvedThreadId} repository ${threadRepo} is not allowed in legacy mode`);\n            return {\n              success: false,\n              error: legacyRepoValidation.error || `Repository ${threadRepo} is not allowed for this handler`,\n @@ -288,9 +390,9 @@ async function main(config = {}) {\n          if (!triggeringPRNumber) {\n            // No triggering PR (e.g. schedule/workflow_dispatch trigger), but the thread has been\n            // resolved to a specific allowed repository via the API — allow the resolution to proceed\n -          core.info(`No triggering PR context; resolving thread ${threadId} via explicit thread_id (PR #${threadPRNumber} in ${threadRepo})`);\n +          core.info(`No triggering PR context; resolving thread ${resolvedThreadId} via explicit thread_id (PR #${threadPRNumber} in ${threadRepo})`);\n          } else if (threadPRNumber !== triggeringPRNumber) {\n -          core.warning(`Thread ${threadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n +          core.warning(`Thread ${resolvedThreadId} belongs to PR #${threadPRNumber}, not triggering PR #${triggeringPRNumber}`);\n            return {\n              success: false,\n              error: `Thread belongs to PR #${threadPRNumber}, but only threads on the triggering PR #${triggeringPRNumber} can be resolved`,\n @@ -298,7 +400,7 @@ async function main(config = {}) {\n          }\n        }\n  \n -      core.info(`Resolving review thread: ${threadId} (PR #${threadPRNumber}${threadRepo ? \" in \" + threadRepo : \"\"})`);\n +      core.info(`Resolving review thread: ${resolvedThreadId} (PR #${threadPRNumber}${threadRepo ? \" in \" + threadRepo : \"\"})`);\n  \n        // Apply required-labels/required-title-prefix filter\n        const [threadOwner, threadRepoName] = (threadRepo || `${context.repo.owner}/${context.repo.repo}`).split(\"/\");\n @@ -307,10 +409,10 @@ async function main(config = {}) {\n        if (filterResult) return filterResult;\n  \n        if (isResolved) {\n -        core.info(`Review thread ${threadId} is already resolved; skipping`);\n +        core.info(`Review thread ${resolvedThreadId} is already resolved; skipping`);\n          return {\n            success: true,\n -          thread_id: threadId,\n +          thread_id: resolvedThreadId,\n            is_resolved: true,\n            skipped: true,\n          };\n @@ -318,12 +420,12 @@ async function main(config = {}) {\n  \n        // If in staged mode, preview without executing\n        if (isStaged) {\n -        logStagedPreviewInfo(`Would resolve review thread ${threadId}`);\n +        logStagedPreviewInfo(`Would resolve review thread ${resolvedThreadId}`);\n          return {\n            success: true,\n            staged: true,\n            previewInfo: {\n -            thread_id: threadId,\n +            thread_id: resolvedThreadId,\n              pr_number: threadPRNumber,\n            },\n          };\n @@ -331,11 +433,11 @@ async function main(config = {}) {\n  \n        let resolveResult;\n        try {\n -        resolveResult = await resolveReviewThreadAPI(githubClient, threadId);\n +        resolveResult = await resolveReviewThreadAPI(githubClient, resolvedThreadId);\n        } catch (error) {\n          if (isIntegrationAccessError(error)) {\n            const warningMessage =\n -            `Skipping resolve_pull_request_review_thread for ${threadId}: configuration mismatch ` +\n +            `Skipping resolve_pull_request_review_thread for ${resolvedThreadId}: configuration mismatch ` +\n              `(GitHub integration token cannot resolve this review thread: Resource not accessible by integration). ` +\n              `Use safe-outputs.resolve-pull-request-review-thread.github-token with a token that can resolve review threads.`;\n            core.warning(warningMessage);\n @@ -349,17 +451,17 @@ async function main(config = {}) {\n        }\n  \n        if (resolveResult.isResolved) {\n -        core.info(`Successfully resolved review thread: ${threadId}`);\n +        core.info(`Successfully resolved review thread: ${resolvedThreadId}`);\n          return {\n            success: true,\n -          thread_id: threadId,\n +          thread_id: resolvedThreadId,\n            is_resolved: true,\n          };\n        } else {\n -        core.error(`Failed to resolve review thread: ${threadId}`);\n +        core.error(`Failed to resolve review thread: ${resolvedThreadId}`);\n          return {\n            success: false,\n -          error: `Failed to resolve review thread: ${threadId}`,\n +          error: `Failed to resolve review thread: ${resolvedThreadId}`,\n          };\n        }\n      } catch (error) {\n diff --git a/actions/setup/js/resolve_pr_review_thread.test.cjs b/actions/setup/js/resolve_pr_review_thread.test.cjs\n index 78b4d560f29..35e73f719d4 100644\n --- a/actions/setup/js/resolve_pr_review_thread.test.cjs\n +++ b/actions/setup/js/resolve_pr_review_thread.test.cjs\n @@ -153,10 +153,72 @@ describe(\"resolve_pr_review_thread\", () => {\n      expect(mockGraphql).toHaveBeenCalledTimes(1);\n    });\n  \n -  it(\"should reject non-thread node IDs instead of treating them as resolved\", async () => {\n +  it(\"should resolve a review comment node ID by finding its parent thread\", async () => {\n +    mockGraphql.mockImplementation(query => {\n +      if (query.includes(\"resolveReviewThread\")) {\n +        return Promise.resolve({\n +          resolveReviewThread: {\n +            thread: {\n +              id: \"PRRT_kwDOThread123\",\n +              isResolved: true,\n +            },\n +          },\n +        });\n +      }\n +      if (query.includes(\"reviewThreads\")) {\n +        return Promise.resolve({\n +          repository: {\n +            pullRequest: {\n +              reviewThreads: {\n +                pageInfo: { hasNextPage: false, endCursor: null },\n +                nodes: [\n +                  {\n +                    id: \"PRRT_kwDOThread123\",\n +                    isResolved: false,\n +                    comments: {\n +                      nodes: [{ id: \"PRRC_kwDOComment123\" }],\n +                    },\n +                  },\n +                ],\n +              },\n +            },\n +          },\n +        });\n +      }\n +      return Promise.resolve({\n +        node: {\n +          __typename: \"PullRequestReviewComment\",\n +          pullRequest: {\n +            number: 42,\n +            repository: {\n +              name: \"test-repo\",\n +              nameWithOwner: \"test-owner/test-repo\",\n +              owner: { login: \"test-owner\" },\n +            },\n +          },\n +        },\n +      });\n +    });\n +\n +    const { main } = require(\"./resolve_pr_review_thread.cjs\");\n +    const freshHandler = await main({ max: 10 });\n +\n +    const result = await freshHandler({\n +      type: \"resolve_pull_request_review_thread\",\n +      thread_id: \"PRRC_kwDOComment123\",\n +    });\n +\n +    expect(result.success).toBe(true);\n +    expect(result.thread_id).toBe(\"PRRT_kwDOThread123\");\n +    expect(result.is_resolved).toBe(true);\n +    expect(mockGraphql).toHaveBeenCalledTimes(3);\n +    expect(mockGraphql).toHaveBeenCalledWith(expect.stringContaining(\"resolveReviewThread\"), expect.objectContaining({ threadId: \"PRRT_kwDOThread123\" }));\n +  });\n +\n +  it(\"should still reject non-thread and non-comment node IDs\", async () => {\n      mockGraphql.mockResolvedValue({\n        node: {\n -        __typename: \"PullRequestReviewComment\",\n +        __typename: \"Issue\",\n        },\n      });\n  \n @@ -165,12 +227,12 @@ describe(\"resolve_pr_review_thread\", () => {\n  \n      const result = await freshHandler({\n        type: \"resolve_pull_request_review_thread\",\n -      thread_id: \"PRRC_kwDOComment123\",\n +      thread_id: \"I_kwDOIssue123\",\n      });\n  \n      expect(result.success).toBe(false);\n      expect(result.error).toContain(\"PullRequestReviewThread\");\n -    expect(result.error).toContain(\"PullRequestReviewComment\");\n +    expect(result.error).toContain(\"Issue\");\n    });\n  \n    it(\"should still reject already resolved threads from a different PR\", async () => {\n \n"}}}
{"type":"assistant.message","timestamp":"2026-08-04T19:39:07.639Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-04T19:39:07.641Z","data":{"toolName":"bash","mcpServerName":"","command":"grep -n \"async function main\\|for (const\\|thread_id\\|foreach\\|batch\\|items\" /home/runner/work/gh-aw/gh-aw/actions/setup/js/resolve_pr_review_thread.cjs | head -50"}}
{"type":"tool.execution_complete","timestamp":"2026-08-04T19:39:07.725Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"145:    for (const thread of reviewThreads?.nodes || []) {\n200:    for (const graphQLError of error.errors) {\n218:async function main(config = {}) {\n248:  // Track how many items we've processed for max limit\n273:      const threadId = item.thread_id;\n275:        core.warning('Missing or invalid required field \"thread_id\" in resolve message');\n278:          error: 'Missing or invalid required field \"thread_id\" - must be a non-empty string (GraphQL node ID)',\n288:          thread_id: threadId,\n304:          error: `thread_id must reference a PullRequestReviewThread node ID (PRRT_...); received ${threadInfo.nodeType} for ${threadId}`,\n393:          core.info(`No triggering PR context; resolving thread ${resolvedThreadId} via explicit thread_id (PR #${threadPRNumber} in ${threadRepo})`);\n415:          thread_id: resolvedThreadId,\n428:            thread_id: resolvedThreadId,\n457:          thread_id: resolvedThreadId,\n<shellId: 9 completed with exit code 0>","detailedContent":"145:    for (const thread of reviewThreads?.nodes || []) {\n200:    for (const graphQLError of error.errors) {\n218:async function main(config = {}) {\n248:  // Track how many items we've processed for max limit\n273:      const threadId = item.thread_id;\n275:        core.warning('Missing or invalid required field \"thread_id\" in resolve message');\n278:          error: 'Missing or invalid required field \"thread_id\" - must be a non-empty string (GraphQL node ID)',\n288:          thread_id: threadId,\n304:          error: `thread_id must reference a PullRequestReviewThread node ID (PRRT_...); received ${threadInfo.nodeType} for ${threadId}`,\n393:          core.info(`No triggering PR context; resolving thread ${resolvedThreadId} via explicit thread_id (PR #${threadPRNumber} in ${threadRepo})`);\n415:          thread_id: resolvedThreadId,\n428:            thread_id: resolvedThreadId,\n457:          thread_id: resolvedThreadId,\n<shellId: 9 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-04T19:39:29.089Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-04T19:39:29.091Z","data":{"toolName":"task","mcpServerName":""}}
{"type":"subagent.started","timestamp":"2026-08-04T19:39:29.100Z","data":{"agentName":"general-purpose","agentDisplayName":"General Purpose Agent","toolCallId":"toolu_016e11HASy4QkFV5KYVedxFg"}}
{"type":"tool.execution_complete","timestamp":"2026-08-04T19:39:29.107Z","data":{"toolName":"task","mcpServerName":"","success":true,"result":{"content":"Agent started in background with agent_id: grumpy-coder-3. You'll be notified when it completes. Tell the user you're waiting and end your response, or continue unrelated work until notified. The agent supports multi-turn conversations — use write_agent to send follow-up messages.","detailedContent":"Prompt to general-purpose agent (grumpy-coder-3):\nYou are a hyper-critical, grumpy senior code reviewer doing a first-pass issue-mining review of a PR diff. Do NOT be nice. Find every correctness risk, performance regression, maintainability debt, and weak engineering decision.\n\nPR: github/gh-aw #50349 \"Resolve PR review threads from review comment node IDs\"\nChanged files: actions/setup/js/resolve_pr_review_thread.cjs, actions/setup/js/resolve_pr_review_thread.test.cjs\n\nRead the full diff at /tmp/gh-aw/agent/pr-diff.patch (this is the complete context you need — do not fetch anything else).\n\nSummary of the change: `resolve_pull_request_review_thread` safe-output handler previously rejected `PullRequestReviewComment` (PRRC_...) node IDs. Now it detects PRRC_ nodes, looks up the PR number/repo from the comment, then paginates through `reviewThreads(first: 100)` on that PR (with `comments(first: 100)` nested, no pagination on the comments sub-list) looking for a thread whose comments contain the given comment ID. If found, it resolves using the found thread's real thread ID instead of the original comment ID, otherwise returns `status: \"comment_without_thread\"`.\n\nLook specifically for:\n1. Missing pagination on the nested `comments(first: 100)` field inside `reviewThreads` — if a thread has more than 100 comments, a valid match beyond the first 100 would never be found, silently returning `comment_without_thread` (a false negative).\n2. N+1 / performance cost: for every batch item that is a PRRC_ ID, a full paginated scan of all review threads (and their comments) on the PR is performed. In a batch processing multiple comment IDs on the same PR, this repeats the full thread scan per item with no caching/memoization across items in the same `main()` invocation — quadratic-ish behavior for a batch of N comment IDs referring to the same PR.\n3. Correctness: verify that `commentNode.pullRequest` access path is safe (optional chaining depth), and that repoNameWithOwner reconstruction logic (`repository?.nameWithOwner ?? (repoOwner && repoName ? ... : null)`) is not fragile.\n4. Error handling: what happens if `github.graphql` throws inside `findThreadInfoForReviewComment` (e.g., rate limit, network error) — is it caught anywhere, or does it propagate up uncaught differently than the sibling code path?\n5. Test coverage: does the new test suite cover the \"more than 100 comments\" pagination edge case? Does it cover the case where the review comment belongs to a PR/repo not matching validation constraints? Does it cover a `github.graphql` exception thrown during the new lookup path?\n6. Any log/message inconsistencies where `threadId` (original ID, possibly PRRC_) vs `resolvedThreadId` (real PRRT_) are used — make sure all user-facing messages after resolution use the correct one, and note any case where the original `threadId` is still used instead of `resolvedThreadId` that could confuse the caller.\n7. Style/maintainability: duplicated GraphQL client instantiation, magic numbers (100), function complexity of `main()`, unclear naming.\n\nOutput STRICT JSONL, one finding per line, with this exact JSON shape per line (no markdown fences, no prose outside JSON lines):\n{\"file\": \"<path>\", \"line\": <line-number-in-new-file-if-known-or-null>, \"severity\": \"critical|high|medium|low\", \"title\": \"<short title>\", \"detail\": \"<why it matters + suggested fix>\"}\n\nOnly report findings that are actually visible in the diff content. Do not invent line numbers you cannot verify from the diff; use null if unsure. Return only the JSONL lines, nothing else."}}}
[copilot-sdk-driver] [sdk-driver] error: Execution failed: Error: No model available. Check policy enablement under GitHub Settings > Copilot
{"type":"subagent.completed","timestamp":"2026-08-04T19:39:29.155Z","data":{"agentName":"general-purpose","toolCallId":"toolu_016e11HASy4QkFV5KYVedxFg"}}

Generated from PR Code Quality Reviewer · 50.9 AIC · ◷

[github-actions]

Agent job 30967074450 failed.

Warning

Engine Failure: The copilot engine terminated unexpectedly.

Last agent output:

{"type":"tool.execution_complete","timestamp":"2026-08-05T01:55:10.395Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"060f5fa Merge efdc7fa373fb90f4d0c2267bf8d6a141f4fb5f2f into 98c05f2a6c02b124e1807b43266e233b378279a6\n<shellId: 31 completed with exit code 0>","detailedContent":"060f5fa Merge efdc7fa373fb90f4d0c2267bf8d6a141f4fb5f2f into 98c05f2a6c02b124e1807b43266e233b378279a6\n<shellId: 31 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-05T01:55:21.804Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-05T01:55:21.812Z","data":{"toolName":"bash","mcpServerName":"","command":"grep -rn \"import.*dist\\|require.*dist\" /home/runner/work/gh-aw/gh-aw/eslint-factory/src/*.test.ts /home/runner/work/gh-aw/gh-aw/eslint-factory/src/**/*.test.ts 2>/dev/null | head"}}
{"type":"tool.execution_complete","timestamp":"2026-08-05T01:55:21.890Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"\n<shellId: 32 completed with exit code 0>","detailedContent":"\n<shellId: 32 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-05T01:56:04.780Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-05T01:56:04.785Z","data":{"toolName":"bash","mcpServerName":"","command":"sed -n '235,296p' /home/runner/work/gh-aw/gh-aw/Makefile"}}
{"type":"tool.execution_complete","timestamp":"2026-08-05T01:56:04.863Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":".PHONY: security-govulncheck\nsecurity-govulncheck:\n\t@echo \"Running govulncheck...\"\n\t@go tool govulncheck ./...\n\t@echo \"✓ Govulncheck complete\"\n\n.PHONY: security-govulncheck-sarif\nsecurity-govulncheck-sarif:\n\t@echo \"Running govulncheck (SARIF output)...\"\n\t@go tool govulncheck -format sarif ./... > govulncheck-results.sarif; ret=$$?; [ $$ret -eq 0 ] || [ $$ret -eq 3 ]\n\t@echo \"✓ Govulncheck complete (results in govulncheck-results.sarif)\"\n\n# Test JavaScript files\n.PHONY: check-cjs-syntax\ncheck-cjs-syntax:\n\t@echo \"→ Checking CommonJS runtime syntax...\"\n\t@find actions/setup/js \\\n\t\t-path 'actions/setup/js/node_modules' -prune -o \\\n\t\t-type f -name '*.cjs' ! -name '*.test.cjs' -print0 | xargs -0 -r -n1 node --check\n\t@echo \"✓ CommonJS runtime syntax validated\"\n\n.PHONY: test-js\ntest-js: build-js\n\tcd actions/setup/js && npm run test:js -- --no-file-parallelism\n\n# Test impacted JavaScript unit tests only (excluding integration tests)\n.PHONY: test-impacted-js\ntest-impacted-js: build-js\n\t@BASE_COMMIT=$$(git merge-base $(BASE_REF) HEAD 2>/dev/null); \\\n\tif [ -z \"$$BASE_COMMIT\" ]; then \\\n\t\techo \"Error: unable to determine merge-base from BASE_REF=$(BASE_REF).\"; \\\n\t\techo \"Set BASE_REF explicitly, for example: make test-impacted-js BASE_REF=origin/main\"; \\\n\t\texit 1; \\\n\tfi; \\\n\tCHANGED_JS_FILES=$$({ git diff --name-only --diff-filter=ACMR \"$$BASE_COMMIT\" -- actions/setup/js eslint-factory; git ls-files --others --exclude-standard -- actions/setup/js eslint-factory; } | sort -u | grep -E '\\.(cjs|js|mjs|ts)$$' || true); \\\n\tif [ -z \"$$CHANGED_JS_FILES\" ]; then \\\n\t\techo \"No changed JavaScript/TypeScript files under actions/setup/js or eslint-factory; skipping impacted JS tests.\"; \\\n\t\texit 0; \\\n\tfi; \\\n\tCHANGED_SETUP_JS_FILES=$$(printf '%s\\n' \"$$CHANGED_JS_FILES\" | grep '^actions/setup/js/' || true); \\\n\tCHANGED_ESLINT_FACTORY_FILES=$$(printf '%s\\n' \"$$CHANGED_JS_FILES\" | grep '^eslint-factory/' || true); \\\n\tROOT=$$(pwd); \\\n\tif [ -n \"$$CHANGED_SETUP_JS_FILES\" ]; then \\\n\t\techo \"Running impacted JavaScript unit tests in actions/setup/js for changed files: $$CHANGED_SETUP_JS_FILES\"; \\\n\t\tcd \"$$ROOT/actions/setup/js\" && printf '%s\\n' \"$$CHANGED_SETUP_JS_FILES\" | sed 's|^actions/setup/js/||' | tr '\\n' '\\0' | xargs -0 -r npm run test:js -- --no-file-parallelism --passWithNoTests $(JS_IMPACTED_TEST_EXCLUDES); \\\n\tfi; \\\n\tif [ -n \"$$CHANGED_ESLINT_FACTORY_FILES\" ]; then \\\n\t\techo \"Running eslint-factory tests for changed files: $$CHANGED_ESLINT_FACTORY_FILES\"; \\\n\t\tcd \"$$ROOT/eslint-factory\" && npm test; \\\n\tfi\n\n# Test impacted Go unit tests only (excluding integration tests)\n.PHONY: test-impacted-go\ntest-impacted-go:\n\t@BASE_COMMIT=$$(git merge-base $(BASE_REF) HEAD 2>/dev/null); \\\n\tif [ -z \"$$BASE_COMMIT\" ]; then \\\n\t\techo \"Error: unable to determine merge-base from BASE_REF=$(BASE_REF).\"; \\\n\t\techo \"Set BASE_REF explicitly, for example: make test-impacted-go BASE_REF=origin/main\"; \\\n\t\texit 1; \\\n\tfi; \\\n\tCHANGED_GO_FILES=$$({ git diff --name-only --diff-filter=ACDMR \"$$BASE_COMMIT\"; git ls-files --others --exclude-standard; } | sort -u | grep -E '\\.go$$' || true); \\\n<shellId: 33 completed with exit code 0>","detailedContent":".PHONY: security-govulncheck\nsecurity-govulncheck:\n\t@echo \"Running govulncheck...\"\n\t@go tool govulncheck ./...\n\t@echo \"✓ Govulncheck complete\"\n\n.PHONY: security-govulncheck-sarif\nsecurity-govulncheck-sarif:\n\t@echo \"Running govulncheck (SARIF output)...\"\n\t@go tool govulncheck -format sarif ./... > govulncheck-results.sarif; ret=$$?; [ $$ret -eq 0 ] || [ $$ret -eq 3 ]\n\t@echo \"✓ Govulncheck complete (results in govulncheck-results.sarif)\"\n\n# Test JavaScript files\n.PHONY: check-cjs-syntax\ncheck-cjs-syntax:\n\t@echo \"→ Checking CommonJS runtime syntax...\"\n\t@find actions/setup/js \\\n\t\t-path 'actions/setup/js/node_modules' -prune -o \\\n\t\t-type f -name '*.cjs' ! -name '*.test.cjs' -print0 | xargs -0 -r -n1 node --check\n\t@echo \"✓ CommonJS runtime syntax validated\"\n\n.PHONY: test-js\ntest-js: build-js\n\tcd actions/setup/js && npm run test:js -- --no-file-parallelism\n\n# Test impacted JavaScript unit tests only (excluding integration tests)\n.PHONY: test-impacted-js\ntest-impacted-js: build-js\n\t@BASE_COMMIT=$$(git merge-base $(BASE_REF) HEAD 2>/dev/null); \\\n\tif [ -z \"$$BASE_COMMIT\" ]; then \\\n\t\techo \"Error: unable to determine merge-base from BASE_REF=$(BASE_REF).\"; \\\n\t\techo \"Set BASE_REF explicitly, for example: make test-impacted-js BASE_REF=origin/main\"; \\\n\t\texit 1; \\\n\tfi; \\\n\tCHANGED_JS_FILES=$$({ git diff --name-only --diff-filter=ACMR \"$$BASE_COMMIT\" -- actions/setup/js eslint-factory; git ls-files --others --exclude-standard -- actions/setup/js eslint-factory; } | sort -u | grep -E '\\.(cjs|js|mjs|ts)$$' || true); \\\n\tif [ -z \"$$CHANGED_JS_FILES\" ]; then \\\n\t\techo \"No changed JavaScript/TypeScript files under actions/setup/js or eslint-factory; skipping impacted JS tests.\"; \\\n\t\texit 0; \\\n\tfi; \\\n\tCHANGED_SETUP_JS_FILES=$$(printf '%s\\n' \"$$CHANGED_JS_FILES\" | grep '^actions/setup/js/' || true); \\\n\tCHANGED_ESLINT_FACTORY_FILES=$$(printf '%s\\n' \"$$CHANGED_JS_FILES\" | grep '^eslint-factory/' || true); \\\n\tROOT=$$(pwd); \\\n\tif [ -n \"$$CHANGED_SETUP_JS_FILES\" ]; then \\\n\t\techo \"Running impacted JavaScript unit tests in actions/setup/js for changed files: $$CHANGED_SETUP_JS_FILES\"; \\\n\t\tcd \"$$ROOT/actions/setup/js\" && printf '%s\\n' \"$$CHANGED_SETUP_JS_FILES\" | sed 's|^actions/setup/js/||' | tr '\\n' '\\0' | xargs -0 -r npm run test:js -- --no-file-parallelism --passWithNoTests $(JS_IMPACTED_TEST_EXCLUDES); \\\n\tfi; \\\n\tif [ -n \"$$CHANGED_ESLINT_FACTORY_FILES\" ]; then \\\n\t\techo \"Running eslint-factory tests for changed files: $$CHANGED_ESLINT_FACTORY_FILES\"; \\\n\t\tcd \"$$ROOT/eslint-factory\" && npm test; \\\n\tfi\n\n# Test impacted Go unit tests only (excluding integration tests)\n.PHONY: test-impacted-go\ntest-impacted-go:\n\t@BASE_COMMIT=$$(git merge-base $(BASE_REF) HEAD 2>/dev/null); \\\n\tif [ -z \"$$BASE_COMMIT\" ]; then \\\n\t\techo \"Error: unable to determine merge-base from BASE_REF=$(BASE_REF).\"; \\\n\t\techo \"Set BASE_REF explicitly, for example: make test-impacted-go BASE_REF=origin/main\"; \\\n\t\texit 1; \\\n\tfi; \\\n\tCHANGED_GO_FILES=$$({ git diff --name-only --diff-filter=ACDMR \"$$BASE_COMMIT\"; git ls-files --others --exclude-standard; } | sort -u | grep -E '\\.go$$' || true); \\\n<shellId: 33 completed with exit code 0>"}}}
{"type":"assistant.message","timestamp":"2026-08-05T01:57:04.795Z","data":{"content":""}}
{"type":"tool.execution_start","timestamp":"2026-08-05T01:57:04.799Z","data":{"toolName":"bash","mcpServerName":"","command":"grep -n \"^check-workflow-drift:\" -A 15 /home/runner/work/gh-aw/gh-aw/Makefile"}}
{"type":"tool.execution_complete","timestamp":"2026-08-05T01:57:04.867Z","data":{"toolName":"bash","mcpServerName":"","success":true,"result":{"content":"926:check-workflow-drift:\n927-\t@if [ ! -x \"./$(BINARY_NAME)\" ]; then \\\n928-\t\techo \"./$(BINARY_NAME) not found; building it first...\"; \\\n929-\t\t$(MAKE) build; \\\n930-\tfi\n931-\t@bash scripts/check-workflow-drift.sh ./$(BINARY_NAME)\n932-\n933-# Guard against a stale binary when files under pkg/parser/schemas/ are modified.\n934-# Schema files are embedded at compile time via (go/redacted):embed, so changing them without\n935-# rebuilding means the running binary still holds the old schema.  This target\n936-# detects when schema files have been modified (via git) but the binary has not been\n937-# rebuilt.  It is the schema-side parallel of check-stale-lock-files.\n938-# Requires the gh-aw binary to exist (run `make build` first).\n939-.PHONY: check-stale-schema-binary\n940-check-stale-schema-binary:\n941-\t@base_ref=\"$${CHECK_STALE_SCHEMA_BASE_REF:-}\"; \\\n<shellId: 34 completed with exit code 0>","detailedContent":"926:check-workflow-drift:\n927-\t@if [ ! -x \"./$(BINARY_NAME)\" ]; then \\\n928-\t\techo \"./$(BINARY_NAME) not found; building it first...\"; \\\n929-\t\t$(MAKE) build; \\\n930-\tfi\n931-\t@bash scripts/check-workflow-drift.sh ./$(BINARY_NAME)\n932-\n933-# Guard against a stale binary when files under pkg/parser/schemas/ are modified.\n934-# Schema files are embedded at compile time via (go/redacted):embed, so changing them without\n935-# rebuilding means the running binary still holds the old schema.  This target\n936-# detects when schema files have been modified (via git) but the binary has not been\n937-# rebuilt.  It is the schema-side parallel of check-stale-lock-files.\n938-# Requires the gh-aw binary to exist (run `make build` first).\n939-.PHONY: check-stale-schema-binary\n940-check-stale-schema-binary:\n941-\t@base_ref=\"$${CHECK_STALE_SCHEMA_BASE_REF:-}\"; \\\n<shellId: 34 completed with exit code 0>"}}}

Generated from PR Code Quality Reviewer · 148 AIC · ◷