Skip to content

[spec-librarian] Specification Audit — 2026-08-09 — 5 issues found #51591

Description

@github-actions

📚 Package Specification Audit Report

Date: 2026-08-09
Total Packages: 34
Packages with Specs: 34
Coverage: 100%


Coverage Summary

All 34 packages under pkg/ have a README.md. No missing specifications.

Note: the git history available in this checkout is shallow/squashed (single commit), so file-modification-time based staleness detection was not reliable and is not reported here. Staleness was instead assessed via direct symbol-diffing between source and spec (see below).


🚨 Missing Specifications

None. All 34 packages have specifications.


🔄 Documentation Accuracy Issues

View accuracy issues (5 packages affected)

cli — Phantom (nonexistent) documented function

  • Spec claims: pkg/cli/README.md documents func FindOrFetchModelPricing(ctx context.Context, provider, model string) (map[string]float64, bool) in model_costs.go.
  • Actual source: pkg/cli/model_costs.go only defines an unexported func findModelPricing(provider, model string) (map[string]float64, bool) — no FindOrFetchModelPricing, no context.Context parameter, and no fetch behavior exists.
  • Recommendation: Either rename/export the real function to match the spec, or correct the spec entry to reference findModelPricing (and remove the ctx parameter and "fetch" wording) — re-run spec-extractor for pkg/cli.

⚠️ cli — 17 undocumented exported symbols

New/changed exported symbols not mentioned in pkg/cli/README.md, including: AnalysisBase, AuditData, CrossRunAuditReport, DiffEntryBase, FirewallSummaryBase, MergeWorkflowContent, MetricEvalResults, RemoveTopLevelFieldFromFrontmatter, RunActionlintOnFiles, RunAddInteractive, SetupAuthResult, SetupRepositoryCheckResult, SkillActivation, SyftScanResult, TokenCoreMetrics, UpgradeConfig, WorkflowTrialResult.

  • Recommendation: Re-run spec-extractor for pkg/cli to add coverage for these symbols.

⚠️ workflow — 23 undocumented exported symbols

Includes (verified to exist in source, e.g. pkg/workflow/awf_config.go, pkg/workflow/tools_types.go): AWFBoundedQueriesConfig, AWFBoundedQueryPrivateRepo, AiCreditsPricingConfig, BoundedQueriesConfig, BoundedQueryPrivateRepo, BoundedQueryRuntime, BuildEngineSecretValidationStep, ContainerPinTarget, EngineNetworkDefinition, EngineSecretValidationConfig, EnginesWithCapability, GetMCPConfigAdapterFilename, GetMCPConfigAdapterWriteStep, HarnessRunner, HasBashExplicitRestriction, InferenceProviderResolver, InlineEngineDriver, IsActionFailureIssueExpiresExplicit, MCPConfigAdapterProvider, MCPProxyEngine, NPMInstallOptions, OTLPWorkloadIdentityConfig, SafeOutputAllowedLabelsConfig.

  • Recommendation: Re-run spec-extractor for pkg/workflow (largest package, 470 source files) to close this documentation gap.

⚠️ parser — 4 undocumented exported symbols

IsAnyGitHubHostEnvVarSet, IsGitHubHost, IsImportSafeSharedWorkflowOn, MCPRootInfo exist in source but are not referenced in pkg/parser/README.md.

  • Recommendation: Re-run spec-extractor for pkg/parser.

⚠️ agentdrain — 5 undocumented exported symbols

(*Coordinator).AllClusters, (*Miner).Clusters, (*Coordinator).LoadWeightsJSON, (*Coordinator).SaveSnapshots, (*Coordinator).SaveWeightsJSON exist in pkg/agentdrain/coordinator.go and pkg/agentdrain/miner.go but are not documented.

  • Recommendation: Re-run spec-extractor for pkg/agentdrain.

📊 Quality Scores (spot-checked packages)

Package Completeness Accuracy Overall
cli 96% (17/522 exported symbols undocumented) ⚠️ Has 1 phantom function ⚠️ Needs Attention
workflow 97% (23/920 exported symbols undocumented) ✅ No phantoms found ⚠️ Needs Attention
parser 97% (4/124 exported symbols undocumented) ✅ No phantoms found ✅ Good
agentdrain 85% (5/34 exported symbols undocumented) ✅ No phantoms found ⚠️ Needs Attention
All other 30 packages 100% (spot-checked, no gaps found) ✅ Good

Action Items

  • Fix the phantom FindOrFetchModelPricing reference in pkg/cli/README.md (rename source function to match, or correct the spec)
  • Update pkg/cli/README.md to document the 17 missing exported symbols
  • Update pkg/workflow/README.md to document the 23 missing exported symbols
  • Update pkg/parser/README.md to document the 4 missing exported symbols
  • Update pkg/agentdrain/README.md to document the 5 missing exported symbols
  • When opening a fix PR for this issue, include Closes #<this issue number> (or Fixes/Resolves) in the PR description.

📚 Next review scheduled for tomorrow. Close this issue once all items are resolved.

📚 Specification review by Package Specification Librarian · auto · 72.8 AIC · ⌖ 2.47 AIC · ⊞ 8.5K ·

  • expires on Aug 12, 2026, 5:36 AM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions