[dead-code] chore: remove dead functions — 5 functions removed

[github-actions]

Caution

Protected files were modified in this change.
This pull request is in request_review mode and requires explicit human scrutiny before merge.

Protected files: README.md

Functions Removed

Function	File
FindPricing	pkg/modelsdev/catalog.go
ensureCatalog	pkg/modelsdev/catalog.go
downloadAndParseCatalog	pkg/modelsdev/catalog.go
parseCatalog	pkg/modelsdev/catalog.go
parseCostMap	pkg/modelsdev/catalog.go

Tests Removed

• TestFindPricing (pkg/modelsdev/catalog_test.go)
• TestParseCatalog (pkg/modelsdev/catalog_test.go)
• TestParseCostMap (pkg/modelsdev/catalog_test.go)
• TestSpec_PublicAPI_FindPricing (pkg/modelsdev/spec_test.go)
• TestSpec_DesignDecision_ProviderAliases (pkg/modelsdev/spec_test.go)

Also removed now-unused supporting types/vars/consts (rawCatalog, rawProvider, rawModel, pricingCache, catalogURL, catalogCache, httpClientFactory, pkgLog, fetchTimeout, maxBodyBytes) and updated pkg/modelsdev/README.md to drop the FindPricing public API entry. NormalizeProvider and NormalizeComparableModelID (still used by pkg/cli/model_costs.go) were kept.

Verification

• go build ./...
• go vet ./...
• go vet -tags=integration ./...
• make fmt

Run: https://github.com/github/gh-aw/actions/runs/31318112320

Generated by 🧹 Dead Code Removal Agent · auto · 79.4 AIC · ⌖ 18.9 AIC · ⊞ 8.9K · ◷

• expires on Aug 12, 2026, 6:32 AM UTC-08:00

---

Note

This was originally intended as a pull request, but the git push operation failed.

Original error: ERR_VALIDATION: pushSignedCommits: refusing unsigned push for branch 'chore/remove-dead-modelsdev-catalog-97f619af9bf9310b': Signed-commit payload violates file-protection policy (request_review): pkg/modelsdev/README.md

Workflow Run: View run details and download bundle artifact

The bundle file is available in the agent artifact in the workflow run linked above.

To create a pull request with the changes:

# Download the artifact from the workflow run
gh run download 31318112320 -n agent -D /tmp/agent-31318112320

# Fetch the bundle into a temporary ref, then update the local branch
git fetch /tmp/agent-31318112320/aw-chore-remove-dead-modelsdev-catalog.bundle refs/heads/chore/remove-dead-modelsdev-catalog:refs/bundles/create-pr-chore-remove-dead-modelsdev-catalog-97f619af9bf9310b-2c2eae07
git update-ref refs/heads/chore/remove-dead-modelsdev-catalog-97f619af9bf9310b refs/bundles/create-pr-chore-remove-dead-modelsdev-catalog-97f619af9bf9310b-2c2eae07
git checkout chore/remove-dead-modelsdev-catalog-97f619af9bf9310b
# Ensure the working tree matches the updated branch
git reset --hard
# Remove the temporary bundle ref
git update-ref -d refs/bundles/create-pr-chore-remove-dead-modelsdev-catalog-97f619af9bf9310b-2c2eae07

# Push the branch to origin
git push origin chore/remove-dead-modelsdev-catalog-97f619af9bf9310b

# Create the pull request
gh pr create --title '[dead-code] chore: remove dead functions — 5 functions removed' --base main --head chore/remove-dead-modelsdev-catalog-97f619af9bf9310b --repo github/gh-aw