[function-namer] Go function rename plan: pkg/workflow

[github-actions]

🏷️ Go Function Rename Plan

Package Analyzed: pkg/workflow
Analysis Date: 2026-08-12
Round-Robin Position: package 8 of 48 total packages
Functions Analyzed: 355 functions across 66 files

Why This Matters

When AI coding agents search for functions to complete a task, they rely on function
names to understand what code does. Clear, descriptive names increase the likelihood
that an agent will find the right function instead of reimplementing existing logic.
Functions in the same package also call each other, so reviewing them together gives
better context for rename decisions.

Rename Suggestions

pkg/workflow/tools.go

Current Name	Suggested Name	Reason
detectTriggerType()	detectImplicitTriggerType()	The function does not detect arbitrary trigger types. It specifically infers whether default on: generation should treat the workflow as a slash/command or label-command workflow, including a fallback read from frontmatter when WorkflowData is still incomplete. The new name makes that narrow purpose easier for an agent to find.

All functions in this file (for reference):

• (*Compiler).applyDefaults() — ✅ Clear, no change needed
• populateWorkflowDataCache() — ✅ Clear, no change needed
• detectTriggerType() — ⚠️ Rename suggested (see table above)
• (*Compiler).applyDefaultOnSection() — ✅ Clear, no change needed
• applyDefaultPermissions() — ✅ Clear, no change needed
• (*Compiler).applyCommandTriggerOnSection() — ✅ Clear, no change needed
• (*Compiler).buildCommandTriggerEventsMap() — ✅ Clear, no change needed
• (*Compiler).applyLabelCommandTriggerOnSection() — ✅ Clear, no change needed
• (*Compiler).buildLabelCommandEventsMap() — ✅ Clear, no change needed
• mergeLabelCommandOtherEvents() — ✅ Clear, no change needed
• ensureWorkflowDispatchItemNumberInput() — ✅ Clear, no change needed
• (*Compiler).mergeToolsAndMCPServers() — ✅ Clear, no change needed
• mergeRuntimes() — ✅ Clear, no change needed
• (*Compiler).hasIssueTrigger() — ✅ Clear, no change needed
• (*Compiler).injectWorkflowDispatchForIssue() — ✅ Clear, no change needed
• (*Compiler).replaceIssueNumberReferences() — ✅ Clear, no change needed
• isBashFullyDisabled() — ✅ Clear, no change needed
• (*Compiler).applyDefaultTools() — ✅ Clear, no change needed

pkg/workflow/time_delta.go

Current Name	Suggested Name	Reason
parseTimeDeltaForStopAfter()	parseStopAfterTimeDelta()	This helper is specific to the stop-after field rather than a generic “for X” variant. The suggested name leads with the domain concept an agent would likely search for.
parseTimeDeltaWithMinutes()	parseTimeDeltaWithOptionalMinutes()	The current name sounds like it always parses minute-bearing input. The boolean parameter actually toggles minute support on and off, so the rename better matches behavior.

All functions in this file (for reference):

• parseTimeDelta() — ✅ Clear, no change needed
• parseTimeDeltaForStopAfter() — ⚠️ Rename suggested (see table above)
• parseTimeDeltaWithMinutes() — ⚠️ Rename suggested (see table above)
• (*TimeDelta).String() — ✅ Standard stringer, no change needed
• isRelativeStopTime() — ✅ Clear, no change needed
• parseAbsoluteDateTime() — ✅ Clear, no change needed
• isRelativeDate() — ✅ Clear, no change needed
• parseRelativeDate() — ✅ Clear, no change needed
• ResolveRelativeDate() — ✅ Clear, no change needed
• parseExpiresFromConfig() — ✅ Clear, no change needed
• parseRelativeTimeSpec() — ✅ Clear, no change needed

pkg/workflow/template_injection_utils.go

Current Name	Suggested Name	Reason
extractRunBlocks()	extractRunScriptBlocks()	The function recursively walks parsed workflow data and collects run: script contents, not arbitrary YAML blocks. Adding Script makes its output and use in injection validation much easier to infer.

All functions in this file (for reference):

• extractRunBlocks() — ⚠️ Rename suggested (see table above)
• removeHeredocContent() — ✅ Clear, no change needed
• stripShellLineComments() — ✅ Clear, no change needed
• isShellCommentStart() — ✅ Clear, no change needed
• replaceOutsideQuotedHeredocs() — ✅ Clear, no change needed
• replaceOutsideShellLineComments() — ✅ Clear, no change needed
• extractRunSnippet() — ✅ Clear, no change needed
• detectExpressionContext() — ✅ Clear, no change needed
• formatTemplateInjectionError() — ✅ Clear, no change needed
• formatRunScriptExpressionGuardrailError() — ✅ Clear, no change needed

pkg/workflow/tool_description_enhancer.go

Current Name	Suggested Name	Reason
buildConstraints()	buildToolConstraints()	In this package, “constraints” always refers to tool-description constraint text. The current generic name is hard to search for and easy to overlook. The new name anchors it to the package domain.

All functions in this file (for reference):

• toolConstraintBuilder() — ✅ Type alias is clear, no change needed
• formatStringList() — ✅ Clear, no change needed
• appendAllowedIssueFieldsConstraint() — ✅ Clear, no change needed
• appendMaxConstraint() — ✅ Clear, no change needed
• buildConstraints() — ⚠️ Rename suggested (see table above)
• appendStringConstraint() — ✅ Clear, no change needed
• appendTargetConstraint() — ✅ Clear, no change needed
• enhanceToolDescription() — ✅ Clear, no change needed
• buildToolDescriptionConstraints() — ✅ Clear, no change needed
• Remaining per-tool *Constraints() helpers — ✅ Clear, no change needed

pkg/workflow/trigger_parser.go

Current Name	Suggested Name	Reason
parseSourceControlTrigger()	parseGitRefTrigger()	The function only dispatches push and pull_request shorthand parsing. “Source control” is broader than the implementation and gives weak search cues. “Git ref trigger” better signals branch/tag/PR event parsing.

All functions in this file (for reference):

• ParseTriggerShorthand() — ✅ Clear, no change needed
• (*TriggerIR).ToYAMLMap() — ✅ Clear, no change needed
• parseSlashCommandTrigger() — ✅ Clear, no change needed
• parseLabelTrigger() — ✅ Clear, no change needed
• parseSourceControlTrigger() — ⚠️ Rename suggested (see table above)
• parsePushTrigger() — ✅ Clear, no change needed
• parsePullRequestTrigger() — ✅ Clear, no change needed
• parseIssueDiscussionTrigger() — ✅ Clear, no change needed
• Remaining parse*Trigger() helpers — ✅ Clear, no change needed
• mergeCommandOtherEvents() — ✅ Clear, no change needed
• mergeEventConfig() — ✅ Clear, no change needed
• parseEventTypes() — ✅ Clear, no change needed
• (*Compiler).parseOnSection() — ✅ Clear, no change needed
• parseOnMapPreamble() — ✅ Clear, no change needed
• parseCommandTriggerFromOnMap() — ✅ Clear, no change needed
• parseLabelCommandFromOnMap() — ✅ Clear, no change needed
• (*Compiler).finalizeCommandTriggerState() — ✅ Clear, no change needed
• parseStatusCommentFromOnMap() — ✅ Clear, no change needed
• parseLockForAgentFromOnMap() — ✅ Clear, no change needed

pkg/workflow/workflow_builder.go

Current Name	Suggested Name	Reason
(*Compiler).extractYAMLSections()	(*Compiler).extractWorkflowYAMLSections()	The method extracts top-level workflow YAML snippets into WorkflowData, not generic YAML sections. The added qualifier improves package-level searchability and reduces ambiguity with other YAML extraction helpers.

All functions in this file (for reference):

• (*Compiler).buildInitialWorkflowData() — ✅ Clear, no change needed
• extractEnclavesConfig() — ✅ Clear, no change needed
• extractLSPConfig() — ✅ Clear, no change needed
• extractFrontmatterSkills() — ✅ Clear, no change needed
• extractFrontmatterSkillReferences() — ✅ Clear, no change needed
• extractMainModelCostsOverlay() — ✅ Clear, no change needed
• mergeModelCostOverlays() — ✅ Clear, no change needed
• mergeModelCostOverlayPair() — ✅ Clear, no change needed
• extractMainModelPolicyOverlay() — ✅ Clear, no change needed
• toFloat64() — ✅ Local utility name is acceptable, no change needed
• resolveDefaultAiCreditsPricing() — ✅ Clear, no change needed
• extractDefaultAiCreditsPricingFromModels() — ✅ Clear, no change needed
• extractDefaultAiCreditsPricingFromModelsMap() — ✅ Clear, no change needed
• extractDefaultAiCreditsPricingFromObject() — ✅ Clear, no change needed
• mergeModelPolicyOverlays() — ✅ Clear, no change needed
• filterAllowedModelConflictsWithSet() — ✅ Clear, no change needed
• modelConflictsWithDisallowedPolicy() — ✅ Clear, no change needed
• modelPolicyPatternMatches() — ✅ Clear, no change needed
• resolveInlinedImports() — ✅ Clear, no change needed
• mergeExcludedEnvVarNames() — ✅ Clear, no change needed
• (*Compiler).extractYAMLSections() — ⚠️ Rename suggested (see table above)
• Remaining workflow-builder helpers — ✅ Clear, no change needed

🤖 Agentic Implementation Plan

Agentic Implementation Plan

This issue is designed to be assigned to a coding agent. The agent should implement
all rename suggestions below in a single pull request.

Prerequisites

• Read each rename suggestion and verify it is accurate by reviewing the function body
• Check for any Go interface constraints that prevent renaming (e.g., must match interface method name)

Implementation Steps

For each rename suggestion, follow this sequence:

1. Rename the function in the indicated file

// Old
func oldName(args) returnType {

// New
func newName(args) returnType {

Target renames for this package:

• pkg/workflow/tools.go: detectTriggerType → detectImplicitTriggerType
• pkg/workflow/time_delta.go: parseTimeDeltaForStopAfter → parseStopAfterTimeDelta
• pkg/workflow/time_delta.go: parseTimeDeltaWithMinutes → parseTimeDeltaWithOptionalMinutes
• pkg/workflow/template_injection_utils.go: extractRunBlocks → extractRunScriptBlocks
• pkg/workflow/tool_description_enhancer.go: buildConstraints → buildToolConstraints
• pkg/workflow/trigger_parser.go: parseSourceControlTrigger → parseGitRefTrigger
• pkg/workflow/workflow_builder.go: (*Compiler).extractYAMLSections → (*Compiler).extractWorkflowYAMLSections

2. Update all call sites

Use grep to find every caller and update the reference:

grep -rn "oldName" pkg/ --include="*.go"

Also check test files:

grep -rn "oldName" pkg/ --include="*_test.go"

Known call sites from this analysis:

• detectTriggerType is called by (*Compiler).applyDefaults in pkg/workflow/tools.go
• parseTimeDeltaForStopAfter is called by resolveStopTime in pkg/workflow/stop_after.go and related tests in pkg/workflow/time_delta_test.go
• parseTimeDeltaWithMinutes is called by parseTimeDelta and parseTimeDeltaForStopAfter in pkg/workflow/time_delta.go
• extractRunBlocks is called by validateNoTemplateInjectionFromParsed and validateNoGitHubExpressionsInRunScriptsFromParsed in pkg/workflow/template_injection_validation.go
• buildConstraints is called broadly by the per-tool *Constraints helpers in pkg/workflow/tool_description_enhancer.go
• parseSourceControlTrigger is called by ParseTriggerShorthand in pkg/workflow/trigger_parser.go
• (*Compiler).extractYAMLSections is called by (*Compiler).populateWorkflowBuildContext, (*Compiler).ParseWorkflowString, and associated tests

3. Verify compilation after each rename

make build

4. Run tests after all renames are complete

make test-unit
make lint

Commit Convention

Each rename should be a focused commit:

refactor: rename <oldName> to <newName> for clarity

Validation Checklist

• All renames implemented
• All call sites updated (Go files and test files)
• make build passes with no errors
• make test-unit passes
• make lint passes
• PR description explains the agent-discoverability rationale

Notes for the Agent

• This is a pure rename refactor — behavior must not change, only names
• If a rename causes unexpected complexity (e.g., name conflicts, interface constraints),
  skip it and leave a comment in the PR explaining why
• Follow existing naming conventions documented in AGENTS.md
• Unexported functions used only as closures or immediately-invoked can be skipped

---

Generated by the Daily Go Function Namer workflow
Run: 31593990868

Generated by 🔧 Daily Go Function Namer · gpt54 · 21.8 AIC · ⌖ 7.48 AIC · ⊞ 8.3K · ◷

• expires on Aug 19, 2026, 4:00 AM UTC-08:00

[github-actions]

This issue is being closed as outdated. A newer issue has been created: #52486

View newer issue

---

This action was performed automatically by the Daily Go Function Namer workflow.