Summary
make golint-custom reported a non-shared function-length finding in pkg/parser/schema_suggestions.go.
Finding
pkg/parser/schema_suggestions.go:539 — extractNestedYAMLValue is 73 lines long (limit: 60); consider breaking it up
Expected outcome
Refactor extractNestedYAMLValue into smaller helpers while preserving YAML extraction behavior and existing caller contracts.
Remediation checklist
Copilot instructions
- Split
extractNestedYAMLValue into a few small private helpers with clear responsibilities.
- Do not change unrelated parser behavior or surrounding APIs.
- Validate the file by running
make golint-custom.
Generated by 🧌 LintMonster · gpt54 · 29.9 AIC · ⌖ 4.17 AIC · ⊞ 5.7K · ◷
Summary
make golint-custom reports one non-shared custom-lint finding: EnforceSafeUpdate exceeds the parameter-count limit.
Finding
pkg/workflow/safe_update_enforcement.go:53 — EnforceSafeUpdate has 9 parameters (limit: 8); consider using an options struct
Expected outcome
Refactor EnforceSafeUpdate to reduce its parameter count, preferably by introducing a small options/request struct or grouping related inputs, without changing call-site behavior.
Remediation checklist
Copilot instructions
- Introduce the smallest structure needed to bring
EnforceSafeUpdate to 8 parameters or fewer.
- Update only direct callers affected by the signature change.
- Avoid unrelated cleanup.
- Validate with
make golint-custom before finishing.> Generated by 🧌 LintMonster · gpt54 · 25.3 AIC · ⌖ 4.17 AIC · ⊞ 5.7K · ◷
Summary
make golint-customreported a non-shared function-length finding inpkg/parser/schema_suggestions.go.Finding
pkg/parser/schema_suggestions.go:539—extractNestedYAMLValue is 73 lines long (limit: 60); consider breaking it upExpected outcome
Refactor
extractNestedYAMLValueinto smaller helpers while preserving YAML extraction behavior and existing caller contracts.Remediation checklist
pkg/parser/schema_suggestions.go.make golint-customand confirm this finding is gone.Copilot instructions
extractNestedYAMLValueinto a few small private helpers with clear responsibilities.make golint-custom.Summary
make golint-customreports one non-shared custom-lint finding:EnforceSafeUpdateexceeds the parameter-count limit.Finding
pkg/workflow/safe_update_enforcement.go:53—EnforceSafeUpdate has 9 parameters (limit: 8); consider using an options structExpected outcome
Refactor
EnforceSafeUpdateto reduce its parameter count, preferably by introducing a small options/request struct or grouping related inputs, without changing call-site behavior.Remediation checklist
pkg/workflow/safe_update_enforcement.goand its direct call sites.make golint-customand confirm this finding is gone.Copilot instructions
EnforceSafeUpdateto 8 parameters or fewer.make golint-custombefore finishing.> Generated by 🧌 LintMonster · gpt54 · 25.3 AIC · ⌖ 4.17 AIC · ⊞ 5.7K · ◷