Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request removes the experimental copilot-sdk engine from the gh-aw codebase, eliminating approximately 10,000 lines of TypeScript code and associated infrastructure. The removal is intentionally breaking with no backward compatibility maintained.
Changes:
- Removed copilot-sdk engine implementation (Go code and tests)
- Removed copilot-client TypeScript implementation (~10k lines)
- Updated constants, schemas, CLI tools, and documentation to reflect 4-engine model (claude, codex, copilot, custom)
- Removed copilot-sdk-specific workflows and updated dev.md to use copilot engine
- Reassigned port 10002 from CopilotSDKLLMGatewayPort to CopilotLLMGatewayPort
Reviewed changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/copilot_sdk_engine.go | Removed copilot-sdk engine implementation (258 lines) |
| pkg/workflow/copilot_sdk_engine_test.go | Removed copilot-sdk engine tests (179 lines) |
| pkg/workflow/agentic_engine.go | Unregistered copilot-sdk from engine registry |
| pkg/constants/constants.go | Removed CopilotSDKEngine constant, CopilotSDKLLMGatewayPort (port 10002 reassigned to Copilot) |
| pkg/constants/constants_test.go | Updated expected engines list (4 instead of 5) |
| pkg/parser/schemas/main_workflow_schema.json | Updated enum to exclude copilot-sdk |
| pkg/cli/engine_secrets.go | Updated secret validation for copilot only |
| pkg/cli/engine_secrets_test.go | Removed copilot-sdk test cases |
| pkg/cli/completions_test.go | Updated completion tests for 4 engines |
| cmd/gh-aw/main_entry_test.go | Updated validation tests and error messages |
| pkg/workflow/strict_mode_llm_gateway_test.go | Removed copilot-sdk test case |
| pkg/workflow/imported_steps_validation_test.go | Updated validation tests |
| copilot-client/* | Removed entire TypeScript client directory (~10k lines) |
| .github/workflows/smoke-copilot-sdk.md | Removed smoke test workflow for copilot-sdk |
| .github/workflows/smoke-copilot-sdk.lock.yml | Removed compiled smoke test workflow (1536 lines) |
| .github/workflows/copilot-sdk-ci.yml | Removed CI workflow for copilot-client (145 lines) |
| .github/workflows/dev.md | Changed engine from copilot-sdk to copilot |
| .github/workflows/dev.lock.yml | Updated compiled workflow with copilot engine |
| DEVGUIDE.md | Removed Copilot SDK Client section (105 lines) |
| scratchpad/*.md | Updated documentation to reflect 4-engine architecture |
| .github/agents/custom-engine-implementation.agent.md | Removed copilot-sdk from example |
Files not reviewed (1)
- copilot-client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot merge main and fix build |
…t-sdk-agent-engine # Conflicts: # .github/workflows/smoke-copilot-sdk.lock.yml
Merged main branch and verified build is successful (commit bdec7cd). Changes:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot remove copilot-cli build from makefile https://github.com/github/gh-aw/actions/runs/22128020721/job/63962335833#step:10:1 |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Removed copilot-client build targets from Makefile (commit c9c34c4). Removed:
Build verified successfully ✓ Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Remove copilot-sdk agent engine
Summary
Successfully removed the copilot-sdk agent engine from the codebase with no legacy or backward compatibility support. Merged main branch to incorporate latest changes.
Changes Made
pkg/workflow/copilot_sdk_engine.gopkg/workflow/copilot_sdk_engine_test.gocopilot-client/TypeScript implementationactions/setup/js/copilot-client.jspkg/workflow/agentic_engine.goCopilotSDKEngineconstantCopilotSDKLLMGatewayPortconstantAgenticEngineslistEngineOptionslistpkg/cli/engine_secrets.gopkg/cli/completions_test.gopkg/cli/engine_secrets_test.gocmd/gh-aw/main_entry_test.gopkg/workflow/imported_steps_validation_test.gopkg/workflow/strict_mode_llm_gateway_test.gopkg/constants/constants_test.go.github/workflows/smoke-copilot-sdk.md.github/workflows/smoke-copilot-sdk.lock.yml.github/workflows/copilot-sdk-ci.yml.github/workflows/dev.mdand recompile.github/workflows/dev.lock.ymlscratchpad/adding-new-engines.mdscratchpad/engine-architecture-review.mdscratchpad/engine-review-summary.mdscratchpad/layout.mdpkg/parser/schemas/main_workflow_schema.json.github/agents/custom-engine-implementation.agent.mdDEVGUIDE.mddeps-copilot-clienttarget from Makefilecopilot-clientbuild target from Makefiletest-copilot-clienttarget from Makefiletest-alltarget to exclude copilot-clientrecompiletarget to remove copilot-client dependencysmoke-copilot-sdk.lock.ymlfileMerge Details
Merged main branch which included:
]or-#16517: Add spacing after title prefixes ending with]or-Conflict resolution:
smoke-copilot-sdk.lock.yml(consistent with copilot-sdk removal)Impact
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
✨ PR Review Safe Output Test - Run 22127763102