Add fallback resolution for workflows in .github/workflows/ directory#1762
Merged
Conversation
- Modified findWorkflowInPackageForRepo to try .github/workflows/ when workflows/ fails - Added comprehensive tests for fallback behavior - All existing tests pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
marked this pull request as ready for review
October 15, 2025 19:41
Contributor
|
Agentic Changeset Generator triggered by this pull request |
Copilot
AI
changed the title
[WIP] Update add command to resolve agentic workflow file
Add fallback resolution for workflows in .github/workflows/ directory
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
addcommand was unable to resolve workflow files stored in.github/workflows/when using the three-part specification format. For example:This command would fail because it only looked for workflows at:
But the actual file was located at:
Solution
This PR implements a fallback mechanism in the
findWorkflowInPackageForRepofunction. When a workflow path starting withworkflows/is not found at the initial location, the function now automatically tries.github/workflows/as a fallback.The fallback logic:
workflows/pathworkflows/, extracts the filename and tries.github/workflows/Example
After this change, the following command now works correctly:
It successfully resolves to
@githubnext/aw-wsg/.github/workflows/3_15-ensure-that-your-code-is-secure.md.Testing
Added comprehensive test coverage with 4 new tests:
.github/workflows/path existsworkflows/paths don't trigger fallbackAll existing tests continue to pass, ensuring backward compatibility.
Backward Compatibility
This change is fully backward compatible:
workflows/, it will be used (no behavior change)workflows/) are unaffectedOriginal prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.