Fix allocation-size-overflow in buildDomainItems (CodeQL #558)#23059
Merged
Fix allocation-size-overflow in buildDomainItems (CodeQL #558)#23059
Conversation
…dDomainItems Agent-Logs-Url: https://github.com/github/gh-aw/sessions/802f02f3-8be9-4bc4-a55f-6ba217af09c5 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning alert 558
Fix allocation-size-overflow in buildDomainItems (CodeQL #558)
Mar 26, 2026
Collaborator
|
@copilot do not preallocate with len. |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2b975856-7afc-4697-aff2-b430bc52c9cc Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a potential int overflow panic in buildDomainItems when preallocating slice capacity from len(allowedDomains)+len(blockedDomains) on pathological inputs.
Changes:
- Removes
len-based capacity preallocation inbuildDomainItemsto avoid overflow/panic. - Initializes
itemsas a nil slice and relies onappendgrowth.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildDomainItemspassedlen(allowedDomains)+len(blockedDomains)directly tomakeas the capacity. On pathological inputs, this addition overflowsint, producing a negative value and a runtime panic.Change
Removed the
len-based capacity preallocation entirely, replacingmake([]DomainItem, 0, capacity)with a plainvar items []DomainItemdeclaration. The slice grows naturally viaappendas items are added, eliminating both the overflow risk and the need for themathimport.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.