Skip to content

Fix allocation-size-overflow in buildDomainItems (CodeQL #558) #23059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Mar 26, 2026
Merged

Fix allocation-size-overflow in buildDomainItems (CodeQL #558) #23059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4690a82
Initial plan
Copilot Mar 26, 2026
fcbb734
Fix CodeQL alert #558: guard against allocation-size-overflow in buil…
Copilot Mar 26, 2026
29bb8de
Remove len-based preallocation in buildDomainItems
Copilot Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cli/domains_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ func computeAllowedDomains(engine constants.EngineName, network *workflow.Networ

// buildDomainItems creates a list of DomainItem from allowed and blocked domain slices
func buildDomainItems(allowedDomains, blockedDomains []string) []DomainItem {
items := make([]DomainItem, 0, len(allowedDomains)+len(blockedDomains))
var items []DomainItem
for _, d := range allowedDomains {
ecosystem := workflow.GetDomainEcosystem(d)
items = append(items, DomainItem{
Expand Down
Loading